All of lore.kernel.org
 help / color / mirror / Atom feed
From: Don Slutz <dslutz@verizon.com>
To: Jan Beulich <JBeulich@suse.com>, Don Slutz <dslutz@verizon.com>
Cc: Ian Campbell <Ian.Campbell@citrix.com>,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	xen-devel@lists.xen.org,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH for 4.5 v7 1/1] Add mmio_hole_size
Date: Tue, 21 Oct 2014 08:58:52 -0400	[thread overview]
Message-ID: <5446588C.1080202@terremark.com> (raw)
In-Reply-To: <54462B6802000078000408A0@mail.emea.novell.com>

On 10/21/14 03:46, Jan Beulich wrote:
>>>> On 21.10.14 at 00:01, <dslutz@verizon.com> wrote:
>> On 10/20/14 10:17, Ian Campbell wrote:

>>>> +            /*
>>>> +             * With HVM_BELOW_4G_RAM_END == 0xF0000000, mmio_hole_size
>>>> +             * must be >= 256 MiB and <= 3840 MiB.
>>> Isn't this just restating the if condition in a way which is liable to
>>> get out of sync if the values of HVM_BELOW_4G_* ever changes?
>> Well, Konrad asked for this:
>> [...]
>> So I do not know which way to go here.
> I have to admit that I think Konrad is asking for too much commentary
> now and then. But in any event - Ian being one of the maintainers of
> the affected code, what he asks you to do generally overrules what
> any non-maintainer may have asked for.

Thanks for this.  Sent v8.

     -Don Slutz

> Jan
>

  parent reply	other threads:[~2014-10-21 12:58 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-13 12:51 [PATCH for 4.5 v7 0/1] Add mmio_hole_size (was Add pci_hole_min_size) Don Slutz
2014-10-13 12:51 ` [PATCH for 4.5 v7 1/1] Add mmio_hole_size Don Slutz
2014-10-14 15:56   ` Konrad Rzeszutek Wilk
2014-10-15 16:12     ` Wei Liu
2014-10-21 12:56       ` Don Slutz
2014-10-20 14:10   ` George Dunlap
2014-10-20 14:17   ` Ian Campbell
2014-10-20 22:01     ` Don Slutz
2014-10-21  7:46       ` Jan Beulich
2014-10-21  7:57         ` Ian Campbell
2014-10-21 12:58         ` Don Slutz [this message]
2014-10-21 14:26         ` Konrad Rzeszutek Wilk
2014-10-21  7:52       ` Ian Campbell
2014-10-23 16:57         ` Steve Freitas
2014-10-23 20:39           ` Andrew Cooper
2014-10-23 20:47             ` Steve Freitas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5446588C.1080202@terremark.com \
    --to=dslutz@verizon.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.