From: Markos Chandras <Markos.Chandras@imgtec.com>
To: Richard Cochran <richardcochran@gmail.com>
Cc: <linux-mips@linux-mips.org>, Jonathan Corbet <corbet@lwn.net>,
<netdev@vger.kernel.org>, <linux-doc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Peter Foley <pefoley2@pefoley.com>
Subject: Re: [PATCH] Documentation: ptp: Fix build failure on MIPS cross builds
Date: Tue, 21 Oct 2014 14:03:45 +0100 [thread overview]
Message-ID: <544659B1.6070509@imgtec.com> (raw)
In-Reply-To: <20141021125240.GB16479@netboy>
On 10/21/2014 01:52 PM, Richard Cochran wrote:
> (adding Peter Foley to CC ...)
>
> On Tue, Oct 21, 2014 at 01:11:22PM +0100, Markos Chandras wrote:
>> On 10/21/2014 12:07 PM, Richard Cochran wrote:
>>> On Mon, Oct 20, 2014 at 09:42:18AM +0100, Markos Chandras wrote:
>>>> diff --git a/Documentation/ptp/Makefile b/Documentation/ptp/Makefile
>>>> index 293d6c09a11f..397c1cd2eda7 100644
>>>> --- a/Documentation/ptp/Makefile
>>>> +++ b/Documentation/ptp/Makefile
>>>> @@ -1,5 +1,15 @@
>>>> # List of programs to build
>>>> +ifndef CROSS_COMPILE
>>>> hostprogs-y := testptp
>>>> +else
>>>> +# MIPS system calls are defined based on the -mabi that is passed
>>>> +# to the toolchain which may or may not be a valid option
>>>> +# for the host toolchain. So disable testptp if target architecture
>>>> +# is MIPS but the host isn't.
>>>> +ifndef CONFIG_MIPS
>>>> +hostprogs-y := testptp
>>>> +endif
>>>> +endif
>>>
>>> It seems like a shame to simply give up and not compile this at all.
>>> Is there no way to correctly cross compile this for MIPS?
>>>
>>> Thanks,
>>> Richard
>>>
>>
>> As far as I can see you don't cross-compile the file. You use the host
>> toolchain.
>
> Look at Documentation/ptp/testptp.mk. There I do use $CROSS_COMPILE.
Hmm I can't see this testptp.mk file in the mainline. What tree are you
referring to?
markos linux (master) $ grep -r CROSS_COMPILE Documentation/ptp/*
markos linux (master) $
--
markos
WARNING: multiple messages have this Message-ID (diff)
From: Markos Chandras <Markos.Chandras@imgtec.com>
To: Richard Cochran <richardcochran@gmail.com>
Cc: linux-mips@linux-mips.org, Jonathan Corbet <corbet@lwn.net>,
netdev@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, Peter Foley <pefoley2@pefoley.com>
Subject: Re: [PATCH] Documentation: ptp: Fix build failure on MIPS cross builds
Date: Tue, 21 Oct 2014 14:03:45 +0100 [thread overview]
Message-ID: <544659B1.6070509@imgtec.com> (raw)
Message-ID: <20141021130345.mBv25QImlR6Wn7cwUiVj3eGm-sAtx9zQtwhiduolWuc@z> (raw)
In-Reply-To: <20141021125240.GB16479@netboy>
On 10/21/2014 01:52 PM, Richard Cochran wrote:
> (adding Peter Foley to CC ...)
>
> On Tue, Oct 21, 2014 at 01:11:22PM +0100, Markos Chandras wrote:
>> On 10/21/2014 12:07 PM, Richard Cochran wrote:
>>> On Mon, Oct 20, 2014 at 09:42:18AM +0100, Markos Chandras wrote:
>>>> diff --git a/Documentation/ptp/Makefile b/Documentation/ptp/Makefile
>>>> index 293d6c09a11f..397c1cd2eda7 100644
>>>> --- a/Documentation/ptp/Makefile
>>>> +++ b/Documentation/ptp/Makefile
>>>> @@ -1,5 +1,15 @@
>>>> # List of programs to build
>>>> +ifndef CROSS_COMPILE
>>>> hostprogs-y := testptp
>>>> +else
>>>> +# MIPS system calls are defined based on the -mabi that is passed
>>>> +# to the toolchain which may or may not be a valid option
>>>> +# for the host toolchain. So disable testptp if target architecture
>>>> +# is MIPS but the host isn't.
>>>> +ifndef CONFIG_MIPS
>>>> +hostprogs-y := testptp
>>>> +endif
>>>> +endif
>>>
>>> It seems like a shame to simply give up and not compile this at all.
>>> Is there no way to correctly cross compile this for MIPS?
>>>
>>> Thanks,
>>> Richard
>>>
>>
>> As far as I can see you don't cross-compile the file. You use the host
>> toolchain.
>
> Look at Documentation/ptp/testptp.mk. There I do use $CROSS_COMPILE.
Hmm I can't see this testptp.mk file in the mainline. What tree are you
referring to?
markos linux (master) $ grep -r CROSS_COMPILE Documentation/ptp/*
markos linux (master) $
--
markos
next prev parent reply other threads:[~2014-10-21 13:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-20 8:42 [PATCH] Documentation: ptp: Fix build failure on MIPS cross builds Markos Chandras
2014-10-20 8:42 ` Markos Chandras
2014-10-21 11:07 ` Richard Cochran
2014-10-21 12:11 ` Markos Chandras
2014-10-21 12:11 ` Markos Chandras
2014-10-21 12:52 ` Richard Cochran
2014-10-21 13:03 ` Markos Chandras [this message]
2014-10-21 13:03 ` Markos Chandras
2014-10-21 13:39 ` Richard Cochran
2014-10-21 16:35 ` David Miller
2014-10-21 16:58 ` David Daney
2014-10-21 18:27 ` Richard Cochran
2014-10-21 22:04 ` Peter Foley
2014-10-22 8:03 ` Richard Cochran
2014-10-22 14:09 ` Peter Foley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544659B1.6070509@imgtec.com \
--to=markos.chandras@imgtec.com \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=netdev@vger.kernel.org \
--cc=pefoley2@pefoley.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.