From: Tomasz Figa <tomasz.figa@gmail.com>
To: Alim Akhtar <alim.akhtar@gmail.com>,
Abhilash Kesavan <a.kesavan@samsung.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"catalin.marinas" <catalin.marinas@arm.com>,
devicetree@vger.kernel.org,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>, robh <robh@kernel.org>
Subject: Re: [PATCH v2 6/7] arm64: dts: Add nodes for mmc, i2c, rtc, watchdog on Exynos7
Date: Tue, 21 Oct 2014 16:00:15 +0200 [thread overview]
Message-ID: <544666EF.9000606@gmail.com> (raw)
In-Reply-To: <CAGOxZ50=1ebU=8r6S_4rbL=82zb3asFTGEjkzNrJPjTkjEGfXg@mail.gmail.com>
On 21.10.2014 15:52, Alim Akhtar wrote:
>> +&mmc_0 {
>> + status = "okay";
>> + num-slots = <1>;
>> + broken-cd;
>> + caps2-mmc-hs200-1_8v;
> Please use mmc_hs200-1_8v instead.
I guess you mean "mmc-hs200-1_8v" (with a hyphen between mmc and hs200).
>> + supports-highspeed;
> As per synopsys-dw-mshc DT binding documentation, supports-highspeed
> property is deprecated, so please use common DT binding for this,
> which is "cap-mmc-highspeed".
>> + non-removable;
>> + card-detect-delay = <200>;
>> + clock-frequency = <800000000>;
>> + samsung,dw-mshc-ciu-div = <3>;
>> + samsung,dw-mshc-sdr-timing = <0 4>;
>> + samsung,dw-mshc-ddr-timing = <0 2>;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_qrdy &sd0_bus1 &sd0_bus4 &sd0_bus8>;
>> + bus-width = <8>;
>> +};
>> +
>> +&mmc_2 {
>> + status = "okay";
>> + num-slots = <1>;
>> + supports-highspeed;
> Here also common DT binding please "cap-sd-highspeed"
Above you suggest "cap-mmc-highspeed" to replace the same deprecated
property, but here "cap-sd-highspeed". What is the rationale behind
using only one particular new property and not both for both controllers?
Best regards,
Tomasz
WARNING: multiple messages have this Message-ID (diff)
From: tomasz.figa@gmail.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 6/7] arm64: dts: Add nodes for mmc, i2c, rtc, watchdog on Exynos7
Date: Tue, 21 Oct 2014 16:00:15 +0200 [thread overview]
Message-ID: <544666EF.9000606@gmail.com> (raw)
In-Reply-To: <CAGOxZ50=1ebU=8r6S_4rbL=82zb3asFTGEjkzNrJPjTkjEGfXg@mail.gmail.com>
On 21.10.2014 15:52, Alim Akhtar wrote:
>> +&mmc_0 {
>> + status = "okay";
>> + num-slots = <1>;
>> + broken-cd;
>> + caps2-mmc-hs200-1_8v;
> Please use mmc_hs200-1_8v instead.
I guess you mean "mmc-hs200-1_8v" (with a hyphen between mmc and hs200).
>> + supports-highspeed;
> As per synopsys-dw-mshc DT binding documentation, supports-highspeed
> property is deprecated, so please use common DT binding for this,
> which is "cap-mmc-highspeed".
>> + non-removable;
>> + card-detect-delay = <200>;
>> + clock-frequency = <800000000>;
>> + samsung,dw-mshc-ciu-div = <3>;
>> + samsung,dw-mshc-sdr-timing = <0 4>;
>> + samsung,dw-mshc-ddr-timing = <0 2>;
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_qrdy &sd0_bus1 &sd0_bus4 &sd0_bus8>;
>> + bus-width = <8>;
>> +};
>> +
>> +&mmc_2 {
>> + status = "okay";
>> + num-slots = <1>;
>> + supports-highspeed;
> Here also common DT binding please "cap-sd-highspeed"
Above you suggest "cap-mmc-highspeed" to replace the same deprecated
property, but here "cap-sd-highspeed". What is the rationale behind
using only one particular new property and not both for both controllers?
Best regards,
Tomasz
next prev parent reply other threads:[~2014-10-21 14:00 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 5:43 [PATCH v2 0/7] Add clock and DT support for a few IPs on Exynos7 Abhilash Kesavan
2014-10-21 5:43 ` Abhilash Kesavan
2014-10-21 5:43 ` [PATCH v2 1/7] clk: samsung: exynos7: add clocks for I2C block Abhilash Kesavan
2014-10-21 5:43 ` Abhilash Kesavan
2014-10-21 5:43 ` [PATCH v2 2/7] clk: samsung: exynos7: add clocks for MMC block Abhilash Kesavan
2014-10-21 5:43 ` Abhilash Kesavan
2014-10-21 5:43 ` [PATCH v2 3/7] clk: samsung: exynos7: add clocks for RTC block Abhilash Kesavan
2014-10-21 5:43 ` Abhilash Kesavan
2014-10-27 16:31 ` Sylwester Nawrocki
2014-10-27 16:31 ` Sylwester Nawrocki
2014-10-28 7:18 ` Abhilash Kesavan
2014-10-28 7:18 ` Abhilash Kesavan
2014-10-21 5:43 ` [PATCH v2 4/7] clk: samsung: exynos7: add gate clocks for WDT, TMU and PWM blocks Abhilash Kesavan
2014-10-21 5:43 ` Abhilash Kesavan
2014-10-21 5:43 ` [PATCH v2 5/7] arm64: dts: Add PMU DT node for exynos7 SoC Abhilash Kesavan
2014-10-21 5:43 ` Abhilash Kesavan
2014-10-21 5:43 ` [PATCH v2 6/7] arm64: dts: Add nodes for mmc, i2c, rtc, watchdog on Exynos7 Abhilash Kesavan
2014-10-21 5:43 ` Abhilash Kesavan
2014-10-21 13:52 ` Alim Akhtar
2014-10-21 13:52 ` Alim Akhtar
2014-10-21 14:00 ` Tomasz Figa [this message]
2014-10-21 14:00 ` Tomasz Figa
2014-10-21 21:35 ` Alim Akhtar
2014-10-21 21:35 ` Alim Akhtar
2014-10-22 13:58 ` Abhilash Kesavan
2014-10-22 13:58 ` Abhilash Kesavan
2014-10-21 5:43 ` [PATCH v2 7/7] arm64: exynos: Enable rtc and watchdog support for Exynos7 Abhilash Kesavan
2014-10-21 5:43 ` Abhilash Kesavan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544666EF.9000606@gmail.com \
--to=tomasz.figa@gmail.com \
--cc=a.kesavan@samsung.com \
--cc=alim.akhtar@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.