Re: [PATCH] fbcon: Fix option parsing control flow in fb_console_setup

[Tomi Valkeinen <tomi.valkeinen@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 850 bytes --]

On 09/10/14 12:48, Maarten ter Huurne wrote:
> Since strsep is used to tokenize the options string, after each option
> match the code should use "continue" to get the next token from strsep.
> This patch applies this pattern consistently.
> 
> Previously, for "scrollback:" and "map:" the parse code would return
> (unconditionally: strsep ensures *options != ','), causing any
> following option to be ignored, while for "vc:" the parse code would
> go on to parse further options within the same token, which could lead
> to invalid input being accepted.
> 
> Signed-off-by: Maarten ter Huurne <maarten@treewalker.org>
> Acked-by: Paul Cercueil <paul@crapouillou.net>
> ---
>  drivers/video/console/fbcon.c | 19 +++++++++----------
>  1 file changed, 9 insertions(+), 10 deletions(-)

Thanks, queued for 3.18 fixes.

 Tomi



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]