All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josh Wu <josh.wu@atmel.com>
To: Vinod Koul <vinod.koul@intel.com>, Herve Codina <herve.codina@celad.com>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
	Michael Grzeschik <m.grzeschik@pengutronix.de>,
	Bo Shen <voice.shen@atmel.com>,
	Wei Yongjun <yongjun_wei@trendmicro.com.cn>,
	Mark Brown <broonie@linaro.org>, HuangShijie <shijie8@gmail.com>,
	Jingoo Han <jg1.han@samsung.com>,
	Nicolas Ferre <nicolas.ferre@atmel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Josh Triplett <josh@joshtriplett.org>,
	BartlomiejZolnierkiewicz <b.zolnierkie@samsung.com>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	EzequielGarcia <ezequiel.garcia@free-electrons.com>,
	Michael Opdenacker <michael.opdenacker@free-electrons.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Brian Norris <computersforpeace@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH 1/2] mtd: atmel_nand: use __iowrite32_copy for 32 bitcopy
Date: Wed, 22 Oct 2014 15:35:29 +0800	[thread overview]
Message-ID: <54475E41.3030205@atmel.com> (raw)
In-Reply-To: <20141021103540.GJ28745@intel.com>

Hi,

On 10/21/2014 6:35 PM, Vinod Koul wrote:
> On Tue, Oct 21, 2014 at 12:20:06PM +0200, Herve Codina wrote:
>> Hi,
> Please don't top post
>> I didn't go deeper in atmel_nand.c code to see other accesses but old
>> copy use writel_relaxed which is a macro to __raw_writel((__force u32)
>> cpu_to_le32(v),c)
>>
>> __iowrite32_copy use directly __raw_writel(*src++, dst++)
>>
>> So we skip cpu_to_le32. Is it ok for all system using atmel_nand ?
> Also would be a good question if we need barriers as __iowrite32_copy()
> doesn't guarantee any ordering.
>

Just diving the code, I found the atmel-nand code use this function to 
transfer write these buffer to NFC sram.
And the NFC sram is not io space.
Also there should has no issue in barriers as it is in a SRAM.

So I think right way is use memcpy function to replace the 
ioread32/iowrite32. Since we use them for SRAM transfer not IO.
I'll prepare a new patch which do above replace.

Best Regards,
Josh Wu

WARNING: multiple messages have this Message-ID (diff)
From: Josh Wu <josh.wu@atmel.com>
To: Vinod Koul <vinod.koul@intel.com>, Herve Codina <herve.codina@celad.com>
Cc: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"David Woodhouse" <dwmw2@infradead.org>,
	Brian Norris <computersforpeace@gmail.com>,
	Jingoo Han <jg1.han@samsung.com>,
	EzequielGarcia <ezequiel.garcia@free-electrons.com>,
	Mark Brown <broonie@linaro.org>,
	Nicolas Ferre <nicolas.ferre@atmel.com>,
	BartlomiejZolnierkiewicz <b.zolnierkie@samsung.com>,
	Bo Shen <voice.shen@atmel.com>,
	Fabio Estevam <fabio.estevam@freescale.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Michael Grzeschik <m.grzeschik@pengutronix.de>,
	Josh Triplett <josh@joshtriplett.org>,
	Wei Yongjun <yongjun_wei@trendmicro.com.cn>,
	HuangShijie <shijie8@gmail.com>,
	Michael Opdenacker <michael.opdenacker@free-electrons.com>
Subject: Re: [PATCH 1/2] mtd: atmel_nand: use __iowrite32_copy for 32 bitcopy
Date: Wed, 22 Oct 2014 15:35:29 +0800	[thread overview]
Message-ID: <54475E41.3030205@atmel.com> (raw)
In-Reply-To: <20141021103540.GJ28745@intel.com>

Hi,

On 10/21/2014 6:35 PM, Vinod Koul wrote:
> On Tue, Oct 21, 2014 at 12:20:06PM +0200, Herve Codina wrote:
>> Hi,
> Please don't top post
>> I didn't go deeper in atmel_nand.c code to see other accesses but old
>> copy use writel_relaxed which is a macro to __raw_writel((__force u32)
>> cpu_to_le32(v),c)
>>
>> __iowrite32_copy use directly __raw_writel(*src++, dst++)
>>
>> So we skip cpu_to_le32. Is it ok for all system using atmel_nand ?
> Also would be a good question if we need barriers as __iowrite32_copy()
> doesn't guarantee any ordering.
>

Just diving the code, I found the atmel-nand code use this function to 
transfer write these buffer to NFC sram.
And the NFC sram is not io space.
Also there should has no issue in barriers as it is in a SRAM.

So I think right way is use memcpy function to replace the 
ioread32/iowrite32. Since we use them for SRAM transfer not IO.
I'll prepare a new patch which do above replace.

Best Regards,
Josh Wu

  reply	other threads:[~2014-10-22  7:36 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-20 16:06 [PATCH 1/2] mtd: atmel_nand: use __iowrite32_copy for 32 bit copy Vinod Koul
2014-10-20 16:06 ` Vinod Koul
2014-10-20 16:06 ` [PATCH 2/2] mtd: mxc_nand: " Vinod Koul
2014-10-20 16:06   ` Vinod Koul
2014-11-05 22:29   ` Brian Norris
2014-11-05 22:29     ` Brian Norris
2014-10-21 10:03 ` [PATCH 1/2] mtd: atmel_nand: " Josh Wu
2014-10-21 10:03   ` Josh Wu
2014-10-21 10:20   ` [PATCH 1/2] mtd: atmel_nand: use __iowrite32_copy for 32 bitcopy Herve Codina
2014-10-21 10:20     ` Herve Codina
2014-10-21 10:35     ` Vinod Koul
2014-10-21 10:35       ` Vinod Koul
2014-10-22  7:35       ` Josh Wu [this message]
2014-10-22  7:35         ` Josh Wu
2014-10-21 10:33   ` [PATCH 1/2] mtd: atmel_nand: use __iowrite32_copy for 32 bit copy Vinod Koul
2014-10-21 10:33     ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54475E41.3030205@atmel.com \
    --to=josh.wu@atmel.com \
    --cc=akpm@linux-foundation.org \
    --cc=b.zolnierkie@samsung.com \
    --cc=broonie@linaro.org \
    --cc=computersforpeace@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=ezequiel.garcia@free-electrons.com \
    --cc=fabio.estevam@freescale.com \
    --cc=herve.codina@celad.com \
    --cc=jg1.han@samsung.com \
    --cc=josh@joshtriplett.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=m.grzeschik@pengutronix.de \
    --cc=michael.opdenacker@free-electrons.com \
    --cc=nicolas.ferre@atmel.com \
    --cc=shijie8@gmail.com \
    --cc=vinod.koul@intel.com \
    --cc=voice.shen@atmel.com \
    --cc=yongjun_wei@trendmicro.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.