From: Mikko Perttunen <mikko.perttunen-/1wQRMveznE@public.gmane.org>
To: Tomeu Vizoso
<tomeu.vizoso-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Javier Martinez Canillas
<javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>,
Thierry Reding
<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Alexandre Courbot
<gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Peter De Schrijver
<pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2 02/12] of: Document long-ram-code property in nvidia,tegra20-apbmisc
Date: Wed, 22 Oct 2014 10:39:15 +0300 [thread overview]
Message-ID: <54475F23.7050900@kapsi.fi> (raw)
In-Reply-To: <1413902788-7727-3-git-send-email-tomeu.vizoso-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
On 10/21/2014 05:45 PM, Tomeu Vizoso wrote:
> Needed to properly decode the ram code register.
>
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
> ---
> Documentation/devicetree/bindings/misc/nvidia,tegra20-apbmisc.txt | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/misc/nvidia,tegra20-apbmisc.txt b/Documentation/devicetree/bindings/misc/nvidia,tegra20-apbmisc.txt
> index b97b8be..e2562ed 100644
> --- a/Documentation/devicetree/bindings/misc/nvidia,tegra20-apbmisc.txt
> +++ b/Documentation/devicetree/bindings/misc/nvidia,tegra20-apbmisc.txt
> @@ -11,3 +11,6 @@ Required properties:
> The second entry gives the physical address and length of the
> registers indicating the strapping options.
>
> +Optional properties:
> +- nvidia,long-ram-code: boolean that tells whether the ram code is long (4 bit)
> + or short (2 bit). If not present, false.
>
I think just "If present, the RAM code is long (4 bit). If not, short (2
bit)" would be clearer, as the booleanness of this property is not
really present in the device tree file.
WARNING: multiple messages have this Message-ID (diff)
From: Mikko Perttunen <mikko.perttunen@kapsi.fi>
To: Tomeu Vizoso <tomeu.vizoso@collabora.com>, linux-tegra@vger.kernel.org
Cc: Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Stephen Warren <swarren@wwwdotorg.org>,
Thierry Reding <thierry.reding@gmail.com>,
Alexandre Courbot <gnurou@gmail.com>,
Peter De Schrijver <pdeschrijver@nvidia.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 02/12] of: Document long-ram-code property in nvidia,tegra20-apbmisc
Date: Wed, 22 Oct 2014 10:39:15 +0300 [thread overview]
Message-ID: <54475F23.7050900@kapsi.fi> (raw)
In-Reply-To: <1413902788-7727-3-git-send-email-tomeu.vizoso@collabora.com>
On 10/21/2014 05:45 PM, Tomeu Vizoso wrote:
> Needed to properly decode the ram code register.
>
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> ---
> Documentation/devicetree/bindings/misc/nvidia,tegra20-apbmisc.txt | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/misc/nvidia,tegra20-apbmisc.txt b/Documentation/devicetree/bindings/misc/nvidia,tegra20-apbmisc.txt
> index b97b8be..e2562ed 100644
> --- a/Documentation/devicetree/bindings/misc/nvidia,tegra20-apbmisc.txt
> +++ b/Documentation/devicetree/bindings/misc/nvidia,tegra20-apbmisc.txt
> @@ -11,3 +11,6 @@ Required properties:
> The second entry gives the physical address and length of the
> registers indicating the strapping options.
>
> +Optional properties:
> +- nvidia,long-ram-code: boolean that tells whether the ram code is long (4 bit)
> + or short (2 bit). If not present, false.
>
I think just "If present, the RAM code is long (4 bit). If not, short (2
bit)" would be clearer, as the booleanness of this property is not
really present in the device tree file.
next prev parent reply other threads:[~2014-10-22 7:39 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 14:45 [PATCH v2 00/12] Tegra124 EMC (external memory controller) support Tomeu Vizoso
2014-10-21 14:45 ` Tomeu Vizoso
2014-10-21 14:45 ` Tomeu Vizoso
2014-10-21 14:45 ` [PATCH v2 01/12] clk: tegra124: Remove old emc clock Tomeu Vizoso
2014-10-21 14:45 ` [PATCH v2 02/12] of: Document long-ram-code property in nvidia,tegra20-apbmisc Tomeu Vizoso
[not found] ` <1413902788-7727-3-git-send-email-tomeu.vizoso-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2014-10-22 7:39 ` Mikko Perttunen [this message]
2014-10-22 7:39 ` Mikko Perttunen
2014-10-21 14:45 ` [PATCH v2 03/12] soc/tegra: Add ram code reader helper Tomeu Vizoso
[not found] ` <1413902788-7727-1-git-send-email-tomeu.vizoso-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2014-10-21 14:45 ` [PATCH v2 04/12] of: document new emc-timings subnode in nvidia,tegra124-car Tomeu Vizoso
2014-10-21 14:45 ` Tomeu Vizoso
2014-10-21 14:45 ` [PATCH v2 09/12] memory: tegra: Add API needed by the EMC driver Tomeu Vizoso
2014-10-21 14:45 ` Tomeu Vizoso
[not found] ` <1413902788-7727-10-git-send-email-tomeu.vizoso-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
2014-10-21 14:53 ` Mikko Perttunen
2014-10-21 14:53 ` Mikko Perttunen
2014-10-21 14:45 ` [PATCH v2 11/12] clk: tegra: Add EMC clock driver Tomeu Vizoso
2014-10-21 14:45 ` Tomeu Vizoso
2014-10-21 14:45 ` [PATCH v2 05/12] of: Document timings subnode of nvidia,tegra-mc Tomeu Vizoso
2014-10-21 14:45 ` [PATCH v2 06/12] of: Add Tegra124 EMC bindings Tomeu Vizoso
2014-10-21 14:45 ` [PATCH v2 07/12] ARM: tegra: Add EMC to Tegra124 device tree Tomeu Vizoso
2014-10-21 14:45 ` Tomeu Vizoso
2014-10-21 14:45 ` Tomeu Vizoso
2014-10-21 14:45 ` [PATCH v2 08/12] ARM: tegra: Add EMC timings to Jetson TK1 " Tomeu Vizoso
2014-10-21 14:45 ` Tomeu Vizoso
2014-10-21 14:45 ` [PATCH v2 10/12] memory: tegra: Add EMC (external memory controller) driver Tomeu Vizoso
2014-10-21 14:45 ` [PATCH v2 12/12] memory: tegra: Add debugfs entry for getting and setting the EMC rate Tomeu Vizoso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54475F23.7050900@kapsi.fi \
--to=mikko.perttunen-/1wqrmvezne@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=pdeschrijver-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=tomeu.vizoso-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.