From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Nishanth Menon <nm@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Tony Lindgren <tony@atomide.com>
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
Jiri Slaby <jslaby@suse.cz>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
"Franklin Cooper Jr." <fcooper@ti.com>
Subject: Re: [PATCH] tty: serial: omap: increase max consoles to 10
Date: Wed, 22 Oct 2014 10:03:36 +0200 [thread overview]
Message-ID: <544764D8.8050804@linutronix.de> (raw)
In-Reply-To: <1413908616-843-1-git-send-email-nm@ti.com>
On 10/21/2014 06:23 PM, Nishanth Menon wrote:
>
> The final solution is to transition off to use 8250 driver and no
> dependency on console structures and move away from omap-serial driver,
> hence no major cleanups are done for this driver.
So the shiny new driver works for you, is this what you are saying?
> diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
> index 18c30ca..4f9cbb6 100644
> --- a/drivers/tty/serial/omap-serial.c
> +++ b/drivers/tty/serial/omap-serial.c
> @@ -46,7 +46,7 @@
>
> #include <dt-bindings/gpio/gpio.h>
>
> -#define OMAP_MAX_HSUART_PORTS 6
> +#define OMAP_MAX_HSUART_PORTS 10
>
> #define UART_BUILD_REVISION(x, y) (((x) << 8) | (y))
Please also add a check in the probe code that "up->port.line" does not
exceed OMAP_MAX_HSUART_PORTS again. So we leave the probe function with
an error code instead.
Sebastian
WARNING: multiple messages have this Message-ID (diff)
From: bigeasy@linutronix.de (Sebastian Andrzej Siewior)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] tty: serial: omap: increase max consoles to 10
Date: Wed, 22 Oct 2014 10:03:36 +0200 [thread overview]
Message-ID: <544764D8.8050804@linutronix.de> (raw)
In-Reply-To: <1413908616-843-1-git-send-email-nm@ti.com>
On 10/21/2014 06:23 PM, Nishanth Menon wrote:
>
> The final solution is to transition off to use 8250 driver and no
> dependency on console structures and move away from omap-serial driver,
> hence no major cleanups are done for this driver.
So the shiny new driver works for you, is this what you are saying?
> diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
> index 18c30ca..4f9cbb6 100644
> --- a/drivers/tty/serial/omap-serial.c
> +++ b/drivers/tty/serial/omap-serial.c
> @@ -46,7 +46,7 @@
>
> #include <dt-bindings/gpio/gpio.h>
>
> -#define OMAP_MAX_HSUART_PORTS 6
> +#define OMAP_MAX_HSUART_PORTS 10
>
> #define UART_BUILD_REVISION(x, y) (((x) << 8) | (y))
Please also add a check in the probe code that "up->port.line" does not
exceed OMAP_MAX_HSUART_PORTS again. So we leave the probe function with
an error code instead.
Sebastian
next prev parent reply other threads:[~2014-10-22 8:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 16:23 [PATCH] tty: serial: omap: increase max consoles to 10 Nishanth Menon
2014-10-21 16:23 ` Nishanth Menon
2014-10-21 16:23 ` Nishanth Menon
2014-10-22 8:03 ` Sebastian Andrzej Siewior [this message]
2014-10-22 8:03 ` Sebastian Andrzej Siewior
2014-10-22 12:24 ` Nishanth Menon
2014-10-22 12:24 ` Nishanth Menon
2014-10-22 12:24 ` Nishanth Menon
2014-10-22 12:46 ` [PATCH V2] tty: serial: omap: Increase max consoles and add check to prevent crash Nishanth Menon
2014-10-22 12:46 ` Nishanth Menon
2014-10-22 12:46 ` Nishanth Menon
2014-10-23 10:16 ` Sebastian Andrzej Siewior
2014-10-23 10:16 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544764D8.8050804@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=fcooper@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=nm@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.