All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Daniel Kiper <daniel.kiper@oracle.com>, xen-devel@lists.xenproject.org
Cc: keir@xen.org, jbeulich@suse.com
Subject: Re: [PATCH] x86/boot/reloc: add memory to clobber list
Date: Wed, 22 Oct 2014 10:58:39 +0100	[thread overview]
Message-ID: <54477FCF.7080001@citrix.com> (raw)
In-Reply-To: <1413925748-10087-3-git-send-email-daniel.kiper@oracle.com>

On 21/10/14 22:09, Daniel Kiper wrote:
> Assembly inline in reloc_mbi_struct() clobbers
> memory so tell compiler about that.
>
> Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

> ---
>  xen/arch/x86/boot/reloc.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/arch/x86/boot/reloc.c b/xen/arch/x86/boot/reloc.c
> index 4609e55..f971920 100644
> --- a/xen/arch/x86/boot/reloc.c
> +++ b/xen/arch/x86/boot/reloc.c
> @@ -46,7 +46,7 @@ static void *reloc_mbi_struct(void *old, unsigned int bytes)
>      "    mov  %0,%%edi                \n"
>      "    rep  movsb                   \n"
>         : "=&r" (new), "+c" (bytes), "+S" (old)
> -	: : "edx", "edi");
> +	: : "edx", "edi", "memory");
>      return new;
>  }
>  

  reply	other threads:[~2014-10-22  9:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-21 21:09 [PATCH v2] x86/boot: fix reloc.S build dependencies Daniel Kiper
2014-10-21 21:09 ` [PATCH v2] x86/boot: use constant in head.S instead of hardcoded value Daniel Kiper
2014-10-22  9:56   ` Andrew Cooper
2014-10-21 21:09 ` [PATCH] x86/boot/reloc: add memory to clobber list Daniel Kiper
2014-10-22  9:58   ` Andrew Cooper [this message]
2014-10-22  9:56 ` [PATCH v2] x86/boot: fix reloc.S build dependencies Andrew Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54477FCF.7080001@citrix.com \
    --to=andrew.cooper3@citrix.com \
    --cc=daniel.kiper@oracle.com \
    --cc=jbeulich@suse.com \
    --cc=keir@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.