* [u-boot-fslc][PATCH] embestmx6boards: Change default bootenv configuration @ 2014-10-22 10:53 Daiane Angolini 2014-10-22 11:29 ` Gary Thomas 2014-10-22 11:31 ` Gary Thomas 0 siblings, 2 replies; 14+ messages in thread From: Daiane Angolini @ 2014-10-22 10:53 UTC (permalink / raw) To: meta-freescale Change CONFIG_MMCROOT and CONFIG_SYS_MMC_ENV_DEV in order to have a smooth boot process with sdcard image built from meta-fsl-arm-extra. Signed-off-by: Daiane Angolini <daiane.angolini@freescale.com> --- include/configs/embestmx6boards.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/configs/embestmx6boards.h b/include/configs/embestmx6boards.h index 185edbe..4005fe9 100644 --- a/include/configs/embestmx6boards.h +++ b/include/configs/embestmx6boards.h @@ -23,7 +23,7 @@ #define CONFIG_MXC_UART_BASE UART2_BASE #define CONFIG_CONSOLE_DEV "ttymxc1" -#define CONFIG_MMCROOT "/dev/mmcblk1p2" +#define CONFIG_MMCROOT "/dev/mmcblk0p2" #define PHYS_SDRAM_SIZE (1u * 1024 * 1024 * 1024) @@ -297,7 +297,7 @@ /* RiOTboard */ #define CONFIG_DEFAULT_FDT_FILE "imx6dl-riotboard.dtb" #define CONFIG_SYS_FSL_USDHC_NUM 3 -#define CONFIG_SYS_MMC_ENV_DEV 2 /* SDHC4 */ +#define CONFIG_SYS_MMC_ENV_DEV 0 /* SDHC4 */ #define CONFIG_ENV_OFFSET (6 * 64 * 1024) #define CONFIG_SUPPORT_EMMC_BOOT /* eMMC specific */ #elif defined(CONFIG_ENV_IS_IN_SPI_FLASH) -- 1.9.1 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [u-boot-fslc][PATCH] embestmx6boards: Change default bootenv configuration 2014-10-22 10:53 [u-boot-fslc][PATCH] embestmx6boards: Change default bootenv configuration Daiane Angolini @ 2014-10-22 11:29 ` Gary Thomas 2014-10-22 12:16 ` Daiane Angolini 2014-10-22 11:31 ` Gary Thomas 1 sibling, 1 reply; 14+ messages in thread From: Gary Thomas @ 2014-10-22 11:29 UTC (permalink / raw) To: meta-freescale On 2014-10-22 04:53, Daiane Angolini wrote: > Change CONFIG_MMCROOT and CONFIG_SYS_MMC_ENV_DEV in > order to have a smooth boot process with sdcard image > built from meta-fsl-arm-extra. > > Signed-off-by: Daiane Angolini <daiane.angolini@freescale.com> > --- > include/configs/embestmx6boards.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/configs/embestmx6boards.h b/include/configs/embestmx6boards.h > index 185edbe..4005fe9 100644 > --- a/include/configs/embestmx6boards.h > +++ b/include/configs/embestmx6boards.h > @@ -23,7 +23,7 @@ > > #define CONFIG_MXC_UART_BASE UART2_BASE > #define CONFIG_CONSOLE_DEV "ttymxc1" > -#define CONFIG_MMCROOT "/dev/mmcblk1p2" > +#define CONFIG_MMCROOT "/dev/mmcblk0p2" > > #define PHYS_SDRAM_SIZE (1u * 1024 * 1024 * 1024) > > @@ -297,7 +297,7 @@ > /* RiOTboard */ > #define CONFIG_DEFAULT_FDT_FILE "imx6dl-riotboard.dtb" > #define CONFIG_SYS_FSL_USDHC_NUM 3 > -#define CONFIG_SYS_MMC_ENV_DEV 2 /* SDHC4 */ > +#define CONFIG_SYS_MMC_ENV_DEV 0 /* SDHC4 */ Shouldn't you update this comment to reflect the appropriate SD controller, or was it incorrect before? > #define CONFIG_ENV_OFFSET (6 * 64 * 1024) > #define CONFIG_SUPPORT_EMMC_BOOT /* eMMC specific */ > #elif defined(CONFIG_ENV_IS_IN_SPI_FLASH) > -- ------------------------------------------------------------ Gary Thomas | Consulting for the MLB Associates | Embedded world ------------------------------------------------------------ ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [u-boot-fslc][PATCH] embestmx6boards: Change default bootenv configuration 2014-10-22 11:29 ` Gary Thomas @ 2014-10-22 12:16 ` Daiane Angolini 0 siblings, 0 replies; 14+ messages in thread From: Daiane Angolini @ 2014-10-22 12:16 UTC (permalink / raw) To: Gary Thomas; +Cc: meta-freescale@yoctoproject.org On Wed, Oct 22, 2014 at 9:29 AM, Gary Thomas <gary@mlbassoc.com> wrote: > On 2014-10-22 04:53, Daiane Angolini wrote: >> >> Change CONFIG_MMCROOT and CONFIG_SYS_MMC_ENV_DEV in >> order to have a smooth boot process with sdcard image >> built from meta-fsl-arm-extra. >> >> Signed-off-by: Daiane Angolini <daiane.angolini@freescale.com> >> --- >> include/configs/embestmx6boards.h | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/include/configs/embestmx6boards.h >> b/include/configs/embestmx6boards.h >> index 185edbe..4005fe9 100644 >> --- a/include/configs/embestmx6boards.h >> +++ b/include/configs/embestmx6boards.h >> @@ -23,7 +23,7 @@ >> >> #define CONFIG_MXC_UART_BASE UART2_BASE >> #define CONFIG_CONSOLE_DEV "ttymxc1" >> -#define CONFIG_MMCROOT "/dev/mmcblk1p2" >> +#define CONFIG_MMCROOT "/dev/mmcblk0p2" >> >> #define PHYS_SDRAM_SIZE (1u * 1024 * 1024 * 1024) >> >> @@ -297,7 +297,7 @@ >> /* RiOTboard */ >> #define CONFIG_DEFAULT_FDT_FILE "imx6dl-riotboard.dtb" >> #define CONFIG_SYS_FSL_USDHC_NUM 3 >> -#define CONFIG_SYS_MMC_ENV_DEV 2 /* SDHC4 */ >> +#define CONFIG_SYS_MMC_ENV_DEV 0 /* SDHC4 */ > > > Shouldn't you update this comment to reflect the appropriate SD > controller, or was it incorrect before? You should be right. I´m going to double check and send v2. Thanks Daiane > >> #define CONFIG_ENV_OFFSET (6 * 64 * 1024) >> #define CONFIG_SUPPORT_EMMC_BOOT /* eMMC specific */ >> #elif defined(CONFIG_ENV_IS_IN_SPI_FLASH) >> > > -- > ------------------------------------------------------------ > Gary Thomas | Consulting for the > MLB Associates | Embedded world > ------------------------------------------------------------ > > -- > _______________________________________________ > meta-freescale mailing list > meta-freescale@yoctoproject.org > https://lists.yoctoproject.org/listinfo/meta-freescale ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [u-boot-fslc][PATCH] embestmx6boards: Change default bootenv configuration 2014-10-22 10:53 [u-boot-fslc][PATCH] embestmx6boards: Change default bootenv configuration Daiane Angolini 2014-10-22 11:29 ` Gary Thomas @ 2014-10-22 11:31 ` Gary Thomas 2014-10-22 12:18 ` Daiane Angolini 1 sibling, 1 reply; 14+ messages in thread From: Gary Thomas @ 2014-10-22 11:31 UTC (permalink / raw) To: meta-freescale On 2014-10-22 04:53, Daiane Angolini wrote: > Change CONFIG_MMCROOT and CONFIG_SYS_MMC_ENV_DEV in > order to have a smooth boot process with sdcard image > built from meta-fsl-arm-extra. > > Signed-off-by: Daiane Angolini <daiane.angolini@freescale.com> > --- > include/configs/embestmx6boards.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/configs/embestmx6boards.h b/include/configs/embestmx6boards.h > index 185edbe..4005fe9 100644 > --- a/include/configs/embestmx6boards.h > +++ b/include/configs/embestmx6boards.h > @@ -23,7 +23,7 @@ > > #define CONFIG_MXC_UART_BASE UART2_BASE > #define CONFIG_CONSOLE_DEV "ttymxc1" > -#define CONFIG_MMCROOT "/dev/mmcblk1p2" > +#define CONFIG_MMCROOT "/dev/mmcblk0p2" > > #define PHYS_SDRAM_SIZE (1u * 1024 * 1024 * 1024) > > @@ -297,7 +297,7 @@ > /* RiOTboard */ > #define CONFIG_DEFAULT_FDT_FILE "imx6dl-riotboard.dtb" > #define CONFIG_SYS_FSL_USDHC_NUM 3 > -#define CONFIG_SYS_MMC_ENV_DEV 2 /* SDHC4 */ > +#define CONFIG_SYS_MMC_ENV_DEV 0 /* SDHC4 */ > #define CONFIG_ENV_OFFSET (6 * 64 * 1024) > #define CONFIG_SUPPORT_EMMC_BOOT /* eMMC specific */ > #elif defined(CONFIG_ENV_IS_IN_SPI_FLASH) > Also, how does this patch apply to meta-freescale (meta-fsl-arm)? -- ------------------------------------------------------------ Gary Thomas | Consulting for the MLB Associates | Embedded world ------------------------------------------------------------ ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [u-boot-fslc][PATCH] embestmx6boards: Change default bootenv configuration 2014-10-22 11:31 ` Gary Thomas @ 2014-10-22 12:18 ` Daiane Angolini 2014-10-22 12:22 ` Eric Bénard 0 siblings, 1 reply; 14+ messages in thread From: Daiane Angolini @ 2014-10-22 12:18 UTC (permalink / raw) To: Gary Thomas; +Cc: meta-freescale@yoctoproject.org On Wed, Oct 22, 2014 at 9:31 AM, Gary Thomas <gary@mlbassoc.com> wrote: > On 2014-10-22 04:53, Daiane Angolini wrote: >> >> Change CONFIG_MMCROOT and CONFIG_SYS_MMC_ENV_DEV in >> order to have a smooth boot process with sdcard image >> built from meta-fsl-arm-extra. >> >> Signed-off-by: Daiane Angolini <daiane.angolini@freescale.com> >> --- >> include/configs/embestmx6boards.h | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/include/configs/embestmx6boards.h >> b/include/configs/embestmx6boards.h >> index 185edbe..4005fe9 100644 >> --- a/include/configs/embestmx6boards.h >> +++ b/include/configs/embestmx6boards.h >> @@ -23,7 +23,7 @@ >> >> #define CONFIG_MXC_UART_BASE UART2_BASE >> #define CONFIG_CONSOLE_DEV "ttymxc1" >> -#define CONFIG_MMCROOT "/dev/mmcblk1p2" >> +#define CONFIG_MMCROOT "/dev/mmcblk0p2" >> >> #define PHYS_SDRAM_SIZE (1u * 1024 * 1024 * 1024) >> >> @@ -297,7 +297,7 @@ >> /* RiOTboard */ >> #define CONFIG_DEFAULT_FDT_FILE "imx6dl-riotboard.dtb" >> #define CONFIG_SYS_FSL_USDHC_NUM 3 >> -#define CONFIG_SYS_MMC_ENV_DEV 2 /* SDHC4 */ >> +#define CONFIG_SYS_MMC_ENV_DEV 0 /* SDHC4 */ >> #define CONFIG_ENV_OFFSET (6 * 64 * 1024) >> #define CONFIG_SUPPORT_EMMC_BOOT /* eMMC specific */ >> #elif defined(CONFIG_ENV_IS_IN_SPI_FLASH) >> > > Also, how does this patch apply to meta-freescale (meta-fsl-arm)? I need this applied on u-boot-fslc, after that, update the u-boot-fslc recipe, in order to add a new machine conf file. Daiane > > -- > ------------------------------------------------------------ > Gary Thomas | Consulting for the > MLB Associates | Embedded world > ------------------------------------------------------------ > -- > _______________________________________________ > meta-freescale mailing list > meta-freescale@yoctoproject.org > https://lists.yoctoproject.org/listinfo/meta-freescale ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [u-boot-fslc][PATCH] embestmx6boards: Change default bootenv configuration 2014-10-22 12:18 ` Daiane Angolini @ 2014-10-22 12:22 ` Eric Bénard 2014-10-22 12:29 ` Daiane Angolini 0 siblings, 1 reply; 14+ messages in thread From: Eric Bénard @ 2014-10-22 12:22 UTC (permalink / raw) To: Daiane Angolini; +Cc: meta-freescale@yoctoproject.org, Gary Thomas Hi Daiane, Le Wed, 22 Oct 2014 10:18:59 -0200, Daiane Angolini <daiane.list@gmail.com> a écrit : > > I need this applied on u-boot-fslc, after that, update the u-boot-fslc > recipe, in order to add a new machine conf file. > why don't you submit it to u-boot mailing list as this board's support is mainline and not Yocto centric ? Eric ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [u-boot-fslc][PATCH] embestmx6boards: Change default bootenv configuration 2014-10-22 12:22 ` Eric Bénard @ 2014-10-22 12:29 ` Daiane Angolini 2014-10-22 12:37 ` Fabio Estevam 0 siblings, 1 reply; 14+ messages in thread From: Daiane Angolini @ 2014-10-22 12:29 UTC (permalink / raw) To: Eric Bénard; +Cc: meta-freescale@yoctoproject.org, Gary Thomas On Wed, Oct 22, 2014 at 10:22 AM, Eric Bénard <eric@eukrea.com> wrote: > Hi Daiane, > > Le Wed, 22 Oct 2014 10:18:59 -0200, > Daiane Angolini <daiane.list@gmail.com> a écrit : >> >> I need this applied on u-boot-fslc, after that, update the u-boot-fslc >> recipe, in order to add a new machine conf file. >> > why don't you submit it to u-boot mailing list as this board's support > is mainline and not Yocto centric ? I´m not comfortable to upstream this change because I don´t have Mars board to test it. Daiane > > Eric ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [u-boot-fslc][PATCH] embestmx6boards: Change default bootenv configuration 2014-10-22 12:29 ` Daiane Angolini @ 2014-10-22 12:37 ` Fabio Estevam 2014-10-22 13:06 ` Daiane Angolini 0 siblings, 1 reply; 14+ messages in thread From: Fabio Estevam @ 2014-10-22 12:37 UTC (permalink / raw) To: Daiane Angolini; +Cc: meta-freescale@yoctoproject.org, Gary Thomas Hi Daiane, On Wed, Oct 22, 2014 at 10:29 AM, Daiane Angolini <daiane.list@gmail.com> wrote: >> why don't you submit it to u-boot mailing list as this board's support >> is mainline and not Yocto centric ? > > I´m not comfortable to upstream this change because I don´t have Mars > board to test it. I agree with Eric's suggestion. Please send the patch to the U-boot list and Cc Eric, as he is the maintainer for the Mars board in U-boot :-) ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [u-boot-fslc][PATCH] embestmx6boards: Change default bootenv configuration 2014-10-22 12:37 ` Fabio Estevam @ 2014-10-22 13:06 ` Daiane Angolini 2014-10-22 13:12 ` Eric Bénard 0 siblings, 1 reply; 14+ messages in thread From: Daiane Angolini @ 2014-10-22 13:06 UTC (permalink / raw) To: Fabio Estevam; +Cc: meta-freescale@yoctoproject.org, Gary Thomas On Wed, Oct 22, 2014 at 10:37 AM, Fabio Estevam <festevam@gmail.com> wrote: > Hi Daiane, > > On Wed, Oct 22, 2014 at 10:29 AM, Daiane Angolini <daiane.list@gmail.com> wrote: > >>> why don't you submit it to u-boot mailing list as this board's support >>> is mainline and not Yocto centric ? >> >> I´m not comfortable to upstream this change because I don´t have Mars >> board to test it. > > I agree with Eric's suggestion. Please send the patch to the U-boot > list and Cc Eric, as he is the maintainer for the Mars board in U-boot > :-) In this case, I must rework the patch. Do you think both changes can share the same patch? Or it would be better to split them? My reason to change this default value is "to have a smooth boot process with sdcard image built from meta-fsl-arm-extra", however it does not look good enough to be upstreamed. Would you have a suggestion? Daiane ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [u-boot-fslc][PATCH] embestmx6boards: Change default bootenv configuration 2014-10-22 13:06 ` Daiane Angolini @ 2014-10-22 13:12 ` Eric Bénard 2014-10-22 15:49 ` Otavio Salvador 0 siblings, 1 reply; 14+ messages in thread From: Eric Bénard @ 2014-10-22 13:12 UTC (permalink / raw) To: Daiane Angolini; +Cc: meta-freescale@yoctoproject.org, Gary Thomas Le Wed, 22 Oct 2014 11:06:31 -0200, Daiane Angolini <daiane.list@gmail.com> a écrit : > > On Wed, Oct 22, 2014 at 10:37 AM, Fabio Estevam <festevam@gmail.com> wrote: > > Hi Daiane, > > > > On Wed, Oct 22, 2014 at 10:29 AM, Daiane Angolini <daiane.list@gmail.com> wrote: > > > >>> why don't you submit it to u-boot mailing list as this board's support > >>> is mainline and not Yocto centric ? > >> > >> I´m not comfortable to upstream this change because I don´t have Mars > >> board to test it. > > > > I agree with Eric's suggestion. Please send the patch to the U-boot > > list and Cc Eric, as he is the maintainer for the Mars board in U-boot > > :-) > > In this case, I must rework the patch. Do you think both changes can > share the same patch? Or it would be better to split them? > > My reason to change this default value is "to have a smooth boot > process with sdcard image built from meta-fsl-arm-extra", however it > does not look good enough to be upstreamed. Would you have a > suggestion? > if that's only meta-fsl-arm-extra focused then I would suggest to simply add a .bbappend and the patch to your board support inside meta-fsl-arm-extra. Eric ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [u-boot-fslc][PATCH] embestmx6boards: Change default bootenv configuration 2014-10-22 13:12 ` Eric Bénard @ 2014-10-22 15:49 ` Otavio Salvador 2014-10-22 15:56 ` Eric Bénard 0 siblings, 1 reply; 14+ messages in thread From: Otavio Salvador @ 2014-10-22 15:49 UTC (permalink / raw) To: Eric Bénard; +Cc: meta-freescale@yoctoproject.org, Gary Thomas On Wed, Oct 22, 2014 at 11:12 AM, Eric Bénard <eric@eukrea.com> wrote: > Le Wed, 22 Oct 2014 11:06:31 -0200, > Daiane Angolini <daiane.list@gmail.com> a écrit : > >> >> On Wed, Oct 22, 2014 at 10:37 AM, Fabio Estevam <festevam@gmail.com> wrote: >> > Hi Daiane, >> > >> > On Wed, Oct 22, 2014 at 10:29 AM, Daiane Angolini <daiane.list@gmail.com> wrote: >> > >> >>> why don't you submit it to u-boot mailing list as this board's support >> >>> is mainline and not Yocto centric ? >> >> >> >> I´m not comfortable to upstream this change because I don´t have Mars >> >> board to test it. >> > >> > I agree with Eric's suggestion. Please send the patch to the U-boot >> > list and Cc Eric, as he is the maintainer for the Mars board in U-boot >> > :-) >> >> In this case, I must rework the patch. Do you think both changes can >> share the same patch? Or it would be better to split them? >> >> My reason to change this default value is "to have a smooth boot >> process with sdcard image built from meta-fsl-arm-extra", however it >> does not look good enough to be upstreamed. Would you have a >> suggestion? >> > if that's only meta-fsl-arm-extra focused then I would suggest to simply > add a .bbappend and the patch to your board support inside > meta-fsl-arm-extra. I putted some thought on this and I think it is better to apply this kind of fix in u-boot-fslc repository; this eases the maintenance work of the board, U-Boot and upgrade when newer versions are released. That said, I also think this ought to be upstreamed and you (Eric) being the board maintainer in U-Boot are in the position to say if it would work for Mars or not. We don't have Mars in meta-fsl-arm-extra so we don't need to worry much about it in the moment from meta-fsl-arm-extra perspective. So I think you (Eric) need to say if you'd be Ok with a patch to change it globally in U-Boot or not. -- Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750 ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [u-boot-fslc][PATCH] embestmx6boards: Change default bootenv configuration 2014-10-22 15:49 ` Otavio Salvador @ 2014-10-22 15:56 ` Eric Bénard 2014-10-22 16:15 ` Otavio Salvador 0 siblings, 1 reply; 14+ messages in thread From: Eric Bénard @ 2014-10-22 15:56 UTC (permalink / raw) To: Otavio Salvador; +Cc: meta-freescale@yoctoproject.org, Gary Thomas Hi Otavio, Le Wed, 22 Oct 2014 13:49:54 -0200, Otavio Salvador <otavio@ossystems.com.br> a écrit : > > On Wed, Oct 22, 2014 at 11:12 AM, Eric Bénard <eric@eukrea.com> wrote: > > Le Wed, 22 Oct 2014 11:06:31 -0200, > > Daiane Angolini <daiane.list@gmail.com> a écrit : > > > >> > >> On Wed, Oct 22, 2014 at 10:37 AM, Fabio Estevam <festevam@gmail.com> wrote: > >> > Hi Daiane, > >> > > >> > On Wed, Oct 22, 2014 at 10:29 AM, Daiane Angolini <daiane.list@gmail.com> wrote: > >> > > >> >>> why don't you submit it to u-boot mailing list as this board's support > >> >>> is mainline and not Yocto centric ? > >> >> > >> >> I´m not comfortable to upstream this change because I don´t have Mars > >> >> board to test it. > >> > > >> > I agree with Eric's suggestion. Please send the patch to the U-boot > >> > list and Cc Eric, as he is the maintainer for the Mars board in U-boot > >> > :-) > >> > >> In this case, I must rework the patch. Do you think both changes can > >> share the same patch? Or it would be better to split them? > >> > >> My reason to change this default value is "to have a smooth boot > >> process with sdcard image built from meta-fsl-arm-extra", however it > >> does not look good enough to be upstreamed. Would you have a > >> suggestion? > >> > > if that's only meta-fsl-arm-extra focused then I would suggest to simply > > add a .bbappend and the patch to your board support inside > > meta-fsl-arm-extra. > > I putted some thought on this and I think it is better to apply this > kind of fix in u-boot-fslc repository; this eases the maintenance work > of the board, U-Boot and upgrade when newer versions are released. > > That said, I also think this ought to be upstreamed and you (Eric) > being the board maintainer in U-Boot are in the position to say if it > would work for Mars or not. We don't have Mars in meta-fsl-arm-extra > so we don't need to worry much about it in the moment from > meta-fsl-arm-extra perspective. > > So I think you (Eric) need to say if you'd be Ok with a patch to > change it globally in U-Boot or not. > my understanding is that this patch is to allow the direct boot when booting on an SDcard with u-boot. The default configuration of u-boot was done to support the eMMC which is soldered on the boards. So in the present case that's a change for a specific usage requiring an extra SDCard. Maybe a more generic solution would be to have a script which automatically detects the boot source and adjusts the bootargs accordingly. Or to generate 2 u-boot binaries : one for the internal eMMC, one for the external SD. Eric ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [u-boot-fslc][PATCH] embestmx6boards: Change default bootenv configuration 2014-10-22 15:56 ` Eric Bénard @ 2014-10-22 16:15 ` Otavio Salvador 2014-10-22 16:21 ` Fabio Estevam 0 siblings, 1 reply; 14+ messages in thread From: Otavio Salvador @ 2014-10-22 16:15 UTC (permalink / raw) To: Eric Bénard; +Cc: meta-freescale@yoctoproject.org, Gary Thomas On Wed, Oct 22, 2014 at 1:56 PM, Eric Bénard <eric@eukrea.com> wrote: > Le Wed, 22 Oct 2014 13:49:54 -0200, > Otavio Salvador <otavio@ossystems.com.br> a écrit : >> On Wed, Oct 22, 2014 at 11:12 AM, Eric Bénard <eric@eukrea.com> wrote: >> > Le Wed, 22 Oct 2014 11:06:31 -0200, >> > Daiane Angolini <daiane.list@gmail.com> a écrit : >> > >> >> >> >> On Wed, Oct 22, 2014 at 10:37 AM, Fabio Estevam <festevam@gmail.com> wrote: >> >> > Hi Daiane, >> >> > >> >> > On Wed, Oct 22, 2014 at 10:29 AM, Daiane Angolini <daiane.list@gmail.com> wrote: >> >> > >> >> >>> why don't you submit it to u-boot mailing list as this board's support >> >> >>> is mainline and not Yocto centric ? >> >> >> >> >> >> I´m not comfortable to upstream this change because I don´t have Mars >> >> >> board to test it. >> >> > >> >> > I agree with Eric's suggestion. Please send the patch to the U-boot >> >> > list and Cc Eric, as he is the maintainer for the Mars board in U-boot >> >> > :-) >> >> >> >> In this case, I must rework the patch. Do you think both changes can >> >> share the same patch? Or it would be better to split them? >> >> >> >> My reason to change this default value is "to have a smooth boot >> >> process with sdcard image built from meta-fsl-arm-extra", however it >> >> does not look good enough to be upstreamed. Would you have a >> >> suggestion? >> >> >> > if that's only meta-fsl-arm-extra focused then I would suggest to simply >> > add a .bbappend and the patch to your board support inside >> > meta-fsl-arm-extra. >> >> I putted some thought on this and I think it is better to apply this >> kind of fix in u-boot-fslc repository; this eases the maintenance work >> of the board, U-Boot and upgrade when newer versions are released. >> >> That said, I also think this ought to be upstreamed and you (Eric) >> being the board maintainer in U-Boot are in the position to say if it >> would work for Mars or not. We don't have Mars in meta-fsl-arm-extra >> so we don't need to worry much about it in the moment from >> meta-fsl-arm-extra perspective. >> >> So I think you (Eric) need to say if you'd be Ok with a patch to >> change it globally in U-Boot or not. >> > my understanding is that this patch is to allow the direct > boot when booting on an SDcard with u-boot. > > The default configuration of u-boot was done to support the eMMC which > is soldered on the boards. > > So in the present case that's a change for a specific usage requiring > an extra SDCard. > > Maybe a more generic solution would be to have a script which > automatically detects the boot source and adjusts the bootargs > accordingly. > Or to generate 2 u-boot binaries : one for the internal eMMC, one for > the external SD. Agreed; so I think Daiane's patch can be applied in our fork as interim solution until we move these board to the new Distro-like scripts which are available in U-Boot now. -- Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750 ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [u-boot-fslc][PATCH] embestmx6boards: Change default bootenv configuration 2014-10-22 16:15 ` Otavio Salvador @ 2014-10-22 16:21 ` Fabio Estevam 0 siblings, 0 replies; 14+ messages in thread From: Fabio Estevam @ 2014-10-22 16:21 UTC (permalink / raw) To: Otavio Salvador; +Cc: meta-freescale@yoctoproject.org, Gary Thomas On Wed, Oct 22, 2014 at 2:15 PM, Otavio Salvador <otavio@ossystems.com.br> wrote: > Agreed; so I think Daiane's patch can be applied in our fork as > interim solution until we move these board to the new Distro-like > scripts which are available in U-Boot now. Sounds like a good approach. ^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2014-10-22 16:21 UTC | newest] Thread overview: 14+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-10-22 10:53 [u-boot-fslc][PATCH] embestmx6boards: Change default bootenv configuration Daiane Angolini 2014-10-22 11:29 ` Gary Thomas 2014-10-22 12:16 ` Daiane Angolini 2014-10-22 11:31 ` Gary Thomas 2014-10-22 12:18 ` Daiane Angolini 2014-10-22 12:22 ` Eric Bénard 2014-10-22 12:29 ` Daiane Angolini 2014-10-22 12:37 ` Fabio Estevam 2014-10-22 13:06 ` Daiane Angolini 2014-10-22 13:12 ` Eric Bénard 2014-10-22 15:49 ` Otavio Salvador 2014-10-22 15:56 ` Eric Bénard 2014-10-22 16:15 ` Otavio Salvador 2014-10-22 16:21 ` Fabio Estevam
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.