From: Stefan Bader <stefan.bader@canonical.com>
To: David Vrabel <david.vrabel@citrix.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
konrad.wilk@oracle.com
Cc: daniel.kiper@oracle.com, xen-devel@lists.xen.org
Subject: Re: [PATCH v2] xen/balloon: Don't continue ballooning when BP_ECANCELED is encountered
Date: Wed, 22 Oct 2014 16:42:35 +0200 [thread overview]
Message-ID: <5447C25B.3060701@canonical.com> (raw)
In-Reply-To: <5436C343.2080102@citrix.com>
[-- Attachment #1.1: Type: text/plain, Size: 1050 bytes --]
On 09.10.2014 19:17, David Vrabel wrote:
> On 07/10/14 22:00, Boris Ostrovsky wrote:
>> Commit 3dcf63677d4e ("xen/balloon: cancel ballooning if adding new
>> memory failed") makes reserve_additional_memory() return BP_ECANCELED
>> when an error is encountered. This error, however, is ignored by the
>> caller (balloon_process()) since it is overwritten by subsequent call
>> to update_schedule(). This results in continuous attempts to add more
>> memory, all of which are likely to fail again.
>>
>> We should stop trying to schedule next iteration of ballooning when
>> the current one has failed.
>
> What triggers this bug? I could never work out what it was.
>
> Applied to stable/for-linus-3.18
I just checked in the kernel upstream repo and cannot find this but I believe
the initial pull was already made. Or was there a revert that I missed?
-Stefan
>
> David
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
>
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2014-10-22 14:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-07 21:00 [PATCH v2] xen/balloon: Don't continue ballooning when BP_ECANCELED is encountered Boris Ostrovsky
2014-10-08 7:30 ` Daniel Kiper
2014-10-08 7:30 ` Daniel Kiper
2014-10-09 17:17 ` David Vrabel
2014-10-09 17:42 ` Boris Ostrovsky
2014-10-22 14:42 ` Stefan Bader [this message]
2014-10-22 14:52 ` David Vrabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5447C25B.3060701@canonical.com \
--to=stefan.bader@canonical.com \
--cc=boris.ostrovsky@oracle.com \
--cc=daniel.kiper@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.