From: "H. Peter Anvin" <hpa@zytor.com>
To: David Vrabel <david.vrabel@citrix.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
tglx@linutronix.de, mingo@redhat.com, konrad.wilk@oracle.com
Cc: tianyu.lan@intel.com, xen-devel@lists.xenproject.org,
linux-kernel@vger.kernel.org
Subject: Re: [Xen-devel] [PATCH v2] xen/smp: Use die_complete completion when taking CPU down
Date: Wed, 22 Oct 2014 08:36:37 -0700 [thread overview]
Message-ID: <5447CF05.4070802@zytor.com> (raw)
In-Reply-To: <5447CE2B.5090101@citrix.com>
On 10/22/2014 08:32 AM, David Vrabel wrote:
> On 16/10/14 17:47, Boris Ostrovsky wrote:
>> Commit 2ed53c0d6cc9 ("x86/smpboot: Speed up suspend/resume by avoiding
>> 100ms sleep for CPU offline during S3") introduced completions to CPU
>> offlining process. These completions are not initialized on Xen kernels
>> causing a panic in play_dead_common().
>>
>> Move handling of die_complete into common routines to make them
>> available to Xen guests.
>>
>> (Also, while at it, move these routines as well as die_complete under
>> ifdef CONFIG_HOTPLUG_CPU)
>
> Reviewed-by: David Vrabel <david.vrabel@citrix.com>
>
> I can merge this via the Xen tree if that is preferred.
>
Since it touches non-Xen code I'd rather not.
-hpa
next prev parent reply other threads:[~2014-10-22 15:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-16 16:47 [PATCH v2] xen/smp: Use die_complete completion when taking CPU down Boris Ostrovsky
2014-10-22 15:32 ` [Xen-devel] " David Vrabel
2014-10-22 15:36 ` H. Peter Anvin [this message]
2014-10-22 15:36 ` H. Peter Anvin
2014-10-22 15:32 ` David Vrabel
2014-10-22 15:37 ` H. Peter Anvin
2014-10-22 15:44 ` Boris Ostrovsky
2014-10-22 15:44 ` Boris Ostrovsky
2014-10-22 15:37 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5447CF05.4070802@zytor.com \
--to=hpa@zytor.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=tianyu.lan@intel.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.