From: "H. Peter Anvin" <hpa@zytor.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
tglx@linutronix.de, mingo@redhat.com, konrad.wilk@oracle.com,
david.vrabel@citrix.com
Cc: tianyu.lan@intel.com, linux-kernel@vger.kernel.org,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v2] xen/smp: Use die_complete completion when taking CPU down
Date: Wed, 22 Oct 2014 08:37:11 -0700 [thread overview]
Message-ID: <5447CF27.2040506@zytor.com> (raw)
In-Reply-To: <1413478046-4987-1-git-send-email-boris.ostrovsky@oracle.com>
On 10/16/2014 09:47 AM, Boris Ostrovsky wrote:
> diff --git a/arch/x86/include/asm/smp.h b/arch/x86/include/asm/smp.h
> index 8cd27e0..a78c509 100644
> --- a/arch/x86/include/asm/smp.h
> +++ b/arch/x86/include/asm/smp.h
> @@ -149,7 +149,11 @@ static inline void arch_send_call_function_ipi_mask(const struct cpumask *mask)
> smp_ops.send_call_func_ipi(mask);
> }
>
> +#ifdef CONFIG_HOTPLUG_CPU
> void cpu_disable_common(void);
> +void cpu_die_common(unsigned int cpu);
> +void play_dead_common(void);
> +#endif
We generally don't #ifdef prototypes unless they are inlines or macros
in the unconfiged case.
-hpa
next prev parent reply other threads:[~2014-10-22 15:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-16 16:47 [PATCH v2] xen/smp: Use die_complete completion when taking CPU down Boris Ostrovsky
2014-10-22 15:32 ` [Xen-devel] " David Vrabel
2014-10-22 15:36 ` H. Peter Anvin
2014-10-22 15:36 ` H. Peter Anvin
2014-10-22 15:32 ` David Vrabel
2014-10-22 15:37 ` H. Peter Anvin
2014-10-22 15:37 ` H. Peter Anvin [this message]
2014-10-22 15:44 ` Boris Ostrovsky
2014-10-22 15:44 ` Boris Ostrovsky
-- strict thread matches above, loose matches on Subject: below --
2014-10-16 16:47 Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5447CF27.2040506@zytor.com \
--to=hpa@zytor.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=tianyu.lan@intel.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.