All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] of/fdt: Fix EARLY_FLATTREE crash with no DTB
@ 2014-10-23 11:10 Phil Elwell
  0 siblings, 0 replies; only message in thread
From: Phil Elwell @ 2014-10-23 11:10 UTC (permalink / raw)
  To: devicetree-u79uwXL29TY76Z2rM5mHXA

of_flat_dt_debugfs_export_fdt uses initial_boot_params without checking
if it is valid, and ends up dereferencing a NULL pointer if there is
no DT blob.

This patch adds a check that initial_boot_params is NULL, returning
-ENOENT if it is.

Signed-off-by: Phil Elwell <phil-FnsA7b+Nu9XbIbC87yuRow@public.gmane.org>
---
  drivers/of/fdt.c | 6 +++++-
  1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
index d1ffca8..f018e5b 100644
--- a/drivers/of/fdt.c
+++ b/drivers/of/fdt.c
@@ -1085,8 +1085,12 @@ static struct debugfs_blob_wrapper flat_dt_blob;

  static int __init of_flat_dt_debugfs_export_fdt(void)
  {
-    struct dentry *d = debugfs_create_dir("device-tree", NULL);
+    struct dentry *d;

+    if (!initial_boot_params)
+        return -ENOENT;
+
+    d = debugfs_create_dir("device-tree", NULL);
      if (!d)
          return -ENOENT;

-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2014-10-23 11:10 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-23 11:10 [PATCH] of/fdt: Fix EARLY_FLATTREE crash with no DTB Phil Elwell

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.