From: Julien Grall <julien.grall@linaro.org>
To: Ian Campbell <Ian.Campbell@citrix.com>,
Frediano Ziglio <freddy77@gmail.com>
Cc: Stefano Stabellini <stefano.stabellini@citrix.com>,
xen-devel@lists.xen.org, Tim Deegan <tim@xen.org>
Subject: Re: [PATCH for-xen-4-5 v3] xen/arm: dump guest stack even if not the current VCPU
Date: Thu, 23 Oct 2014 12:56:03 +0100 [thread overview]
Message-ID: <5448ECD3.7090001@linaro.org> (raw)
In-Reply-To: <1414063877.1140.0.camel@citrix.com>
On 10/23/2014 12:31 PM, Ian Campbell wrote:
> On Thu, 2014-10-23 at 09:46 +0100, Frediano Ziglio wrote:
>> From: Frediano Ziglio <frediano.ziglio@huawei.com>
>>
>> If show_guest_stack was called from Xen context (for instance hitting
>> '0' key on Xen console) get_page_from_gva was not able to get the
>> page returning NULL.
>> Detecting different domain and changing VTTBR register make
>> get_page_from_gva works for different domains.
>>
>> Signed-off-by: Frediano Ziglio <frediano.ziglio@huawei.com>
>
> Acked + applied (since Konrad said ok in v2).
>
>> - collapse change in a single if to improve performances.
>
> Not 100% keen on the duplicated call to gvirt_to_maddr, but it'll do.
I think having two if with gvirt_to_maddr in the middle would have been
fine. My main concern was disabling the IRQ before taking the lock.
Anyway, I plan to send a patch for 4.6 to improve this function. The p2m
is taken for a long time for nothing.
Regards,
--
Julien Grall
next prev parent reply other threads:[~2014-10-23 11:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-23 8:46 [PATCH for-xen-4-5 v3] xen/arm: dump guest stack even if not the current VCPU Frediano Ziglio
2014-10-23 11:30 ` Ian Campbell
2014-10-23 11:34 ` Ian Campbell
2014-10-23 11:31 ` Ian Campbell
2014-10-23 11:56 ` Julien Grall [this message]
2014-10-23 12:08 ` Frediano Ziglio
2014-10-23 12:14 ` Ian Campbell
2014-10-23 15:02 ` Frediano Ziglio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5448ECD3.7090001@linaro.org \
--to=julien.grall@linaro.org \
--cc=Ian.Campbell@citrix.com \
--cc=freddy77@gmail.com \
--cc=stefano.stabellini@citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.