All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
	Al Viro <viro@ZenIV.linux.org.uk>
Cc: Sami Liedes <sami.liedes@iki.fi>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: Intentionally corrupted vfat fs causing BUG
Date: Thu, 23 Oct 2014 18:55:46 +0200	[thread overview]
Message-ID: <54493312.7070606@nod.at> (raw)
In-Reply-To: <8738ae91cw.fsf@devron.myhome.or.jp>

Am 23.10.2014 um 18:50 schrieb OGAWA Hirofumi:
> OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> writes:
> 
>> Al Viro <viro@ZenIV.linux.org.uk> writes:
>>
>>> On Thu, Oct 23, 2014 at 05:01:06PM +0100, Al Viro wrote:
>>>
>>>> Hmm...  Why hadn't d_splice_alias() caught that, though?
>>>
>>> Aha.  It's not namei_msdos.c part, it's namei_vfat.c one.  And there
>>> we don't call d_splice_alias() on the affected path...
>>>
>>> OK, so your check isn't enough.  What we need there is this:
>>> 	if (alias && alias->d_parent == dentry->d_parent && ...)
>>> Otherwise that d_move() isn't safe at all.
>>
>> Hm, sounds like I'm missing something. what case has different
>> ->d_parent on alias if prevented by my check?
> 
> You meant the case of more complex double linked loop?

Yes. This is why I came up with the alias->d_parent == dentry->d_parent check.

Thanks,
//richard

  reply	other threads:[~2014-10-23 16:55 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-10 20:57 Intentionally corrupted vfat fs causing BUG Sami Liedes
2014-10-11 10:20 ` Richard Weinberger
2014-10-12 12:08 ` OGAWA Hirofumi
2014-10-12 19:04   ` Richard Weinberger
2014-10-12 20:40     ` Sami Liedes
2014-10-13  7:57     ` OGAWA Hirofumi
2014-10-13  8:22       ` Richard Weinberger
2014-10-13  8:35         ` OGAWA Hirofumi
2014-10-13  8:39           ` Richard Weinberger
2014-10-13  8:59             ` OGAWA Hirofumi
2014-10-13 14:36               ` Richard Weinberger
2014-10-19 16:36               ` Richard Weinberger
2014-10-23 15:28                 ` OGAWA Hirofumi
2014-10-23 16:01                   ` Al Viro
2014-10-23 16:16                     ` Al Viro
2014-10-23 16:45                       ` OGAWA Hirofumi
2014-10-23 16:50                         ` OGAWA Hirofumi
2014-10-23 16:55                           ` Richard Weinberger [this message]
2014-10-23 16:55                         ` Al Viro
2014-10-23 17:21                           ` Al Viro
2014-10-23 17:58                             ` OGAWA Hirofumi
2014-10-23 20:46                             ` Sami Liedes
2014-10-23 17:35                           ` OGAWA Hirofumi
2014-10-23 17:54                           ` J. Bruce Fields
2014-10-23 18:05                             ` Al Viro
2014-10-23 18:16                               ` J. Bruce Fields
2014-10-23 16:56                         ` Al Viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54493312.7070606@nod.at \
    --to=richard@nod.at \
    --cc=hirofumi@mail.parknet.co.jp \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=sami.liedes@iki.fi \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.