Re: Intentionally corrupted vfat fs causing BUG

[OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>]

Al Viro <viro@ZenIV.linux.org.uk> writes:

> On Fri, Oct 24, 2014 at 01:45:49AM +0900, OGAWA Hirofumi wrote:
>
>> d_splice_alias() calls __d_find_alias() with want_discon==1, so
>> __d_find_alias() doesn't return dentry, and d_splice_alias() doesn't use
>> d_move() path, right?
>
> Hmm...  Not in the current mainline (and not because of want_discon - that's
> gone already).  However, with the fixes I've got in the local tree it
> will both find and move it - same as d_materialise_unique() would in the
> current mainline.

Ah, I see. Checked latest linus tree, looks like added some checks (I
was still working on 3.6.15, sorry).

So, Richard, can you add comment such as

	/* Check FS corruption, will handle by d_splice_alias() */

for that less understandable check, and resend patch with your
Signed-off-by: (better to Cc: akpm)?

Acked-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

Thanks.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>