From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Simon Horman <horms+renesas@verge.net.au>, linux-ide@vger.kernel.org
Cc: Yoshihiro Kaneko <ykaneko0929@gmail.com>,
Magnus Damm <magnus.damm@gmail.com>,
linux-sh@vger.kernel.org
Subject: Re: [PATCH v2] ata: sata_rcar: Disable DIPM mode for r8a7790 ES1
Date: Fri, 24 Oct 2014 14:47:19 +0400 [thread overview]
Message-ID: <544A2E37.6090206@cogentembedded.com> (raw)
In-Reply-To: <1414116319-16813-1-git-send-email-horms+renesas@verge.net.au>
Hello.
On 10/24/2014 6:05 AM, Simon Horman wrote:
> Unlike other SATA R-Car r8a7790 controllers the r8a7790 ES1 SATA R-Car
> controller needs to be run with DIPM disabled.
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
> v2
> * Handle ES1 in sata_rcar_init_controller()
> ---
> Documentation/devicetree/bindings/ata/sata_rcar.txt | 3 ++-
> drivers/ata/sata_rcar.c | 11 +++++++++++
> 2 files changed, 13 insertions(+), 1 deletion(-)
[...]
> diff --git a/drivers/ata/sata_rcar.c b/drivers/ata/sata_rcar.c
> index 61eb6d7..b398513 100644
> --- a/drivers/ata/sata_rcar.c
> +++ b/drivers/ata/sata_rcar.c
[...]
> @@ -763,6 +764,10 @@ static void sata_rcar_setup_port(struct ata_host *host)
> ap->udma_mask = ATA_UDMA6;
> ap->flags |= ATA_FLAG_SATA;
>
> + if (priv->type == RCAR_R8A7790_ES1_SATA) {
> + ap->flags |= ATA_FLAG_NO_DIPM;
> + }
> +
Please, please drop {}. I think checkpatch.pl should complain about them...
[...]
MBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Simon Horman <horms+renesas@verge.net.au>, linux-ide@vger.kernel.org
Cc: Yoshihiro Kaneko <ykaneko0929@gmail.com>,
Magnus Damm <magnus.damm@gmail.com>,
linux-sh@vger.kernel.org
Subject: Re: [PATCH v2] ata: sata_rcar: Disable DIPM mode for r8a7790 ES1
Date: Fri, 24 Oct 2014 10:47:19 +0000 [thread overview]
Message-ID: <544A2E37.6090206@cogentembedded.com> (raw)
In-Reply-To: <1414116319-16813-1-git-send-email-horms+renesas@verge.net.au>
Hello.
On 10/24/2014 6:05 AM, Simon Horman wrote:
> Unlike other SATA R-Car r8a7790 controllers the r8a7790 ES1 SATA R-Car
> controller needs to be run with DIPM disabled.
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
> v2
> * Handle ES1 in sata_rcar_init_controller()
> ---
> Documentation/devicetree/bindings/ata/sata_rcar.txt | 3 ++-
> drivers/ata/sata_rcar.c | 11 +++++++++++
> 2 files changed, 13 insertions(+), 1 deletion(-)
[...]
> diff --git a/drivers/ata/sata_rcar.c b/drivers/ata/sata_rcar.c
> index 61eb6d7..b398513 100644
> --- a/drivers/ata/sata_rcar.c
> +++ b/drivers/ata/sata_rcar.c
[...]
> @@ -763,6 +764,10 @@ static void sata_rcar_setup_port(struct ata_host *host)
> ap->udma_mask = ATA_UDMA6;
> ap->flags |= ATA_FLAG_SATA;
>
> + if (priv->type = RCAR_R8A7790_ES1_SATA) {
> + ap->flags |= ATA_FLAG_NO_DIPM;
> + }
> +
Please, please drop {}. I think checkpatch.pl should complain about them...
[...]
MBR, Sergei
next prev parent reply other threads:[~2014-10-24 10:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-24 2:05 [PATCH v2] ata: sata_rcar: Disable DIPM mode for r8a7790 ES1 Simon Horman
2014-10-24 2:05 ` Simon Horman
2014-10-24 7:42 ` Magnus Damm
2014-10-24 7:42 ` Magnus Damm
2014-10-24 10:47 ` Sergei Shtylyov [this message]
2014-10-24 10:47 ` Sergei Shtylyov
2014-10-27 0:14 ` Simon Horman
2014-10-27 0:14 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544A2E37.6090206@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=horms+renesas@verge.net.au \
--cc=linux-ide@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=ykaneko0929@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.