* [PATCH] vdso: don't require 64-bit math in standalone test
@ 2014-10-24 18:48 Jeff Mahoney
2014-10-24 18:56 ` Peter Foley
2014-10-24 19:12 ` Randy Dunlap
0 siblings, 2 replies; 4+ messages in thread
From: Jeff Mahoney @ 2014-10-24 18:48 UTC (permalink / raw)
To: Linux Kernel Maling List, Randy Dunlap, Peter Foley
The use of 64-bit math on i386 causes build failures:
vdso_standalone_test_x86.c:(.text+0x101): undefined reference to `__umoddi3'
vdso_standalone_test_x86.c:(.text+0x12d): undefined reference to `__udivdi3'
Commit adb19fb66ee (Documentation: add makefiles for more targets) is
now building this by default, so it's failing the kernel build entirely.
Switching the declaration from uint64_t to time_t does the right thing
and handles the x32 case automatically.
Signed-off-by: Jeff Mahoney <jeffm@suse.com>
---
Documentation/vDSO/vdso_standalone_test_x86.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/Documentation/vDSO/vdso_standalone_test_x86.c
+++ b/Documentation/vDSO/vdso_standalone_test_x86.c
@@ -63,7 +63,7 @@ static inline void linux_exit(int code)
x86_syscall3(__NR_exit, code, 0, 0);
}
-void to_base10(char *lastdig, uint64_t n)
+void to_base10(char *lastdig, time_t n)
{
while (n) {
*lastdig = (n % 10) + '0';
--
Jeff Mahoney
SUSE Labs
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] vdso: don't require 64-bit math in standalone test
2014-10-24 18:48 [PATCH] vdso: don't require 64-bit math in standalone test Jeff Mahoney
@ 2014-10-24 18:56 ` Peter Foley
2014-10-24 19:12 ` Randy Dunlap
1 sibling, 0 replies; 4+ messages in thread
From: Peter Foley @ 2014-10-24 18:56 UTC (permalink / raw)
To: Jeff Mahoney; +Cc: Linux Kernel Maling List, Randy Dunlap
On Fri, Oct 24, 2014 at 2:48 PM, Jeff Mahoney <jeffm@suse.com> wrote:
> The use of 64-bit math on i386 causes build failures:
> vdso_standalone_test_x86.c:(.text+0x101): undefined reference to `__umoddi3'
> vdso_standalone_test_x86.c:(.text+0x12d): undefined reference to `__udivdi3'
>
> Commit adb19fb66ee (Documentation: add makefiles for more targets) is
> now building this by default, so it's failing the kernel build entirely.
>
> Switching the declaration from uint64_t to time_t does the right thing
> and handles the x32 case automatically.
>
> Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Acked-by: Peter Foley <pefoley2@pefoley.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] vdso: don't require 64-bit math in standalone test
2014-10-24 18:48 [PATCH] vdso: don't require 64-bit math in standalone test Jeff Mahoney
2014-10-24 18:56 ` Peter Foley
@ 2014-10-24 19:12 ` Randy Dunlap
2014-10-25 14:56 ` Jonathan Corbet
1 sibling, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2014-10-24 19:12 UTC (permalink / raw)
To: Jeff Mahoney, Linux Kernel Maling List, Peter Foley,
Jonathan Corbet
On 10/24/14 11:48, Jeff Mahoney wrote:
> The use of 64-bit math on i386 causes build failures:
> vdso_standalone_test_x86.c:(.text+0x101): undefined reference to `__umoddi3'
> vdso_standalone_test_x86.c:(.text+0x12d): undefined reference to `__udivdi3'
>
> Commit adb19fb66ee (Documentation: add makefiles for more targets) is
> now building this by default, so it's failing the kernel build entirely.
>
> Switching the declaration from uint64_t to time_t does the right thing
> and handles the x32 case automatically.
>
> Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Jon, please pick this up. It was
Acked-by: Peter Foley <pefoley2@pefoley.com>
> ---
> Documentation/vDSO/vdso_standalone_test_x86.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/Documentation/vDSO/vdso_standalone_test_x86.c
> +++ b/Documentation/vDSO/vdso_standalone_test_x86.c
> @@ -63,7 +63,7 @@ static inline void linux_exit(int code)
> x86_syscall3(__NR_exit, code, 0, 0);
> }
>
> -void to_base10(char *lastdig, uint64_t n)
> +void to_base10(char *lastdig, time_t n)
> {
> while (n) {
> *lastdig = (n % 10) + '0';
>
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] vdso: don't require 64-bit math in standalone test
2014-10-24 19:12 ` Randy Dunlap
@ 2014-10-25 14:56 ` Jonathan Corbet
0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Corbet @ 2014-10-25 14:56 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Jeff Mahoney, Linux Kernel Maling List, Peter Foley
On Fri, 24 Oct 2014 12:12:58 -0700
Randy Dunlap <rdunlap@infradead.org> wrote:
> Jon, please pick this up. It was
> Acked-by: Peter Foley <pefoley2@pefoley.com>
Done.
jon
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-10-25 19:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-24 18:48 [PATCH] vdso: don't require 64-bit math in standalone test Jeff Mahoney
2014-10-24 18:56 ` Peter Foley
2014-10-24 19:12 ` Randy Dunlap
2014-10-25 14:56 ` Jonathan Corbet
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.