From: Gary Thomas <gary@mlbassoc.com>
To: meta-freescale@yoctoproject.org
Subject: Re: [meta-fsl-arm-extra][PATCH] imx6dl-riotboard: Add support for RIoT board
Date: Fri, 24 Oct 2014 14:02:40 -0600 [thread overview]
Message-ID: <544AB060.7030101@mlbassoc.com> (raw)
In-Reply-To: <CAOMZO5ApU8G32zhH6QnrdD_gmX5Dk6SwKybfvhe_GNviNr1YXA@mail.gmail.com>
On 2014-10-24 13:09, Fabio Estevam wrote:
> On Fri, Oct 24, 2014 at 4:50 PM, Daiane Angolini
> <daiane.angolini@freescale.com> wrote:
>> Signed-off-by: Daiane Angolini <daiane.angolini@freescale.com>
>
> A brief commit log would be helpful and also a link to
> http://riotboard.org/ could help so people can know the details about
> the board.
>
>> ---
>> conf/machine/imx6dl-riotboard.conf | 17 +++++++++++++++++
>> 1 file changed, 17 insertions(+)
>> create mode 100644 conf/machine/imx6dl-riotboard.conf
>>
>> diff --git a/conf/machine/imx6dl-riotboard.conf b/conf/machine/imx6dl-riotboard.conf
>> new file mode 100644
>> index 0000000..fc6dd42
>> --- /dev/null
>> +++ b/conf/machine/imx6dl-riotboard.conf
>> @@ -0,0 +1,17 @@
>> +#@TYPE: Machine
>> +#@NAME: RIoTboard
>> +#@SOC: i.MX6S
>> +#@DESCRIPTION: Machine configuration for i.MX6S RIoTboard.
>> +#@MAINTAINER: Daiane Angolini <daiane.angolini@freescale.com>
>> +
>> +include conf/machine/include/imx-base.inc
>> +include conf/machine/include/tune-cortexa9.inc
>> +
>> +SOC_FAMILY = "mx6:mx6dl"
>> +
>> +UBOOT_MACHINE = "riotboard_defconfig"
>> +
>> +PREFERRED_PROVIDER_virtual/kernel ?= "linux-fslc"
>> +KERNEL_DEVICETREE = "imx6dl-riotboard.dtb"
>> +
>> +SERIAL_CONSOLE = "115200 ttymxc1"
>
> Patch looks good, but just a general comment about SERIAL_CONSOLE: do
> we really need to hardcode the ttymxcX node in the conf files?
>
> Can't this just be passed by the bootloader or via 'stdout-path' in the dts?
>
> If someone wants to test this same rootfs on a board that uses ttymxc0
> then it is not possible due to the mismatch caused by SERIAL_CONSOLE.
>
> What happens if SERIAL_CONSOLE is not passed or if only
> "SERIAL_CONSOLE = "115200" is passed?
>
At least if you are using sysvinit, this is how the choice of
where to put the system login is specified. (I'm not sure of
systemd - I don't use that)
--
------------------------------------------------------------
Gary Thomas | Consulting for the
MLB Associates | Embedded world
------------------------------------------------------------
prev parent reply other threads:[~2014-10-24 20:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-24 18:50 [meta-fsl-arm-extra][PATCH] imx6dl-riotboard: Add support for RIoT board Daiane Angolini
2014-10-24 19:09 ` Fabio Estevam
2014-10-24 19:56 ` Eric Bénard
2014-10-24 20:02 ` Gary Thomas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544AB060.7030101@mlbassoc.com \
--to=gary@mlbassoc.com \
--cc=meta-freescale@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.