From: Jens Axboe <axboe@kernel.dk>
To: Mike Frysinger <vapier@chromium.org>,
Gwendal Grignou <gwendal@chromium.org>
Cc: fio@vger.kernel.org, Puthikorn Voravootivat <puthik@chromium.org>
Subject: Re: [PATCH] fio: fix alignement to prevent bus error on ARM
Date: Fri, 24 Oct 2014 14:49:21 -0600 [thread overview]
Message-ID: <544ABB51.1040107@kernel.dk> (raw)
In-Reply-To: <CAAbOScn8QgtqeM6A20p9Zy1vBkcyDuk4R1ia34u+Q=KKJtnc+Q@mail.gmail.com>
On 10/24/2014 02:47 PM, Mike Frysinger wrote:
> the code seems to be fine with gcc-isms, so i might suggest anon unions
> instead to make it harder to break:
> union {
> uint64_t __aligner;
> uint16_t continue_on_error;
> };
It's not a bad idea... Your commit broke alignment further down, btw,
but I fixed it up.
I'll be happy to take anon union patches for the alignment parts :-)
--
Jens Axboe
next prev parent reply other threads:[~2014-10-24 20:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-24 20:42 [PATCH] fio: fix alignement to prevent bus error on ARM Gwendal Grignou
2014-10-24 20:44 ` Jens Axboe
2014-10-24 20:47 ` Mike Frysinger
2014-10-24 20:49 ` Jens Axboe [this message]
2014-10-24 21:06 ` [PATCH v2] fio: Fix padding properly Gwendal Grignou
2014-10-24 21:21 ` Gwendal Grignou
2014-10-24 21:32 ` [PATCH v3] " Gwendal Grignou
2014-10-25 23:04 ` [PATCH v4] " Gwendal Grignou
2014-10-27 14:50 ` Jens Axboe
2014-10-27 16:50 ` [PATCH v5] " Gwendal Grignou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544ABB51.1040107@kernel.dk \
--to=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=gwendal@chromium.org \
--cc=puthik@chromium.org \
--cc=vapier@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.