From: Jens Axboe <axboe@kernel.dk>
To: Gwendal Grignou <gwendal@chromium.org>
Cc: fio@vger.kernel.org, vapier@chromium.org, puthik@chromium.org
Subject: Re: [PATCH v4] fio: Fix padding properly
Date: Mon, 27 Oct 2014 08:50:12 -0600 [thread overview]
Message-ID: <544E5BA4.1070505@kernel.dk> (raw)
In-Reply-To: <1414278272-14168-1-git-send-email-gwendal@chromium.org>
On 10/25/2014 05:04 PM, Gwendal Grignou wrote:
> diff --git a/stat.h b/stat.h
> index 16b3d1a..db83f65 100644
> --- a/stat.h
> +++ b/stat.h
> @@ -158,6 +158,8 @@ struct thread_stat {
> uint32_t io_u_lat_u[FIO_IO_U_LAT_U_NR];
> uint32_t io_u_lat_m[FIO_IO_U_LAT_M_NR];
> uint32_t io_u_plat[DDIR_RWDIR_CNT][FIO_IO_U_PLAT_NR];
> + uint32_t pad;
> +
> uint64_t total_io_u[3];
> uint64_t short_io_u[3];
> uint64_t drop_io_u[3];
> @@ -171,8 +173,10 @@ struct thread_stat {
> /*
> * IO Error related stats
> */
> - uint16_t continue_on_error;
> - uint16_t filler[3];
> + union {
> + uint16_t continue_on_error;
> + uint64_t pad;
> + };
> uint64_t total_err_count;
> uint32_t first_error;
>
These two hunks are both in struct thread_stat, the compile wont be
happy about the duplicate naming...
--
Jens Axboe
next prev parent reply other threads:[~2014-10-27 14:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-24 20:42 [PATCH] fio: fix alignement to prevent bus error on ARM Gwendal Grignou
2014-10-24 20:44 ` Jens Axboe
2014-10-24 20:47 ` Mike Frysinger
2014-10-24 20:49 ` Jens Axboe
2014-10-24 21:06 ` [PATCH v2] fio: Fix padding properly Gwendal Grignou
2014-10-24 21:21 ` Gwendal Grignou
2014-10-24 21:32 ` [PATCH v3] " Gwendal Grignou
2014-10-25 23:04 ` [PATCH v4] " Gwendal Grignou
2014-10-27 14:50 ` Jens Axboe [this message]
2014-10-27 16:50 ` [PATCH v5] " Gwendal Grignou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544E5BA4.1070505@kernel.dk \
--to=axboe@kernel.dk \
--cc=fio@vger.kernel.org \
--cc=gwendal@chromium.org \
--cc=puthik@chromium.org \
--cc=vapier@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.