From: "Andreas Bießmann" <andreas.devel@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] net: macb: enable GMAC IP without GE feature support
Date: Sat, 25 Oct 2014 00:23:29 +0200 [thread overview]
Message-ID: <544AD161.3020606@googlemail.com> (raw)
In-Reply-To: <1410854244-30424-3-git-send-email-voice.shen@atmel.com>
Hi Bo,
On 16.09.14 09:57, Bo Shen wrote:
> The User Register in GMAC IP is used to select interface type.
> When with GE feature, it is used to select interface between
> RGMII and GMII. If without GE feature, it is used to select
> interface between MII and RMII.
>
> Signed-off-by: Bo Shen <voice.shen@atmel.com>
> ---
>
> drivers/net/macb.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/macb.c b/drivers/net/macb.c
> index 01a94a4..369d155 100644
> --- a/drivers/net/macb.c
> +++ b/drivers/net/macb.c
> @@ -574,7 +574,13 @@ static int macb_init(struct eth_device *netdev, bd_t *bd)
> macb_writel(macb, TBQP, macb->tx_ring_dma);
>
> if (macb_is_gem(macb)) {
> -#ifdef CONFIG_RGMII
> + /*
> + * When the GMAC IP with GE feature, this bit is used to
> + * select interface between RGMII and GMII.
> + * When the GMAC IP without GE feature, this bit is used
> + * to select interface between RMII and MII.
> + */
> +#if defined(CONFIG_RGMII) || defined(CONFIG_RMII)
> gem_writel(macb, UR, GEM_BIT(RGMII));
> #else
> gem_writel(macb, UR, 0);
>
looks good
Best regards
Andreas Bie?mann
next prev parent reply other threads:[~2014-10-24 22:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-16 7:57 [U-Boot] [PATCH 0/3] ARM: atmel: add sama5d4ek board support Bo Shen
2014-09-16 7:57 ` [U-Boot] [PATCH 1/3] atmel_nand: if don't have gf table in rom code we will build it runtime Bo Shen
2014-10-24 22:22 ` Andreas Bießmann
2014-10-27 1:47 ` Bo Shen
2014-10-27 3:31 ` Josh Wu
2014-10-28 8:05 ` Bo Shen
2014-10-28 9:27 ` Bo Shen
2014-10-28 9:34 ` Andreas Bießmann
2014-09-16 7:57 ` [U-Boot] [PATCH 2/3] net: macb: enable GMAC IP without GE feature support Bo Shen
2014-10-24 22:23 ` Andreas Bießmann [this message]
2014-09-16 7:57 ` [U-Boot] [PATCH 3/3] ARM: atmel: add sama5d4ek board support Bo Shen
2014-10-25 0:26 ` Andreas Bießmann
2014-10-27 3:25 ` Bo Shen
2014-09-19 8:10 ` [U-Boot] [PATCH 0/3] " Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544AD161.3020606@googlemail.com \
--to=andreas.devel@googlemail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.