From: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
linux-kernel@vger.kernel.org, Ben Dooks <ben-linux@fluff.org>,
Kukjin Kim <kgene.kim@samsung.com>,
Russell King <linux@arm.linux.org.uk>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
Kyungmin Park <kyungmin.park@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>
Subject: Re: [PATCH v4 2/3] regulator: max77686: Implement suspend disable for some LDOs
Date: Mon, 27 Oct 2014 11:32:40 +0100 [thread overview]
Message-ID: <544E1F48.9050105@collabora.co.uk> (raw)
In-Reply-To: <1414405641.1674.1.camel@AMDC1943>
On 10/27/2014 11:27 AM, Krzysztof Kozlowski wrote:
>
> Storing opmode in non-shifted form is intuitive also to me. That's way I
> slipped the bug in previous version.
>
Great.
> I'll change this to non-shifted opmode. The patch will grow bigger but
> the code should be more readable.
>
Maybe split in two patches? A preparatory that adds max77686_get_opmode_shift()
and changes the current driver and a second one that implements suspend disable
for LDOs?
> Thanks!
You are welcome.
Best regards,
Javier
WARNING: multiple messages have this Message-ID (diff)
From: javier.martinez@collabora.co.uk (Javier Martinez Canillas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 2/3] regulator: max77686: Implement suspend disable for some LDOs
Date: Mon, 27 Oct 2014 11:32:40 +0100 [thread overview]
Message-ID: <544E1F48.9050105@collabora.co.uk> (raw)
In-Reply-To: <1414405641.1674.1.camel@AMDC1943>
On 10/27/2014 11:27 AM, Krzysztof Kozlowski wrote:
>
> Storing opmode in non-shifted form is intuitive also to me. That's way I
> slipped the bug in previous version.
>
Great.
> I'll change this to non-shifted opmode. The patch will grow bigger but
> the code should be more readable.
>
Maybe split in two patches? A preparatory that adds max77686_get_opmode_shift()
and changes the current driver and a second one that implements suspend disable
for LDOs?
> Thanks!
You are welcome.
Best regards,
Javier
next prev parent reply other threads:[~2014-10-27 10:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-27 9:44 [PATCH v4 0/3] regulator: max77686/trats2: Disable some regulators in suspend Krzysztof Kozlowski
2014-10-27 9:44 ` Krzysztof Kozlowski
2014-10-27 9:44 ` [PATCH v4 1/3] regulator: max77686: Replace hard-coded opmode values with defines Krzysztof Kozlowski
2014-10-27 9:44 ` Krzysztof Kozlowski
2014-10-27 9:44 ` [PATCH v4 2/3] regulator: max77686: Implement suspend disable for some LDOs Krzysztof Kozlowski
2014-10-27 9:44 ` Krzysztof Kozlowski
2014-10-27 9:44 ` Krzysztof Kozlowski
2014-10-27 10:08 ` Javier Martinez Canillas
2014-10-27 10:08 ` Javier Martinez Canillas
2014-10-27 10:27 ` Krzysztof Kozlowski
2014-10-27 10:27 ` Krzysztof Kozlowski
2014-10-27 10:32 ` Javier Martinez Canillas [this message]
2014-10-27 10:32 ` Javier Martinez Canillas
2014-10-27 10:35 ` Krzysztof Kozlowski
2014-10-27 10:35 ` Krzysztof Kozlowski
2014-10-27 9:44 ` [PATCH v4 3/3] ARM: dts: exynos4412-trats: Add suspend configuration for max77686 regulators Krzysztof Kozlowski
2014-10-27 9:44 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544E1F48.9050105@collabora.co.uk \
--to=javier.martinez@collabora.co.uk \
--cc=b.zolnierkie@samsung.com \
--cc=ben-linux@fluff.org \
--cc=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=k.kozlowski@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.