From: Marc Zyngier <marc.zyngier@arm.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Abhijeet Dharmapurikar <adharmap@codeaurora.org>,
Phong Vo <pvo@apm.com>, Linus Walleij <linus.walleij@linaro.org>,
Tin Huynh <tnhuynh@apm.com>, Y Vo <yvo@apm.com>,
Toan Le <toanle@apm.com>, Bjorn Andersson <bjorn@kryo.se>,
Arnd Bergmann <arnd@arndb.de>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/3] genirq: Allow the irqchip state of an IRQ to be save/restored
Date: Mon, 27 Oct 2014 11:47:02 +0000 [thread overview]
Message-ID: <544E30B6.7060902@arm.com> (raw)
In-Reply-To: <alpine.DEB.2.11.1410252136220.5308@nanos>
On 25/10/14 20:42, Thomas Gleixner wrote:
> On Sat, 25 Oct 2014, Thomas Gleixner wrote:
>
> Bah, hit send way too fast :)
>
>> On Sat, 25 Oct 2014, Marc Zyngier wrote:
>>> +int irq_get_irqchip_state(unsigned int irq, int state)
>
> get_state(state) does not make sense. get_state(which) probably more
> so. And 'which' wants to be an enum btw.
>
>>> + chip_bus_lock(desc);
>>> + val = chip->irq_get_irqchip_state(data, state);
>>
>> Hmm. What's the irq_get_irqchip_state() callback supposed to return?
>
> Either an error code or a boolean value, right? Does not mix very well
> I think.
>
> int irq_get_irqchip_state(unsigned int irq, enum xxx which, bool *val)
>
> Might be a more clear interface.
Agreed, this makes a lot of sense. Will respin it.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
WARNING: multiple messages have this Message-ID (diff)
From: marc.zyngier@arm.com (Marc Zyngier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] genirq: Allow the irqchip state of an IRQ to be save/restored
Date: Mon, 27 Oct 2014 11:47:02 +0000 [thread overview]
Message-ID: <544E30B6.7060902@arm.com> (raw)
In-Reply-To: <alpine.DEB.2.11.1410252136220.5308@nanos>
On 25/10/14 20:42, Thomas Gleixner wrote:
> On Sat, 25 Oct 2014, Thomas Gleixner wrote:
>
> Bah, hit send way too fast :)
>
>> On Sat, 25 Oct 2014, Marc Zyngier wrote:
>>> +int irq_get_irqchip_state(unsigned int irq, int state)
>
> get_state(state) does not make sense. get_state(which) probably more
> so. And 'which' wants to be an enum btw.
>
>>> + chip_bus_lock(desc);
>>> + val = chip->irq_get_irqchip_state(data, state);
>>
>> Hmm. What's the irq_get_irqchip_state() callback supposed to return?
>
> Either an error code or a boolean value, right? Does not mix very well
> I think.
>
> int irq_get_irqchip_state(unsigned int irq, enum xxx which, bool *val)
>
> Might be a more clear interface.
Agreed, this makes a lot of sense. Will respin it.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2014-10-27 11:47 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-25 10:14 [PATCH 0/3] genirq: Saving/restoring the irqchip state of an irq line Marc Zyngier
2014-10-25 10:14 ` Marc Zyngier
2014-10-25 10:14 ` [PATCH 1/3] genirq: Allow the irqchip state of an IRQ to be save/restored Marc Zyngier
2014-10-25 10:14 ` Marc Zyngier
2014-10-25 19:35 ` Thomas Gleixner
2014-10-25 19:35 ` Thomas Gleixner
2014-10-25 19:42 ` Thomas Gleixner
2014-10-25 19:42 ` Thomas Gleixner
2014-10-27 11:47 ` Marc Zyngier [this message]
2014-10-27 11:47 ` Marc Zyngier
2014-11-19 19:10 ` Bjorn Andersson
2014-11-19 19:10 ` Bjorn Andersson
2014-10-29 10:12 ` Linus Walleij
2014-10-29 10:12 ` Linus Walleij
2014-10-29 11:17 ` Marc Zyngier
2014-10-29 11:17 ` Marc Zyngier
2014-10-31 9:57 ` Linus Walleij
2014-10-31 9:57 ` Linus Walleij
2014-10-25 10:14 ` [PATCH 2/3] irqchip: GIC: Add support for irq_{get, set}_irqchip_state Marc Zyngier
2014-10-25 10:14 ` [PATCH 2/3] irqchip: GIC: Add support for irq_{get,set}_irqchip_state Marc Zyngier
2014-10-25 10:14 ` [PATCH 2/3] irqchip: GIC: Add support for irq_{get, set}_irqchip_state Marc Zyngier
2014-10-29 10:14 ` [PATCH 2/3] irqchip: GIC: Add support for irq_{get,set}_irqchip_state Linus Walleij
2014-10-29 10:14 ` [PATCH 2/3] irqchip: GIC: Add support for irq_{get, set}_irqchip_state Linus Walleij
2014-10-29 10:22 ` [PATCH 2/3] irqchip: GIC: Add support for irq_{get,set}_irqchip_state Marc Zyngier
2014-10-29 10:22 ` [PATCH 2/3] irqchip: GIC: Add support for irq_{get, set}_irqchip_state Marc Zyngier
2014-10-25 10:14 ` [PATCH 3/3] irqchip: GICv3: " Marc Zyngier
2014-10-25 10:14 ` [PATCH 3/3] irqchip: GICv3: Add support for irq_{get,set}_irqchip_state Marc Zyngier
2014-10-25 10:14 ` [PATCH 3/3] irqchip: GICv3: Add support for irq_{get, set}_irqchip_state Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544E30B6.7060902@arm.com \
--to=marc.zyngier@arm.com \
--cc=adharmap@codeaurora.org \
--cc=arnd@arndb.de \
--cc=bjorn@kryo.se \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pvo@apm.com \
--cc=tglx@linutronix.de \
--cc=tnhuynh@apm.com \
--cc=toanle@apm.com \
--cc=yvo@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.