From: Roger Quadros <rogerq@ti.com>
To: Frans Klaver <frans.klaver@xsens.com>,
Brian Norris <computersforpeace@gmail.com>
Cc: linux-omap@vger.kernel.org, linux-mtd@lists.infradead.org,
"Ezequiel García" <ezequiel@vanguardiasur.com.ar>
Subject: Re: [PATCH typo-resend] mtd: omap: fix mtd devices not showing up
Date: Mon, 27 Oct 2014 15:56:41 +0200 [thread overview]
Message-ID: <544E4F19.8060205@ti.com> (raw)
In-Reply-To: <1414416749-19598-1-git-send-email-frans.klaver@xsens.com>
Hi Frans,
On 10/27/2014 03:32 PM, Frans Klaver wrote:
> Since commit 6d178ef2fd5e ("mtd: nand: Move ELM driver and rename as
> omap_elm"), I don't have any mtd devices present on my am335x. This
> appears to be related to the link order of the omap_elm and omap2
> objects. Fix it by swapping the two in the Makefile.
Alternatively we could fix either elm_config() or omap_nand_probe() to
return -EPROBE_DEFER in case the device is present but driver not yet probed.
cheers,
-roger
>
> Signed-off-by: Frans Klaver <frans.klaver@xsens.com>
> ---
> I hoped this wouldn't make a difference, but it very much did. I don't
> have a proper explanation for why this actually fixes it for me though.
>
> Resend due to misspelling in ...infradead.org
>
> drivers/mtd/nand/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/Makefile b/drivers/mtd/nand/Makefile
> index 9c847e4..24b81ec 100644
> --- a/drivers/mtd/nand/Makefile
> +++ b/drivers/mtd/nand/Makefile
> @@ -26,8 +26,8 @@ obj-$(CONFIG_MTD_NAND_CS553X) += cs553x_nand.o
> obj-$(CONFIG_MTD_NAND_NDFC) += ndfc.o
> obj-$(CONFIG_MTD_NAND_ATMEL) += atmel_nand.o
> obj-$(CONFIG_MTD_NAND_GPIO) += gpio.o
> -obj-$(CONFIG_MTD_NAND_OMAP2) += omap2.o
> obj-$(CONFIG_MTD_NAND_OMAP_BCH_BUILD) += omap_elm.o
> +obj-$(CONFIG_MTD_NAND_OMAP2) += omap2.o
> obj-$(CONFIG_MTD_NAND_CM_X270) += cmx270_nand.o
> obj-$(CONFIG_MTD_NAND_PXA3xx) += pxa3xx_nand.o
> obj-$(CONFIG_MTD_NAND_TMIO) += tmio_nand.o
>
WARNING: multiple messages have this Message-ID (diff)
From: Roger Quadros <rogerq@ti.com>
To: Frans Klaver <frans.klaver@xsens.com>,
Brian Norris <computersforpeace@gmail.com>
Cc: "Ezequiel García" <ezequiel@vanguardiasur.com.ar>,
linux-mtd@lists.infradead.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH typo-resend] mtd: omap: fix mtd devices not showing up
Date: Mon, 27 Oct 2014 15:56:41 +0200 [thread overview]
Message-ID: <544E4F19.8060205@ti.com> (raw)
In-Reply-To: <1414416749-19598-1-git-send-email-frans.klaver@xsens.com>
Hi Frans,
On 10/27/2014 03:32 PM, Frans Klaver wrote:
> Since commit 6d178ef2fd5e ("mtd: nand: Move ELM driver and rename as
> omap_elm"), I don't have any mtd devices present on my am335x. This
> appears to be related to the link order of the omap_elm and omap2
> objects. Fix it by swapping the two in the Makefile.
Alternatively we could fix either elm_config() or omap_nand_probe() to
return -EPROBE_DEFER in case the device is present but driver not yet probed.
cheers,
-roger
>
> Signed-off-by: Frans Klaver <frans.klaver@xsens.com>
> ---
> I hoped this wouldn't make a difference, but it very much did. I don't
> have a proper explanation for why this actually fixes it for me though.
>
> Resend due to misspelling in ...infradead.org
>
> drivers/mtd/nand/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/Makefile b/drivers/mtd/nand/Makefile
> index 9c847e4..24b81ec 100644
> --- a/drivers/mtd/nand/Makefile
> +++ b/drivers/mtd/nand/Makefile
> @@ -26,8 +26,8 @@ obj-$(CONFIG_MTD_NAND_CS553X) += cs553x_nand.o
> obj-$(CONFIG_MTD_NAND_NDFC) += ndfc.o
> obj-$(CONFIG_MTD_NAND_ATMEL) += atmel_nand.o
> obj-$(CONFIG_MTD_NAND_GPIO) += gpio.o
> -obj-$(CONFIG_MTD_NAND_OMAP2) += omap2.o
> obj-$(CONFIG_MTD_NAND_OMAP_BCH_BUILD) += omap_elm.o
> +obj-$(CONFIG_MTD_NAND_OMAP2) += omap2.o
> obj-$(CONFIG_MTD_NAND_CM_X270) += cmx270_nand.o
> obj-$(CONFIG_MTD_NAND_PXA3xx) += pxa3xx_nand.o
> obj-$(CONFIG_MTD_NAND_TMIO) += tmio_nand.o
>
next prev parent reply other threads:[~2014-10-27 13:57 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-27 13:32 [PATCH typo-resend] mtd: omap: fix mtd devices not showing up Frans Klaver
2014-10-27 13:32 ` Frans Klaver
2014-10-27 13:56 ` Roger Quadros [this message]
2014-10-27 13:56 ` Roger Quadros
2014-10-27 14:01 ` Frans Klaver
2014-10-27 14:01 ` Frans Klaver
2014-10-27 19:27 ` Ezequiel Garcia
2014-10-27 19:27 ` Ezequiel Garcia
2014-10-28 8:57 ` Frans Klaver
2014-10-28 8:57 ` Frans Klaver
2014-10-28 8:58 ` Ezequiel Garcia
2014-10-28 8:58 ` Ezequiel Garcia
2014-10-27 14:34 ` [PATCH v2] " Frans Klaver
2014-10-27 14:34 ` Frans Klaver
2014-10-28 9:46 ` Roger Quadros
2014-10-28 9:46 ` Roger Quadros
2014-10-29 11:36 ` Frans Klaver
2014-10-29 11:36 ` Frans Klaver
2014-10-29 13:33 ` Roger Quadros
2014-10-29 13:33 ` Roger Quadros
2014-10-29 13:34 ` Ezequiel Garcia
2014-10-29 13:34 ` Ezequiel Garcia
2014-10-30 1:47 ` Brian Norris
2014-10-30 1:47 ` Brian Norris
2014-10-30 6:02 ` Frans Klaver
2014-10-30 6:02 ` Frans Klaver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544E4F19.8060205@ti.com \
--to=rogerq@ti.com \
--cc=computersforpeace@gmail.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=frans.klaver@xsens.com \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.