All of lore.kernel.org
 help / color / mirror / Atom feed
From: suravee.suthikulpanit@amd.com (Suravee Suthikulanit)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: amd-seattle: Adding device tree for AMD Seattle platform
Date: Mon, 27 Oct 2014 13:34:32 -0500	[thread overview]
Message-ID: <544E9038.5050004@amd.com> (raw)
In-Reply-To: <20141027135035.GA2629@leverpostej>

On 10/27/2014 8:50 AM, Mark Rutland wrote:
> Hi Suravee,
>
> [...]
>
>> +	chosen {
>> +		linux,stdout-path = "console=ttyAMA0,115200 earlycon=pl011,0xe1010000";
>
> The stdout-path property should just be a path to the UART node. It's
> not a direct replacement for /chosen/bootargs.
>
> This should be (assuming you fix up the label above):
>
> 	stdout-path = &serial0;
>
> That will give us earlycon if "earlycon" (with no arguments) is provided
> on the command line, and should set up that UART as the console. There's
> no need for the "linux," prefix now either.
>
> Unfortuantely, I believe that the UART rate will get changed when the
> real PL011 driver registers, unless the rate is explicitly provided on
> the command line. It might be worth looking into retaining the
> configured rate somehow indepentent of bootargs (unless overriden).

Thanks for the explanation. I think I should be able to get rid of the 
"console=ttyAMA0,115200 earlycon=pl011,0xe1010000" altogether. I'll send 
out V2 soon.

Thanks,

Suravee

> Thanks,
> Mark.
>

WARNING: multiple messages have this Message-ID (diff)
From: Suravee Suthikulanit <suravee.suthikulpanit@amd.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Will Deacon <Will.Deacon@arm.com>,
	Catalin Marinas <Catalin.Marinas@arm.com>,
	Marc Zyngier <Marc.Zyngier@arm.com>,
	Liviu Dudau <Liviu.Dudau@arm.com>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	"Thomas Lendacky" <Thomas.Lendacky@amd.com>,
	Joel Schopp <Joel.Schopp@amd.com>
Subject: Re: [PATCH] arm64: amd-seattle: Adding device tree for AMD Seattle platform
Date: Mon, 27 Oct 2014 13:34:32 -0500	[thread overview]
Message-ID: <544E9038.5050004@amd.com> (raw)
In-Reply-To: <20141027135035.GA2629@leverpostej>

On 10/27/2014 8:50 AM, Mark Rutland wrote:
> Hi Suravee,
>
> [...]
>
>> +	chosen {
>> +		linux,stdout-path = "console=ttyAMA0,115200 earlycon=pl011,0xe1010000";
>
> The stdout-path property should just be a path to the UART node. It's
> not a direct replacement for /chosen/bootargs.
>
> This should be (assuming you fix up the label above):
>
> 	stdout-path = &serial0;
>
> That will give us earlycon if "earlycon" (with no arguments) is provided
> on the command line, and should set up that UART as the console. There's
> no need for the "linux," prefix now either.
>
> Unfortuantely, I believe that the UART rate will get changed when the
> real PL011 driver registers, unless the rate is explicitly provided on
> the command line. It might be worth looking into retaining the
> configured rate somehow indepentent of bootargs (unless overriden).

Thanks for the explanation. I think I should be able to get rid of the 
"console=ttyAMA0,115200 earlycon=pl011,0xe1010000" altogether. I'll send 
out V2 soon.

Thanks,

Suravee

> Thanks,
> Mark.
>



  reply	other threads:[~2014-10-27 18:34 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-24 12:20 [PATCH] arm64: amd-seattle: Adding device tree for AMD Seattle platform suravee.suthikulpanit at amd.com
2014-10-24 12:20 ` suravee.suthikulpanit
2014-10-25 23:08 ` Alexander Graf
2014-10-25 23:08   ` Alexander Graf
2014-10-26 12:43   ` Andreas Färber
2014-10-26 12:43     ` Andreas Färber
2014-10-26 14:08     ` Alexander Graf
2014-10-26 14:08       ` Alexander Graf
2014-10-27 14:29       ` Suravee Suthikulanit
2014-10-27 14:29         ` Suravee Suthikulanit
2014-10-27 23:25         ` Alexander Graf
2014-10-27 23:25           ` Alexander Graf
2014-10-28 13:07           ` Suravee Suthikulanit
2014-10-28 13:07             ` Suravee Suthikulanit
2014-10-28 14:30             ` Alexander Graf
2014-10-28 14:30               ` Alexander Graf
2014-10-30 13:33             ` Liviu Dudau
2014-10-30 13:33               ` Liviu Dudau
2014-10-26 14:09 ` Andreas Färber
2014-10-26 14:09   ` Andreas Färber
2014-10-27 14:30   ` Suravee Suthikulanit
2014-10-27 14:30     ` Suravee Suthikulanit
2014-10-27 13:50 ` Mark Rutland
2014-10-27 13:50   ` Mark Rutland
2014-10-27 18:34   ` Suravee Suthikulanit [this message]
2014-10-27 18:34     ` Suravee Suthikulanit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=544E9038.5050004@amd.com \
    --to=suravee.suthikulpanit@amd.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.