From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 2/9] arm: perf: add missing pr_info newlines
Date: Mon, 27 Oct 2014 13:37:16 -0700 [thread overview]
Message-ID: <544EACFC.3090808@codeaurora.org> (raw)
In-Reply-To: <1414411599-1938-3-git-send-email-mark.rutland@arm.com>
On 10/27/2014 05:06 AM, Mark Rutland wrote:
> Most of the pr_info format strings in perf_event_cpu.c are missing
> newlines. Currently we get away with this as the format strings for
> subsequent calls to printk (including all pr_* calls) begin with a log
> prefix, and the printk core adds the omitted newline for this case.
> While generates the output we expect, we probably should not rely on the
> format of successive printk calls in order to get legible output.
>
> This patch adds the missing newlines to pr_info format strings in
> perf_event_cpu.c, making them consistent with the format strings for
> other pr_info, warn, and pr_err calls, and preventing potentially
> illegible output if the next printk/pr_* format string doesn't begin
> with a log prefix.
>
> Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2014-10-27 20:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-27 12:06 [PATCHv2 0/9] Prepatory rework for multi-PMU support Mark Rutland
2014-10-27 12:06 ` [PATCHv2 1/9] arm: perf: factor out callchain code Mark Rutland
2014-10-27 12:06 ` [PATCHv2 2/9] arm: perf: add missing pr_info newlines Mark Rutland
2014-10-27 20:37 ` Stephen Boyd [this message]
2014-10-27 12:06 ` [PATCHv2 3/9] arm: perf: make PMU probing data-driven Mark Rutland
2014-10-27 20:37 ` Stephen Boyd
2014-10-27 12:06 ` [PATCHv2 4/9] arm: perf: use IDR types for CPU PMUs Mark Rutland
2014-10-27 12:06 ` [PATCHv2 5/9] arm: perf: limit size of accounting data Mark Rutland
2014-10-27 21:13 ` Stephen Boyd
2014-10-27 12:06 ` [PATCHv2 6/9] arm: perf: kill get_hw_events() Mark Rutland
2014-10-27 20:37 ` Stephen Boyd
2014-10-27 12:06 ` [PATCHv2 7/9] arm: perf: fold percpu_pmu into pmu_hw_events Mark Rutland
2014-10-27 12:06 ` [PATCHv2 8/9] arm: perf: dynamically allocate cpu hardware data Mark Rutland
2014-10-27 20:37 ` Stephen Boyd
2014-10-27 12:06 ` [PATCHv2 9/9] arm: perf: fold hotplug notifier into arm_pmu Mark Rutland
2014-10-27 20:37 ` Stephen Boyd
2014-10-28 14:46 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544EACFC.3090808@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.