All of lore.kernel.org
 help / color / mirror / Atom feed
* [meta-networking][PATCH] ntp: make daemon run under ntp:ntp
@ 2014-10-28  3:27 Qi.Chen
  2014-10-28 10:46 ` Andreas Müller
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Qi.Chen @ 2014-10-28  3:27 UTC (permalink / raw)
  To: openembedded-devel

From: Chen Qi <Qi.Chen@windriver.com>

Fix the service so that the ntpd daemon is run under ntp:ntp.

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
---
 meta-networking/recipes-support/ntp/ntp/ntpd.service | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-networking/recipes-support/ntp/ntp/ntpd.service b/meta-networking/recipes-support/ntp/ntp/ntpd.service
index b7c4268..0e3d7cd 100644
--- a/meta-networking/recipes-support/ntp/ntp/ntpd.service
+++ b/meta-networking/recipes-support/ntp/ntp/ntpd.service
@@ -5,7 +5,7 @@ After=network.target
 [Service]
 Type=forking
 PIDFile=/run/ntpd.pid
-ExecStart=/usr/sbin/ntpd -p /run/ntpd.pid -g
+ExecStart=/usr/sbin/ntpd -u ntp:ntp -p /run/ntpd.pid -g
 
 [Install]
 WantedBy=multi-user.target
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [meta-networking][PATCH] ntp: make daemon run under ntp:ntp
  2014-10-28  3:27 [meta-networking][PATCH] ntp: make daemon run under ntp:ntp Qi.Chen
@ 2014-10-28 10:46 ` Andreas Müller
  2014-10-28 11:17   ` Peter A. Bigot
  2014-10-28 11:23 ` Koen Kooi
  2014-11-04 20:10 ` Joe MacDonald
  2 siblings, 1 reply; 6+ messages in thread
From: Andreas Müller @ 2014-10-28 10:46 UTC (permalink / raw)
  To: openembedded-devel@lists.openembedded.org

On Tue, Oct 28, 2014 at 4:27 AM,  <Qi.Chen@windriver.com> wrote:
> From: Chen Qi <Qi.Chen@windriver.com>
>
> Fix the service so that the ntpd daemon is run under ntp:ntp.
What does this fix?

Andreas


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [meta-networking][PATCH] ntp: make daemon run under ntp:ntp
  2014-10-28 10:46 ` Andreas Müller
@ 2014-10-28 11:17   ` Peter A. Bigot
  0 siblings, 0 replies; 6+ messages in thread
From: Peter A. Bigot @ 2014-10-28 11:17 UTC (permalink / raw)
  To: openembedded-devel

On 10/28/2014 05:46 AM, Andreas Müller wrote:
> On Tue, Oct 28, 2014 at 4:27 AM,  <Qi.Chen@windriver.com> wrote:
>> From: Chen Qi <Qi.Chen@windriver.com>
>>
>> Fix the service so that the ntpd daemon is run under ntp:ntp.
> What does this fix?

Primarily, I suspect, it makes systemd consistent with the existing init 
script.

It also provides a reason for the previous patches that moved the 
driftfile out of /etc to a location that user ntp can write, which was 
done earlier.

Acked-by: Peter A. Bigot <pab@pabigot.com>

Peter


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [meta-networking][PATCH] ntp: make daemon run under ntp:ntp
  2014-10-28  3:27 [meta-networking][PATCH] ntp: make daemon run under ntp:ntp Qi.Chen
  2014-10-28 10:46 ` Andreas Müller
@ 2014-10-28 11:23 ` Koen Kooi
  2014-10-28 11:28   ` Peter A. Bigot
  2014-11-04 20:10 ` Joe MacDonald
  2 siblings, 1 reply; 6+ messages in thread
From: Koen Kooi @ 2014-10-28 11:23 UTC (permalink / raw)
  To: openembedded-devel

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Qi.Chen@windriver.com schreef op 28-10-14 04:27:
> From: Chen Qi <Qi.Chen@windriver.com>
> 
> Fix the service so that the ntpd daemon is run under ntp:ntp.
> 
> Signed-off-by: Chen Qi <Qi.Chen@windriver.com> --- 
> meta-networking/recipes-support/ntp/ntp/ntpd.service | 2 +- 1 file
> changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-networking/recipes-support/ntp/ntp/ntpd.service
> b/meta-networking/recipes-support/ntp/ntp/ntpd.service index
> b7c4268..0e3d7cd 100644 ---
> a/meta-networking/recipes-support/ntp/ntp/ntpd.service +++
> b/meta-networking/recipes-support/ntp/ntp/ntpd.service @@ -5,7 +5,7 @@
> After=network.target [Service] Type=forking PIDFile=/run/ntpd.pid 
> -ExecStart=/usr/sbin/ntpd -p /run/ntpd.pid -g +ExecStart=/usr/sbin/ntpd
> -u ntp:ntp -p /run/ntpd.pid -g

Wouldn't User=ntp be a better approach, or does ntp need more priviliges
during startup before dropping then and su'ing?

regards,

Koen

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
Comment: GPGTools - http://gpgtools.org

iD8DBQFUT3y2MkyGM64RGpERAtEyAKC8qvQHY46gq2orocsyv1XW2pfedgCeJ1zt
B/CVWPNqMCM4wBVm5oTviog=
=3fjp
-----END PGP SIGNATURE-----



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [meta-networking][PATCH] ntp: make daemon run under ntp:ntp
  2014-10-28 11:23 ` Koen Kooi
@ 2014-10-28 11:28   ` Peter A. Bigot
  0 siblings, 0 replies; 6+ messages in thread
From: Peter A. Bigot @ 2014-10-28 11:28 UTC (permalink / raw)
  To: openembedded-devel

On 10/28/2014 06:23 AM, Koen Kooi wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Qi.Chen@windriver.com schreef op 28-10-14 04:27:
>> From: Chen Qi <Qi.Chen@windriver.com>
>>
>> Fix the service so that the ntpd daemon is run under ntp:ntp.
>>
>> Signed-off-by: Chen Qi <Qi.Chen@windriver.com> ---
>> meta-networking/recipes-support/ntp/ntp/ntpd.service | 2 +- 1 file
>> changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta-networking/recipes-support/ntp/ntp/ntpd.service
>> b/meta-networking/recipes-support/ntp/ntp/ntpd.service index
>> b7c4268..0e3d7cd 100644 ---
>> a/meta-networking/recipes-support/ntp/ntp/ntpd.service +++
>> b/meta-networking/recipes-support/ntp/ntp/ntpd.service @@ -5,7 +5,7 @@
>> After=network.target [Service] Type=forking PIDFile=/run/ntpd.pid
>> -ExecStart=/usr/sbin/ntpd -p /run/ntpd.pid -g +ExecStart=/usr/sbin/ntpd
>> -u ntp:ntp -p /run/ntpd.pid -g
> Wouldn't User=ntp be a better approach, or does ntp need more priviliges
> during startup before dropping then and su'ing?

If kernel PPS is enabled (which it is by default), ntp does need 
additional privileges during startup.

Peter


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [meta-networking][PATCH] ntp: make daemon run under ntp:ntp
  2014-10-28  3:27 [meta-networking][PATCH] ntp: make daemon run under ntp:ntp Qi.Chen
  2014-10-28 10:46 ` Andreas Müller
  2014-10-28 11:23 ` Koen Kooi
@ 2014-11-04 20:10 ` Joe MacDonald
  2 siblings, 0 replies; 6+ messages in thread
From: Joe MacDonald @ 2014-11-04 20:10 UTC (permalink / raw)
  To: openembedded-devel

[-- Attachment #1: Type: text/plain, Size: 1020 bytes --]

Merged, thanks.
-J.

[[oe] [meta-networking][PATCH] ntp: make daemon run under ntp:ntp] On 14.10.28 (Tue 11:27) Qi.Chen@windriver.com wrote:

> From: Chen Qi <Qi.Chen@windriver.com>
> 
> Fix the service so that the ntpd daemon is run under ntp:ntp.
> 
> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> ---
>  meta-networking/recipes-support/ntp/ntp/ntpd.service | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-networking/recipes-support/ntp/ntp/ntpd.service b/meta-networking/recipes-support/ntp/ntp/ntpd.service
> index b7c4268..0e3d7cd 100644
> --- a/meta-networking/recipes-support/ntp/ntp/ntpd.service
> +++ b/meta-networking/recipes-support/ntp/ntp/ntpd.service
> @@ -5,7 +5,7 @@ After=network.target
>  [Service]
>  Type=forking
>  PIDFile=/run/ntpd.pid
> -ExecStart=/usr/sbin/ntpd -p /run/ntpd.pid -g
> +ExecStart=/usr/sbin/ntpd -u ntp:ntp -p /run/ntpd.pid -g
>  
>  [Install]
>  WantedBy=multi-user.target
> -- 
> 1.9.1
> 
-- 
-Joe MacDonald.
:wq

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 501 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2014-11-04 20:10 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-28  3:27 [meta-networking][PATCH] ntp: make daemon run under ntp:ntp Qi.Chen
2014-10-28 10:46 ` Andreas Müller
2014-10-28 11:17   ` Peter A. Bigot
2014-10-28 11:23 ` Koen Kooi
2014-10-28 11:28   ` Peter A. Bigot
2014-11-04 20:10 ` Joe MacDonald

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.