From: Prarit Bhargava <prarit@redhat.com>
To: Andi Kleen <ak@linux.intel.com>
Cc: Jonathan Corbet <corbet@lwn.net>,
kexec@lists.infradead.org, jason.wessel@windriver.com,
Rusty Russell <rusty@rustcorp.com.au>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
Fabian Frederick <fabf@skynet.be>,
isimatu.yasuaki@jp.fujitsu.com, "H. Peter Anvin" <hpa@zytor.com>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-api@vger.kernel.org, Vivek Goyal <vgoyal@redhat.com>
Subject: Re: [PATCH V4] kernel, add bug_on_warn
Date: Tue, 28 Oct 2014 08:48:49 -0400 [thread overview]
Message-ID: <544F90B1.1070102@redhat.com> (raw)
In-Reply-To: <20141028124425.GD3274@tassilo.jf.intel.com>
On 10/28/2014 08:44 AM, Andi Kleen wrote:
>>> I suppose ... but that would mean I would have to explain to an end user the
>>> elaborate process of enabling kdb, inserting a break point, etc. The whole
>>> purpose of this is to let an end user panic on WARN() easily.
>>>
>>> Asking an end user to enable kdb is magnitudes worse than asking them to
>>> recompile a kernel.
>>
>> Agreed. Asking a customer to setup and run kdb and put breakpoints is much
>> more pain than simply asking to reboot kernel with a command line option.
>
> If you have a command line option to execute kdb commands you still
> would only have a command line option, just a slightly longer one.
>
> kdb="on, bp warn_slowpath_common sr c, go"
KDB is not on all kernels. This would require me to go to great lengths to
explain to a user how to set it up, etc., rather than saying "Hi, please add
panic_on_warn as a kernel parameter/echo 1 into /proc/sys/kernel/panic_on_warn
and on the next time you see that WARN() the system will panic and kdump. Send
me that kdump."
>
> But it would be a generic facility instead of a special purpose hack.
Generic to KDB be configured on and it is in no way trivial to use.
P.
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
WARNING: multiple messages have this Message-ID (diff)
From: Prarit Bhargava <prarit-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Andi Kleen <ak-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
Cc: Jonathan Corbet <corbet-T1hC0tSOHrs@public.gmane.org>,
kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
jason.wessel-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org,
Rusty Russell <rusty-8n+1lVoiYb80n/F98K4Iww@public.gmane.org>,
linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Fabian Frederick <fabf-AgBVmzD5pcezQB+pC5nmwQ@public.gmane.org>,
isimatu.yasuaki-+CUm20s59erQFUHtdCDX3A@public.gmane.org,
"H. Peter Anvin" <hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>,
Masami Hiramatsu
<masami.hiramatsu.pt-FCd8Q96Dh0JBDgjK7y7TUQ@public.gmane.org>,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Vivek Goyal <vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH V4] kernel, add bug_on_warn
Date: Tue, 28 Oct 2014 08:48:49 -0400 [thread overview]
Message-ID: <544F90B1.1070102@redhat.com> (raw)
In-Reply-To: <20141028124425.GD3274-KWJ+5VKanrL29G5dvP0v1laTQe2KTcn/@public.gmane.org>
On 10/28/2014 08:44 AM, Andi Kleen wrote:
>>> I suppose ... but that would mean I would have to explain to an end user the
>>> elaborate process of enabling kdb, inserting a break point, etc. The whole
>>> purpose of this is to let an end user panic on WARN() easily.
>>>
>>> Asking an end user to enable kdb is magnitudes worse than asking them to
>>> recompile a kernel.
>>
>> Agreed. Asking a customer to setup and run kdb and put breakpoints is much
>> more pain than simply asking to reboot kernel with a command line option.
>
> If you have a command line option to execute kdb commands you still
> would only have a command line option, just a slightly longer one.
>
> kdb="on, bp warn_slowpath_common sr c, go"
KDB is not on all kernels. This would require me to go to great lengths to
explain to a user how to set it up, etc., rather than saying "Hi, please add
panic_on_warn as a kernel parameter/echo 1 into /proc/sys/kernel/panic_on_warn
and on the next time you see that WARN() the system will panic and kdump. Send
me that kdump."
>
> But it would be a generic facility instead of a special purpose hack.
Generic to KDB be configured on and it is in no way trivial to use.
P.
WARNING: multiple messages have this Message-ID (diff)
From: Prarit Bhargava <prarit@redhat.com>
To: Andi Kleen <ak@linux.intel.com>
Cc: Vivek Goyal <vgoyal@redhat.com>,
linux-kernel@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
Andrew Morton <akpm@linux-foundation.org>,
Rusty Russell <rusty@rustcorp.com.au>,
"H. Peter Anvin" <hpa@zytor.com>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
Fabian Frederick <fabf@skynet.be>,
isimatu.yasuaki@jp.fujitsu.com, linux-doc@vger.kernel.org,
kexec@lists.infradead.org, linux-api@vger.kernel.org,
jason.wessel@windriver.com
Subject: Re: [PATCH V4] kernel, add bug_on_warn
Date: Tue, 28 Oct 2014 08:48:49 -0400 [thread overview]
Message-ID: <544F90B1.1070102@redhat.com> (raw)
In-Reply-To: <20141028124425.GD3274@tassilo.jf.intel.com>
On 10/28/2014 08:44 AM, Andi Kleen wrote:
>>> I suppose ... but that would mean I would have to explain to an end user the
>>> elaborate process of enabling kdb, inserting a break point, etc. The whole
>>> purpose of this is to let an end user panic on WARN() easily.
>>>
>>> Asking an end user to enable kdb is magnitudes worse than asking them to
>>> recompile a kernel.
>>
>> Agreed. Asking a customer to setup and run kdb and put breakpoints is much
>> more pain than simply asking to reboot kernel with a command line option.
>
> If you have a command line option to execute kdb commands you still
> would only have a command line option, just a slightly longer one.
>
> kdb="on, bp warn_slowpath_common sr c, go"
KDB is not on all kernels. This would require me to go to great lengths to
explain to a user how to set it up, etc., rather than saying "Hi, please add
panic_on_warn as a kernel parameter/echo 1 into /proc/sys/kernel/panic_on_warn
and on the next time you see that WARN() the system will panic and kdump. Send
me that kdump."
>
> But it would be a generic facility instead of a special purpose hack.
Generic to KDB be configured on and it is in no way trivial to use.
P.
next prev parent reply other threads:[~2014-10-28 12:49 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-24 12:53 [PATCH V4] kernel, add bug_on_warn Prarit Bhargava
2014-10-24 12:53 ` Prarit Bhargava
2014-10-27 18:05 ` Jason Baron
2014-10-27 18:05 ` Jason Baron
2014-10-27 18:05 ` Jason Baron
2014-10-27 18:15 ` Prarit Bhargava
2014-10-27 18:15 ` Prarit Bhargava
2014-10-27 18:15 ` Prarit Bhargava
2014-10-28 2:32 ` Dave Young
2014-10-28 2:32 ` Dave Young
2014-10-28 5:41 ` Masami Hiramatsu
2014-10-28 5:41 ` Masami Hiramatsu
2014-10-28 0:00 ` Yasuaki Ishimatsu
2014-10-28 0:00 ` Yasuaki Ishimatsu
2014-10-28 0:00 ` Yasuaki Ishimatsu
2014-10-28 12:16 ` Andi Kleen
2014-10-28 12:16 ` Andi Kleen
2014-10-28 12:22 ` Prarit Bhargava
2014-10-28 12:22 ` Prarit Bhargava
2014-10-28 12:22 ` Prarit Bhargava
2014-10-28 12:29 ` Vivek Goyal
2014-10-28 12:29 ` Vivek Goyal
2014-10-28 12:44 ` Andi Kleen
2014-10-28 12:44 ` Andi Kleen
2014-10-28 12:48 ` Prarit Bhargava [this message]
2014-10-28 12:48 ` Prarit Bhargava
2014-10-28 12:48 ` Prarit Bhargava
2014-10-28 12:56 ` Andi Kleen
2014-10-28 12:56 ` Andi Kleen
2014-10-28 12:56 ` Andi Kleen
2014-10-28 13:19 ` Prarit Bhargava
2014-10-28 13:19 ` Prarit Bhargava
2014-10-28 13:19 ` Prarit Bhargava
2014-10-28 12:55 ` Vivek Goyal
2014-10-28 12:55 ` Vivek Goyal
2014-10-28 12:59 ` Andi Kleen
2014-10-28 12:59 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544F90B1.1070102@redhat.com \
--to=prarit@redhat.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=fabf@skynet.be \
--cc=hpa@zytor.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=jason.wessel@windriver.com \
--cc=kexec@lists.infradead.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=rusty@rustcorp.com.au \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.