From: Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>
To: Lokesh Vutla <lokeshvutla-l0cyMroinI0@public.gmane.org>,
rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: johan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org,
balbi-l0cyMroinI0@public.gmane.org,
akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
nsekhar-l0cyMroinI0@public.gmane.org,
t-kristo-l0cyMroinI0@public.gmane.org,
j-keerthy-l0cyMroinI0@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH V4 3/3] rtc: omap: Support regulator supply for RTC
Date: Tue, 28 Oct 2014 09:02:45 -0500 [thread overview]
Message-ID: <544FA205.3000102@ti.com> (raw)
In-Reply-To: <1414490332-14856-4-git-send-email-lokeshvutla-l0cyMroinI0@public.gmane.org>
On 10/28/2014 04:58 AM, Lokesh Vutla wrote:
> Certain SoCs such as DRA7, RTC is an independent voltage domain of it's own
> and on platforms such as DRA7-evm, this may be supplied by individual
> regulator on it's own.
> So make the OMAP RTC driver support a power regulator.
>
> Signed-off-by: Lokesh Vutla <lokeshvutla-l0cyMroinI0@public.gmane.org>
> ---
> - Dropped the Reviewed-by tags as this patch is changed from previous version.
> Documentation/devicetree/bindings/rtc/rtc-omap.txt | 6 ++++
> drivers/rtc/rtc-omap.c | 41 +++++++++++++++++++++-
> 2 files changed, 46 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/rtc/rtc-omap.txt b/Documentation/devicetree/bindings/rtc/rtc-omap.txt
> index 750efd4..c1d84ac 100644
> --- a/Documentation/devicetree/bindings/rtc/rtc-omap.txt
> +++ b/Documentation/devicetree/bindings/rtc/rtc-omap.txt
> @@ -15,6 +15,9 @@ Required properties:
> Optional properties:
> - ti,system-power-controller: whether the rtc is controlling the system power
> through pmic_power_en
> +- vrtc-supply: phandle to the regulator device tree node.
> +- vrtc-minuV: Minimum required voltage in uV, If default voltage needs to be changed
> +- vrtc-maxuV: Maximum acceptable voltage in uV, If default voltage needs to be changed
>
> Example:
>
> @@ -25,4 +28,7 @@ rtc@1c23000 {
> 19>;
> interrupt-parent = <&intc>;
> ti,system-power-controller;
> + vrtc-supply = <&ldo9_reg>;
> + vrtc-minuV = <1050000>;
> + vrtc-maxuV = <1050000>;
why would we want to duplicate machine constraints that regulators
already have? if there is a constant voltage needed, then it should be
compatible property as it is not really a configuration option, right?
[...]
--
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: nm@ti.com (Nishanth Menon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V4 3/3] rtc: omap: Support regulator supply for RTC
Date: Tue, 28 Oct 2014 09:02:45 -0500 [thread overview]
Message-ID: <544FA205.3000102@ti.com> (raw)
In-Reply-To: <1414490332-14856-4-git-send-email-lokeshvutla@ti.com>
On 10/28/2014 04:58 AM, Lokesh Vutla wrote:
> Certain SoCs such as DRA7, RTC is an independent voltage domain of it's own
> and on platforms such as DRA7-evm, this may be supplied by individual
> regulator on it's own.
> So make the OMAP RTC driver support a power regulator.
>
> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
> ---
> - Dropped the Reviewed-by tags as this patch is changed from previous version.
> Documentation/devicetree/bindings/rtc/rtc-omap.txt | 6 ++++
> drivers/rtc/rtc-omap.c | 41 +++++++++++++++++++++-
> 2 files changed, 46 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/rtc/rtc-omap.txt b/Documentation/devicetree/bindings/rtc/rtc-omap.txt
> index 750efd4..c1d84ac 100644
> --- a/Documentation/devicetree/bindings/rtc/rtc-omap.txt
> +++ b/Documentation/devicetree/bindings/rtc/rtc-omap.txt
> @@ -15,6 +15,9 @@ Required properties:
> Optional properties:
> - ti,system-power-controller: whether the rtc is controlling the system power
> through pmic_power_en
> +- vrtc-supply: phandle to the regulator device tree node.
> +- vrtc-minuV: Minimum required voltage in uV, If default voltage needs to be changed
> +- vrtc-maxuV: Maximum acceptable voltage in uV, If default voltage needs to be changed
>
> Example:
>
> @@ -25,4 +28,7 @@ rtc at 1c23000 {
> 19>;
> interrupt-parent = <&intc>;
> ti,system-power-controller;
> + vrtc-supply = <&ldo9_reg>;
> + vrtc-minuV = <1050000>;
> + vrtc-maxuV = <1050000>;
why would we want to duplicate machine constraints that regulators
already have? if there is a constant voltage needed, then it should be
compatible property as it is not really a configuration option, right?
[...]
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2014-10-28 14:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-28 9:58 [PATCH V4 0/3] rtc: omap: Add support for regulator supply Lokesh Vutla
2014-10-28 9:58 ` Lokesh Vutla
2014-10-28 9:58 ` [PATCH V4 1/3] rtc: omap: use module_platform_driver Lokesh Vutla
2014-10-28 9:58 ` Lokesh Vutla
2014-10-28 9:58 ` [PATCH V4 2/3] rtc: omap: Update Kconfig for OMAP RTC Lokesh Vutla
2014-10-28 9:58 ` Lokesh Vutla
2014-10-28 9:58 ` [PATCH V4 3/3] rtc: omap: Support regulator supply for RTC Lokesh Vutla
2014-10-28 9:58 ` Lokesh Vutla
[not found] ` <1414490332-14856-4-git-send-email-lokeshvutla-l0cyMroinI0@public.gmane.org>
2014-10-28 14:02 ` Nishanth Menon [this message]
2014-10-28 14:02 ` Nishanth Menon
2014-10-28 15:01 ` Felipe Balbi
2014-10-28 15:01 ` Felipe Balbi
2014-10-28 15:11 ` Mark Brown
2014-10-28 15:11 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2014-10-24 4:53 [PATCH V3 " Lokesh Vutla
2014-10-24 8:07 ` [PATCH V4 " Lokesh Vutla
2014-10-24 8:07 ` Lokesh Vutla
2014-10-24 15:40 ` Felipe Balbi
2014-10-24 15:40 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544FA205.3000102@ti.com \
--to=nm-l0cymroini0@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=balbi-l0cyMroinI0@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=j-keerthy-l0cyMroinI0@public.gmane.org \
--cc=johan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lokeshvutla-l0cyMroinI0@public.gmane.org \
--cc=nsekhar-l0cyMroinI0@public.gmane.org \
--cc=rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
--cc=t-kristo-l0cyMroinI0@public.gmane.org \
--cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.