From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pinctrl: at91: fix compilation
Date: Tue, 28 Oct 2014 22:10:19 +0300 [thread overview]
Message-ID: <544FEA1B.2050006@cogentembedded.com> (raw)
In-Reply-To: <1414522686-5755-1-git-send-email-alexandre.belloni@free-electrons.com>
Hello.
On 10/28/2014 09:58 PM, Alexandre Belloni wrote:
> Add macros introduced by 4334ac2db2be9e278c95fd15260c1f49f698ffc5 that
Please also specify that commit's summary line in parens.
> were missed when copying the header.
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> drivers/pinctrl/pinctrl-at91.h | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/pinctrl/pinctrl-at91.h b/drivers/pinctrl/pinctrl-at91.h
> index c837c66ea360..79b957f1dfa2 100644
> --- a/drivers/pinctrl/pinctrl-at91.h
> +++ b/drivers/pinctrl/pinctrl-at91.h
> @@ -63,4 +63,10 @@
> #define PIO_FRLHSR 0xd8 /* Fall/Rise - Low/High Status Register */
> #define PIO_SCHMITT 0x100 /* Schmitt Trigger Register */
>
> +#define SAMA5D3_PIO_DRIVER1 0x118 /*PIO Driver 1 register offset*/
> +#define SAMA5D3_PIO_DRIVER2 0x11C /*PIO Driver 2 register offset*/
> +
> +#define AT91SAM9X5_PIO_DRIVER1 0x114 /*PIO Driver 1 register offset*/
> +#define AT91SAM9X5_PIO_DRIVER2 0x118 /*PIO Driver 2 register offset*/
Please add spaces after /* and before */.
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Linus Walleij <linus.walleij@linaro.org>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
linux-kernel@vger.kernel.org,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] pinctrl: at91: fix compilation
Date: Tue, 28 Oct 2014 22:10:19 +0300 [thread overview]
Message-ID: <544FEA1B.2050006@cogentembedded.com> (raw)
In-Reply-To: <1414522686-5755-1-git-send-email-alexandre.belloni@free-electrons.com>
Hello.
On 10/28/2014 09:58 PM, Alexandre Belloni wrote:
> Add macros introduced by 4334ac2db2be9e278c95fd15260c1f49f698ffc5 that
Please also specify that commit's summary line in parens.
> were missed when copying the header.
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> drivers/pinctrl/pinctrl-at91.h | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/pinctrl/pinctrl-at91.h b/drivers/pinctrl/pinctrl-at91.h
> index c837c66ea360..79b957f1dfa2 100644
> --- a/drivers/pinctrl/pinctrl-at91.h
> +++ b/drivers/pinctrl/pinctrl-at91.h
> @@ -63,4 +63,10 @@
> #define PIO_FRLHSR 0xd8 /* Fall/Rise - Low/High Status Register */
> #define PIO_SCHMITT 0x100 /* Schmitt Trigger Register */
>
> +#define SAMA5D3_PIO_DRIVER1 0x118 /*PIO Driver 1 register offset*/
> +#define SAMA5D3_PIO_DRIVER2 0x11C /*PIO Driver 2 register offset*/
> +
> +#define AT91SAM9X5_PIO_DRIVER1 0x114 /*PIO Driver 1 register offset*/
> +#define AT91SAM9X5_PIO_DRIVER2 0x118 /*PIO Driver 2 register offset*/
Please add spaces after /* and before */.
WBR, Sergei
next prev parent reply other threads:[~2014-10-28 19:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-28 18:58 [PATCH] pinctrl: at91: fix compilation Alexandre Belloni
2014-10-28 18:58 ` Alexandre Belloni
2014-10-28 19:10 ` Sergei Shtylyov [this message]
2014-10-28 19:10 ` Sergei Shtylyov
2014-10-29 8:30 ` Linus Walleij
2014-10-29 8:30 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544FEA1B.2050006@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.