From: Roger Quadros <rogerq@ti.com>
To: Frans Klaver <fransklaver@gmail.com>,
Rostislav Lisovy <lisovy@gmail.com>
Cc: Rostislav Lisovy <lisovy@merica.cz>,
Tony Lindgren <tony@atomide.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-mtd@lists.infradead.org, michal.vokac@comap.cz,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
sojkam1@fel.cvut.cz
Subject: Re: [PATCH v3 2/2] mtd: nand: omap: Synchronize the access to the ECC engine
Date: Wed, 29 Oct 2014 11:37:09 +0200 [thread overview]
Message-ID: <5450B545.1050905@ti.com> (raw)
In-Reply-To: <CAH6sp9M0VaH8-4NXcRNUYQS8Zuzbkra6zmgjSebjv8Awj6i0og@mail.gmail.com>
Hi Rostislav,
Sorry to miss this one.
On 10/29/2014 11:24 AM, Frans Klaver wrote:
> On Thu, Oct 2, 2014 at 4:16 PM, Rostislav Lisovy <lisovy@gmail.com> wrote:
>>
>> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
>> index f0dcdb6..dfae46f 100644
>> --- a/drivers/mtd/nand/omap2.c
>> +++ b/drivers/mtd/nand/omap2.c
>> @@ -144,8 +144,13 @@ static u_char bch8_vector[] = {0xf3, 0xdb, 0x14, 0x16, 0x8b, 0xd2, 0xbe, 0xcc,
>> 0xac, 0x6b, 0xff, 0x99, 0x7b};
>> static u_char bch4_vector[] = {0x00, 0x6b, 0x31, 0xdd, 0x41, 0xbc, 0x10};
>>
>> +/* Shared among all NAND instances to synchronize the access to the ECC Engine */
>> +struct nand_hw_control omap_gpmc_controller = {
>> + .lock = __SPIN_LOCK_UNLOCKED(omap_gpmc_controller.lock),
>> + .wq = __WAIT_QUEUE_HEAD_INITIALIZER(omap_gpmc_controller.wq),
>> +};
>> +
>
> Any reason not to make this one static?
>
Right. Apart from that, this patch looks good for me.
So after that change you can add my
Acked-by: Roger Quadros <rogerq@ti.com>
cheers,
-roger
WARNING: multiple messages have this Message-ID (diff)
From: Roger Quadros <rogerq@ti.com>
To: Frans Klaver <fransklaver@gmail.com>,
Rostislav Lisovy <lisovy@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Tony Lindgren <tony@atomide.com>, <linux-mtd@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
<michal.vokac@comap.cz>, <sojkam1@fel.cvut.cz>,
Rostislav Lisovy <lisovy@merica.cz>
Subject: Re: [PATCH v3 2/2] mtd: nand: omap: Synchronize the access to the ECC engine
Date: Wed, 29 Oct 2014 11:37:09 +0200 [thread overview]
Message-ID: <5450B545.1050905@ti.com> (raw)
In-Reply-To: <CAH6sp9M0VaH8-4NXcRNUYQS8Zuzbkra6zmgjSebjv8Awj6i0og@mail.gmail.com>
Hi Rostislav,
Sorry to miss this one.
On 10/29/2014 11:24 AM, Frans Klaver wrote:
> On Thu, Oct 2, 2014 at 4:16 PM, Rostislav Lisovy <lisovy@gmail.com> wrote:
>>
>> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
>> index f0dcdb6..dfae46f 100644
>> --- a/drivers/mtd/nand/omap2.c
>> +++ b/drivers/mtd/nand/omap2.c
>> @@ -144,8 +144,13 @@ static u_char bch8_vector[] = {0xf3, 0xdb, 0x14, 0x16, 0x8b, 0xd2, 0xbe, 0xcc,
>> 0xac, 0x6b, 0xff, 0x99, 0x7b};
>> static u_char bch4_vector[] = {0x00, 0x6b, 0x31, 0xdd, 0x41, 0xbc, 0x10};
>>
>> +/* Shared among all NAND instances to synchronize the access to the ECC Engine */
>> +struct nand_hw_control omap_gpmc_controller = {
>> + .lock = __SPIN_LOCK_UNLOCKED(omap_gpmc_controller.lock),
>> + .wq = __WAIT_QUEUE_HEAD_INITIALIZER(omap_gpmc_controller.wq),
>> +};
>> +
>
> Any reason not to make this one static?
>
Right. Apart from that, this patch looks good for me.
So after that change you can add my
Acked-by: Roger Quadros <rogerq@ti.com>
cheers,
-roger
next prev parent reply other threads:[~2014-10-29 9:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-02 12:16 [PATCH v2 1/2] mtd: nand: omap: Do not use global variables Rostislav Lisovy
2014-10-02 12:16 ` Rostislav Lisovy
2014-10-02 12:16 ` [PATCH v2 2/2] mtd: nand: omap: Synchronize access to the ECC engine Rostislav Lisovy
2014-10-02 12:16 ` Rostislav Lisovy
2014-10-02 12:51 ` Roger Quadros
2014-10-02 12:51 ` Roger Quadros
2014-10-02 13:20 ` Rostislav Lisovy
2014-10-02 13:20 ` Rostislav Lisovy
2014-10-02 12:35 ` [PATCH v2 1/2] mtd: nand: omap: Do not use global variables Roger Quadros
2014-10-02 12:35 ` Roger Quadros
2014-10-02 14:16 ` [PATCH v3 2/2] mtd: nand: omap: Synchronize the access to the ECC engine Rostislav Lisovy
2014-10-02 14:16 ` Rostislav Lisovy
2014-10-29 9:16 ` Rostislav Lisovy
2014-10-29 9:16 ` Rostislav Lisovy
2014-10-29 9:24 ` Frans Klaver
2014-10-29 9:24 ` Frans Klaver
2014-10-29 9:37 ` Roger Quadros [this message]
2014-10-29 9:37 ` Roger Quadros
2014-10-22 8:34 ` [PATCH v2 1/2] mtd: nand: omap: Do not use global variables Brian Norris
2014-10-22 8:34 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5450B545.1050905@ti.com \
--to=rogerq@ti.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=fransklaver@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=lisovy@gmail.com \
--cc=lisovy@merica.cz \
--cc=michal.vokac@comap.cz \
--cc=sojkam1@fel.cvut.cz \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.