All of lore.kernel.org
 help / color / mirror / Atom feed
From: Qais Yousef <qais.yousef@imgtec.com>
To: Vinod Koul <vinod.koul@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: devicetree@vger.kernel.org, Neil Jones <neil.jones@imgtec.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Clemens Ladisch <clemens@ladisch.de>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH 00/11] Add AXD Audio Processing IP driver
Date: Wed, 29 Oct 2014 10:48:39 +0000	[thread overview]
Message-ID: <5450C607.9060603@imgtec.com> (raw)
In-Reply-To: <20141029052439.GT28745@intel.com>

On 10/29/2014 05:24 AM, Vinod Koul wrote:
> On Wed, Oct 29, 2014 at 10:50:19AM +0800, Greg Kroah-Hartman wrote:
>> cepted into staging until this is resolved?
>> If you are willing to abide by the staging rules:
>> 	- incremental patches only doing one thing at a time
>> 	- never break the build
>> 	- constantly moving forward to getting merged (i.e. no new
>> 	  features being added)
>>
>> I think it will be easier for you to do the work outside of the tree as
>> you are going to be changing the API, which is not going to be easy to
>> do in an incremental patch series.
>>
>> And yes, this isn't going to be a trivial amount of work, sorry.
> I am not sure if it can fit into staging model. The whole design of driver
> would need rework and all the infrastructure added here for exposing stuff
> to usermode will be thrown away, so this driver would simply need an
> major overhaul.
>
> If this was ALSA driver and we would need to plumb it for acceptance then
> would have made sense in include, but thats not the fact today
>
> Thanks

Thanks for all the comments Vinod. Looks like I made a bad judgement, 
clearly I wouldn't want to rewrite the code twice :) I'll take a closer 
look at using the framework and maybe start with the features that we 
know will work and build up the rest incrementally and address problems 
from there.

Thanks,
Qais

WARNING: multiple messages have this Message-ID (diff)
From: Qais Yousef <qais.yousef@imgtec.com>
To: Vinod Koul <vinod.koul@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: <devicetree@vger.kernel.org>, Neil Jones <neil.jones@imgtec.com>,
	"Arnd Bergmann" <arnd@arndb.de>,
	Clemens Ladisch <clemens@ladisch.de>,
	<alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [alsa-devel] [PATCH 00/11] Add AXD Audio Processing IP driver
Date: Wed, 29 Oct 2014 10:48:39 +0000	[thread overview]
Message-ID: <5450C607.9060603@imgtec.com> (raw)
In-Reply-To: <20141029052439.GT28745@intel.com>

On 10/29/2014 05:24 AM, Vinod Koul wrote:
> On Wed, Oct 29, 2014 at 10:50:19AM +0800, Greg Kroah-Hartman wrote:
>> cepted into staging until this is resolved?
>> If you are willing to abide by the staging rules:
>> 	- incremental patches only doing one thing at a time
>> 	- never break the build
>> 	- constantly moving forward to getting merged (i.e. no new
>> 	  features being added)
>>
>> I think it will be easier for you to do the work outside of the tree as
>> you are going to be changing the API, which is not going to be easy to
>> do in an incremental patch series.
>>
>> And yes, this isn't going to be a trivial amount of work, sorry.
> I am not sure if it can fit into staging model. The whole design of driver
> would need rework and all the infrastructure added here for exposing stuff
> to usermode will be thrown away, so this driver would simply need an
> major overhaul.
>
> If this was ALSA driver and we would need to plumb it for acceptance then
> would have made sense in include, but thats not the fact today
>
> Thanks

Thanks for all the comments Vinod. Looks like I made a bad judgement, 
clearly I wouldn't want to rewrite the code twice :) I'll take a closer 
look at using the framework and maybe start with the features that we 
know will work and build up the rest incrementally and address problems 
from there.

Thanks,
Qais

  reply	other threads:[~2014-10-29 10:48 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-28 11:26 [PATCH 00/11] Add AXD Audio Processing IP driver Qais Yousef
2014-10-28 11:26 ` Qais Yousef
2014-10-28 11:26 ` [PATCH 01/11] MAINTANERS: Add AXD as a supported driver Qais Yousef
2014-10-28 11:26   ` Qais Yousef
2014-10-29  5:42   ` [alsa-devel] " Vinod Koul
2014-10-28 11:26 ` [PATCH 02/11] dt: bindings: add AXD Audio Processing IP binding document Qais Yousef
2014-10-28 11:26   ` Qais Yousef
2014-10-28 11:26 ` [PATCH 03/11] drivers: char: add AXD Audio Processing IP driver Qais Yousef
2014-10-28 11:26   ` Qais Yousef
2014-10-28 14:10   ` Greg Kroah-Hartman
     [not found]     ` <20141028141038.GA18384-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2014-10-28 14:36       ` Qais Yousef
2014-10-28 14:36         ` Qais Yousef
     [not found]         ` <544FA9F7.1020101-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>
2014-10-28 14:50           ` Greg Kroah-Hartman
2014-10-28 14:50             ` Greg Kroah-Hartman
2014-10-29  5:33   ` [alsa-devel] " Vinod Koul
2014-10-28 11:26 ` [PATCH 04/11] drivers: char: axd: add fw binary header manipulation files Qais Yousef
2014-10-28 11:26   ` Qais Yousef
2014-10-28 11:26 ` [PATCH 05/11] drivers: char: axd: add buffers " Qais Yousef
2014-10-28 11:26   ` Qais Yousef
2014-10-28 11:26 ` [PATCH 06/11] drivers: char: axd: add basic files for sending/receiving axd cmds Qais Yousef
2014-10-28 11:26   ` Qais Yousef
2014-10-28 11:26 ` [PATCH 07/11] drivers: char: axd: add cmd interfce helper functions Qais Yousef
2014-10-28 11:26   ` Qais Yousef
2014-10-29  5:38   ` [alsa-devel] " Vinod Koul
2014-10-28 11:26 ` [PATCH 08/11] drivers: char: axd: add low level AXD platform setup files Qais Yousef
2014-10-28 11:26   ` Qais Yousef
2014-10-28 11:26 ` [PATCH 09/11] drivers: char: axd: add sysfs " Qais Yousef
2014-10-28 11:26   ` Qais Yousef
2014-10-28 14:11   ` Greg Kroah-Hartman
2014-10-28 14:38     ` Qais Yousef
2014-10-28 14:38       ` Qais Yousef
2014-10-28 14:12   ` Greg Kroah-Hartman
2014-10-28 14:39     ` Qais Yousef
2014-10-28 14:39       ` Qais Yousef
2014-10-29  5:41   ` [alsa-devel] " Vinod Koul
2014-10-28 11:26 ` [PATCH 10/11] drivers: char: axd: add ts interface file Qais Yousef
2014-10-28 11:26   ` Qais Yousef
2014-10-28 11:26 ` [PATCH 11/11] drivers: char: axd: add Kconfig and Makefile Qais Yousef
2014-10-28 11:26   ` Qais Yousef
2014-10-28 11:55 ` [PATCH 00/11] Add AXD Audio Processing IP driver Clemens Ladisch
2014-10-28 13:18   ` Qais Yousef
2014-10-28 13:18     ` Qais Yousef
     [not found]     ` <544F97A4.7080209-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org>
2014-10-28 14:13       ` Greg Kroah-Hartman
2014-10-28 14:13         ` Greg Kroah-Hartman
2014-10-28 15:05         ` Qais Yousef
2014-10-28 15:05           ` Qais Yousef
2014-10-29  2:50           ` Greg Kroah-Hartman
2014-10-29  5:24             ` [alsa-devel] " Vinod Koul
2014-10-29 10:48               ` Qais Yousef [this message]
2014-10-29 10:48                 ` Qais Yousef
2014-10-29  5:20         ` Vinod Koul
2014-10-28 14:54     ` Lars-Peter Clausen
2014-10-28 15:33       ` Qais Yousef
2014-10-28 15:33         ` Qais Yousef
2014-10-28 16:04         ` [alsa-devel] " Lars-Peter Clausen
2014-10-29  5:18     ` Vinod Koul
2014-10-29 15:06     ` Pierre-Louis Bossart
2014-10-28 12:06 ` Lars-Peter Clausen
2014-10-28 13:21   ` Qais Yousef
2014-10-28 13:21     ` Qais Yousef

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5450C607.9060603@imgtec.com \
    --to=qais.yousef@imgtec.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=arnd@arndb.de \
    --cc=clemens@ladisch.de \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neil.jones@imgtec.com \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.