All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roger Quadros <rogerq@ti.com>
To: Tony Lindgren <tony@atomide.com>, linux-omap@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 02/10] ARM: dts: Fix wrong GPMC size mappings for omaps
Date: Thu, 30 Oct 2014 14:05:54 +0200	[thread overview]
Message-ID: <545229A2.7000708@ti.com> (raw)
In-Reply-To: <1414628948-30702-3-git-send-email-tony@atomide.com>

On 10/30/2014 02:29 AM, Tony Lindgren wrote:
> The GPMC binding is obviously very confusing as the values
> are all over the place. People seem to confuse the GPMC partition
> size for the chip select, and the device IO size within the GPMC
> partition easily.
> 
> The ranges entry contains the GPMC partition size. And the
> reg entry contains the size of the IO registers of the
> device connected to the GPMC.
> 
> Let's fix the issue according to the following table:
> 
> Device          GPMC partition size     Device IO size
> connected       in the ranges entry     in the reg entry
> 
> NAND            0x01000000 (16MB)       4
> 16550           0x01000000 (16MB)       8
> smc91x          0x01000000 (16MB)       0xf
> smc911x         0x01000000 (16MB)       0xff
> OneNAND         0x01000000 (16MB)       0x20000 (128KB)
> 16MB NOR        0x01000000 (16MB)       0x01000000 (16MB)
> 32MB NOR        0x02000000 (32MB)       0x02000000 (32MB)
> 64MB NOR        0x04000000 (64MB)       0x04000000 (64MB)
> 128MB NOR       0x08000000 (128MB)      0x08000000 (128MB)
> 256MB NOR       0x10000000 (256MB)      0x10000000 (256MB)
> 
> Let's also add comments to the fixed entries while at it.
> 
> Cc: Roger Quadros <rogerq@ti.com>
> Signed-off-by: Tony Lindgren <tony@atomide.com>

Acked-by: Roger Quadros <rogerq@ti.com>

cheers,
-roger

WARNING: multiple messages have this Message-ID (diff)
From: rogerq@ti.com (Roger Quadros)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 02/10] ARM: dts: Fix wrong GPMC size mappings for omaps
Date: Thu, 30 Oct 2014 14:05:54 +0200	[thread overview]
Message-ID: <545229A2.7000708@ti.com> (raw)
In-Reply-To: <1414628948-30702-3-git-send-email-tony@atomide.com>

On 10/30/2014 02:29 AM, Tony Lindgren wrote:
> The GPMC binding is obviously very confusing as the values
> are all over the place. People seem to confuse the GPMC partition
> size for the chip select, and the device IO size within the GPMC
> partition easily.
> 
> The ranges entry contains the GPMC partition size. And the
> reg entry contains the size of the IO registers of the
> device connected to the GPMC.
> 
> Let's fix the issue according to the following table:
> 
> Device          GPMC partition size     Device IO size
> connected       in the ranges entry     in the reg entry
> 
> NAND            0x01000000 (16MB)       4
> 16550           0x01000000 (16MB)       8
> smc91x          0x01000000 (16MB)       0xf
> smc911x         0x01000000 (16MB)       0xff
> OneNAND         0x01000000 (16MB)       0x20000 (128KB)
> 16MB NOR        0x01000000 (16MB)       0x01000000 (16MB)
> 32MB NOR        0x02000000 (32MB)       0x02000000 (32MB)
> 64MB NOR        0x04000000 (64MB)       0x04000000 (64MB)
> 128MB NOR       0x08000000 (128MB)      0x08000000 (128MB)
> 256MB NOR       0x10000000 (256MB)      0x10000000 (256MB)
> 
> Let's also add comments to the fixed entries while at it.
> 
> Cc: Roger Quadros <rogerq@ti.com>
> Signed-off-by: Tony Lindgren <tony@atomide.com>

Acked-by: Roger Quadros <rogerq@ti.com>

cheers,
-roger

  reply	other threads:[~2014-10-30 12:06 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-30  0:28 [PATCH 00/10] omap gpmc and board clean-up for v3.19 merge window Tony Lindgren
2014-10-30  0:28 ` Tony Lindgren
2014-10-30  0:28 ` [PATCH 01/10] ARM: dts: Fix bootloader version dependencies by muxing n900 smc91x pins Tony Lindgren
2014-10-30  0:28   ` Tony Lindgren
2014-10-30 11:59   ` Roger Quadros
2014-10-30 11:59     ` Roger Quadros
2014-10-30 15:49     ` Tony Lindgren
2014-10-30 15:49       ` Tony Lindgren
2014-11-03  9:30       ` Roger Quadros
2014-11-03  9:30         ` Roger Quadros
2014-10-30  0:29 ` [PATCH 02/10] ARM: dts: Fix wrong GPMC size mappings for omaps Tony Lindgren
2014-10-30  0:29   ` Tony Lindgren
2014-10-30 12:05   ` Roger Quadros [this message]
2014-10-30 12:05     ` Roger Quadros
2014-10-30  0:29 ` [PATCH 03/10] ARM: dts: Add smc91x GPMC configuration for 2430sdp Tony Lindgren
2014-10-30  0:29   ` Tony Lindgren
2014-10-30  0:29 ` [PATCH 04/10] ARM: dts: Add GPMC timings for omap zoom serial port Tony Lindgren
2014-10-30  0:29   ` Tony Lindgren
2014-10-30 12:21   ` Roger Quadros
2014-10-30 12:21     ` Roger Quadros
2014-10-30  0:29 ` [PATCH 05/10] ARM: OMAP2+: Fix support for multiple devices on a GPMC chip select Tony Lindgren
2014-10-30  0:29   ` Tony Lindgren
2014-10-30 12:26   ` Roger Quadros
2014-10-30 12:26     ` Roger Quadros
2014-10-30  0:29 ` [PATCH 06/10] ARM: OMAP2+: Show bootloader GPMC timings to allow configuring the .dts file Tony Lindgren
2014-10-30  0:29   ` Tony Lindgren
2014-10-30 14:19   ` Roger Quadros
2014-10-30 14:19     ` Roger Quadros
2014-10-30 14:45     ` Tony Lindgren
2014-10-30 14:45       ` Tony Lindgren
2014-10-30 15:04       ` Roger Quadros
2014-10-30 15:04         ` Roger Quadros
2014-10-30 16:30         ` Tony Lindgren
2014-10-30 16:30           ` Tony Lindgren
2014-10-31  9:24           ` Roger Quadros
2014-10-31  9:24             ` Roger Quadros
2014-11-04 13:40           ` Roger Quadros
2014-11-04 13:40             ` Roger Quadros
2014-11-04 15:49             ` Tony Lindgren
2014-11-04 15:49               ` Tony Lindgren
2014-10-30 14:26   ` Roger Quadros
2014-10-30 14:26     ` Roger Quadros
2014-10-30  0:29 ` [PATCH 07/10] ARM: OMAP2+: Require proper GPMC timings for devices Tony Lindgren
2014-10-30  0:29   ` Tony Lindgren
2014-10-30 14:27   ` Roger Quadros
2014-10-30 14:27     ` Roger Quadros
2014-10-30  0:29 ` [PATCH 08/10] ARM: OMAP2+: Drop legacy code for gpmc-smc91x.c Tony Lindgren
2014-10-30  0:29   ` Tony Lindgren
2014-10-30 14:28   ` Roger Quadros
2014-10-30 14:28     ` Roger Quadros
2014-10-30  0:29 ` [PATCH 09/10] ARM: OMAP2+: Drop board file for ti8168evm Tony Lindgren
2014-10-30  0:29   ` Tony Lindgren
2014-10-30  0:29 ` [PATCH 10/10] ARM: omap2plus: Drop board file for 3430sdp Tony Lindgren
2014-10-30  0:29   ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=545229A2.7000708@ti.com \
    --to=rogerq@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.