From: Kever Yang <kever.yang@rock-chips.com>
To: dinguyen@opensource.altera.com, paulz@synopsys.com, balbi@ti.com
Cc: dinh.linux@gmail.com, swarren@wwwdotorg.org,
b.zolnierkie@samsung.com, matthijs@stdin.nl,
r.baldyga@samsung.com, jg1.han@samsung.com,
sachin.kamat@linaro.org, ben-linux@fluff.org,
dianders@chromium.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHv6 6/8] usb: dwc2: gadget: Do not fail probe if there isn't a clock node
Date: Fri, 31 Oct 2014 10:38:28 +0800 [thread overview]
Message-ID: <5452F624.709@rock-chips.com> (raw)
In-Reply-To: <1414538749-14735-7-git-send-email-dinguyen@opensource.altera.com>
Hi Dinh,
On 10/29/2014 07:25 AM, dinguyen@opensource.altera.com wrote:
> From: Dinh Nguyen <dinguyen@opensource.altera.com>
>
> Since the dwc2 hcd driver is currently not looking for a clock node during
> init, we should not completely fail if there isn't a clock provided.
> For dual-role mode, we will only fail init for a non-clock node error. We
> then update the HCD to only call gadget funtions if there is a proper clock
> node.
We have to add clock management for hcd, and I think it is better to
do it before more Socs use this driver, isn't it?
I have do something in my RFC patches, but I think I still do it in a
wrong way.
Can we just handle all the clock thing in platform?
Balbi suggested in my patch that we can "hide" clk_enable()/disable() under
->runtime_resume()/->runtime_suspend() and linux driver model.
Can this be in platform driver?
- Kever
next prev parent reply other threads:[~2014-10-31 2:38 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-28 23:25 [PATCHv6 0/8] usb: dwc2: Add support for dual-role dinguyen
2014-10-28 23:25 ` [PATCHv6 1/8] usb: dwc2: Update the gadget driver to use common dwc2_hsotg structure dinguyen
2014-10-30 13:54 ` Felipe Balbi
2014-10-31 14:55 ` Dinh Nguyen
2014-10-31 2:47 ` Kever Yang
2014-10-31 13:48 ` Felipe Balbi
2014-10-28 23:25 ` [PATCHv6 2/8] usb: dwc2: Move gadget probe function into platform code dinguyen
2014-10-30 13:57 ` Felipe Balbi
2014-10-31 14:59 ` Dinh Nguyen
2014-10-28 23:25 ` [PATCHv6 3/8] usb: dwc2: Initialize the USB core for peripheral mode dinguyen
2014-10-28 23:25 ` [PATCHv6 4/8] usb: dwc2: Update common interrupt handler to call gadget interrupt handler dinguyen
2014-10-30 14:00 ` Felipe Balbi
2014-10-31 15:00 ` Dinh Nguyen
2014-10-31 20:12 ` Paul Zimmerman
2014-10-28 23:25 ` [PATCHv6 5/8] usb: dwc2: Add call_gadget functions for perpheral mode interrupts dinguyen
2014-10-30 14:01 ` Felipe Balbi
2014-10-31 15:01 ` Dinh Nguyen
2014-10-28 23:25 ` [PATCHv6 6/8] usb: dwc2: gadget: Do not fail probe if there isn't a clock node dinguyen
2014-10-29 1:30 ` Paul Zimmerman
2014-10-30 14:04 ` Felipe Balbi
2014-10-31 15:20 ` Dinh Nguyen
2014-10-31 17:42 ` Felipe Balbi
2014-10-31 19:31 ` Dinh Nguyen
2014-10-31 19:56 ` Dinh Nguyen
2014-11-03 15:25 ` Felipe Balbi
2014-10-31 2:38 ` Kever Yang [this message]
2014-10-31 13:49 ` Felipe Balbi
2014-10-28 23:25 ` [PATCHv6 7/8] usb: dwc2: Update Kconfig to support dual-role dinguyen
2014-10-28 23:25 ` [PATCHv6 8/8] usb: dwc2: move usb_disabled() call to host driver only dinguyen
2014-10-29 1:26 ` Paul Zimmerman
2014-10-29 13:35 ` Dinh Nguyen
2014-10-30 14:07 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5452F624.709@rock-chips.com \
--to=kever.yang@rock-chips.com \
--cc=b.zolnierkie@samsung.com \
--cc=balbi@ti.com \
--cc=ben-linux@fluff.org \
--cc=dianders@chromium.org \
--cc=dinguyen@opensource.altera.com \
--cc=dinh.linux@gmail.com \
--cc=jg1.han@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=matthijs@stdin.nl \
--cc=paulz@synopsys.com \
--cc=r.baldyga@samsung.com \
--cc=sachin.kamat@linaro.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.