All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Michael Ellerman <mpe@ellerman.id.au>, jdelvare@suse.de
Cc: lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org,
	neelegup@linux.vnet.ibm.com
Subject: Re: [lm-sensors] [PATCH 2/2] hwmon: (ibmpowernv) Make the driver name more recognisable
Date: Fri, 31 Oct 2014 13:10:52 +0000	[thread overview]
Message-ID: <54538A5C.7000204@roeck-us.net> (raw)
In-Reply-To: <1414737923-8227-2-git-send-email-mpe@ellerman.id.au>

On 10/30/2014 11:45 PM, Michael Ellerman wrote:
> Seeing "ibmpowernv" in dmesg is not very useful, that is just the name
> of the platform and doesn't identify the message as coming from the
> hwmon driver.
>
> Change DRVNAME to "powernv-hwmon" to make it clearer.
>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> ---
>   drivers/hwmon/ibmpowernv.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/ibmpowernv.c b/drivers/hwmon/ibmpowernv.c
> index 6a30eeea94be..3ee00928cda9 100644
> --- a/drivers/hwmon/ibmpowernv.c
> +++ b/drivers/hwmon/ibmpowernv.c
> @@ -16,7 +16,7 @@
>    * along with this program.
>    */
>
> -#define DRVNAME		"ibmpowernv"
> +#define DRVNAME		"powernv-hwmon"
>   #define pr_fmt(fmt)	DRVNAME ": " fmt
>
>   #include <linux/init.h>
>
That results in a sensor name that includes "hwmon" and a dash.
The first doesn't make sense, the second is illegal and will be
rejected by the hwmon subsystem.

Nack.

Guenter


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Michael Ellerman <mpe@ellerman.id.au>, jdelvare@suse.de
Cc: lm-sensors@lm-sensors.org, linux-kernel@vger.kernel.org,
	neelegup@linux.vnet.ibm.com
Subject: Re: [PATCH 2/2] hwmon: (ibmpowernv) Make the driver name more recognisable
Date: Fri, 31 Oct 2014 06:10:52 -0700	[thread overview]
Message-ID: <54538A5C.7000204@roeck-us.net> (raw)
In-Reply-To: <1414737923-8227-2-git-send-email-mpe@ellerman.id.au>

On 10/30/2014 11:45 PM, Michael Ellerman wrote:
> Seeing "ibmpowernv" in dmesg is not very useful, that is just the name
> of the platform and doesn't identify the message as coming from the
> hwmon driver.
>
> Change DRVNAME to "powernv-hwmon" to make it clearer.
>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> ---
>   drivers/hwmon/ibmpowernv.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/ibmpowernv.c b/drivers/hwmon/ibmpowernv.c
> index 6a30eeea94be..3ee00928cda9 100644
> --- a/drivers/hwmon/ibmpowernv.c
> +++ b/drivers/hwmon/ibmpowernv.c
> @@ -16,7 +16,7 @@
>    * along with this program.
>    */
>
> -#define DRVNAME		"ibmpowernv"
> +#define DRVNAME		"powernv-hwmon"
>   #define pr_fmt(fmt)	DRVNAME ": " fmt
>
>   #include <linux/init.h>
>
That results in a sensor name that includes "hwmon" and a dash.
The first doesn't make sense, the second is illegal and will be
rejected by the hwmon subsystem.

Nack.

Guenter


  parent reply	other threads:[~2014-10-31 13:10 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-31  6:45 [lm-sensors] [PATCH 1/2] hwmon: (ibmpowernv) Quieten when probing finds no device Michael Ellerman
2014-10-31  6:45 ` Michael Ellerman
2014-10-31  6:45 ` [lm-sensors] [PATCH 2/2] hwmon: (ibmpowernv) Make the driver name more recognisable Michael Ellerman
2014-10-31  6:45   ` Michael Ellerman
2014-10-31  8:35   ` [lm-sensors] " Jean Delvare
2014-10-31  8:35     ` Jean Delvare
2014-10-31 13:10   ` Guenter Roeck [this message]
2014-10-31 13:10     ` Guenter Roeck
2014-10-31  9:41 ` [lm-sensors] [PATCH 1/2] hwmon: (ibmpowernv) Quieten when probing finds no device Jean Delvare
2014-10-31  9:41   ` Jean Delvare
2014-10-31 13:21   ` [lm-sensors] " Guenter Roeck
2014-10-31 13:21     ` Guenter Roeck
2014-11-01 17:53     ` Neelesh Gupta
2014-11-01 17:58       ` [lm-sensors] " Neelesh Gupta
2014-11-03 16:20   ` Guenter Roeck
2014-11-03 16:20     ` Guenter Roeck
2014-10-31 13:12 ` [lm-sensors] " Guenter Roeck
2014-10-31 13:12   ` Guenter Roeck
2014-10-31 18:12 ` [lm-sensors] " Guenter Roeck
2014-10-31 18:12   ` Guenter Roeck
2014-11-01 17:52 ` [lm-sensors] " Neelesh Gupta
2014-11-01 21:15   ` Guenter Roeck
2014-11-01 21:15     ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54538A5C.7000204@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=jdelvare@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lm-sensors@lm-sensors.org \
    --cc=mpe@ellerman.id.au \
    --cc=neelegup@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.