* [PATCH] ASoC: CS42L51_I2C depends on I2C
@ 2014-10-31 17:54 Randy Dunlap
2014-10-31 19:22 ` Brian Austin
2014-10-31 19:26 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Randy Dunlap @ 2014-10-31 17:54 UTC (permalink / raw)
To: Brian Austin, Paul Handrigan, Liam Girdwood, Mark Brown
Cc: moderated for non-subscribers
From: Randy Dunlap <rdunlap@infradead.org>
Fix build errors when CONFIG_I2C is not enabled by making the
driver depend on I2C.
../sound/soc/codecs/cs42l51-i2c.c:55:1: warning: data definition has no type or storage class [enabled by default]
module_i2c_driver(cs42l51_i2c_driver);
^
../sound/soc/codecs/cs42l51-i2c.c:55:1: error: type defaults to 'int' in declaration of 'module_i2c_driver' [-Werror=implicit-int]
../sound/soc/codecs/cs42l51-i2c.c:55:1: warning: parameter names (without types) in function declaration [enabled by default]
../sound/soc/codecs/cs42l51-i2c.c:45:26: warning: 'cs42l51_i2c_driver' defined but not used [-Wunused-variable]
static struct i2c_driver cs42l51_i2c_driver = {
^
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
sound/soc/codecs/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20141031.orig/sound/soc/codecs/Kconfig
+++ linux-next-20141031/sound/soc/codecs/Kconfig
@@ -338,6 +338,7 @@ config SND_SOC_CS42L51
config SND_SOC_CS42L51_I2C
tristate "Cirrus Logic CS42L51 CODEC (I2C)"
+ depends on I2C
select SND_SOC_CS42L51
config SND_SOC_CS42L52
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: CS42L51_I2C depends on I2C
2014-10-31 17:54 [PATCH] ASoC: CS42L51_I2C depends on I2C Randy Dunlap
@ 2014-10-31 19:22 ` Brian Austin
2014-10-31 19:26 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Brian Austin @ 2014-10-31 19:22 UTC (permalink / raw)
To: Randy Dunlap
Cc: moderated for non-subscribers, Brian Austin, Mark Brown,
Liam Girdwood, Paul Handrigan
On Fri, 31 Oct 2014, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix build errors when CONFIG_I2C is not enabled by making the
> driver depend on I2C.
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Acked-by: Brian Austin <brian.austin@cirrus.com>
Thanks for submitting this. Sorry I dropped it
Brian
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: CS42L51_I2C depends on I2C
2014-10-31 17:54 [PATCH] ASoC: CS42L51_I2C depends on I2C Randy Dunlap
2014-10-31 19:22 ` Brian Austin
@ 2014-10-31 19:26 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2014-10-31 19:26 UTC (permalink / raw)
To: Randy Dunlap
Cc: Brian Austin, moderated for non-subscribers, Liam Girdwood,
Paul Handrigan
[-- Attachment #1.1: Type: text/plain, Size: 278 bytes --]
On Fri, Oct 31, 2014 at 10:54:23AM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix build errors when CONFIG_I2C is not enabled by making the
> driver depend on I2C.
Applied, please do try to follow the changelog style for the subsystem.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-10-31 19:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-31 17:54 [PATCH] ASoC: CS42L51_I2C depends on I2C Randy Dunlap
2014-10-31 19:22 ` Brian Austin
2014-10-31 19:26 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.