Re: [PATCH 3/7] [media] cx231xx: Cleanup printk at the driver

[Antti Palosaari <crope@iki.fi>]

On 11/01/2014 03:38 PM, Mauro Carvalho Chehab wrote:
> There are lots of debug printks printed with pr_info. Also, the
> printk's data are not too coherent:
>
> - there are duplicated driver name at the print format;
> - function name format string differs from function to function;
> - long strings broken into multiple lines;
> - some printks just produce ugly reports, being almost useless
>    as-is.
>
> Do a cleanup on that.
>
> Still, there are much to be done in order to do a better printk
> job on this driver, but, at least it will now be a way less
> verbose, if debug printks are disabled, and some logs might
> actually be useful.

As you do that kind of cleanup, why don't just use a bit more time and 
do it properly using dev_foo() logging. Basically all device drivers 
should use dev_foo() logging, it prints module name, bus number etc. 
automatically in a standard manner. pr_foo() is worse, which should be 
only used for cases where pointer to device is not available (like library).

regards
Antti

-- 
http://palosaari.fi/