From: Matthias Schwarzott <zzam@gentoo.org>
To: Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
Linux Media Mailing List <linux-media@vger.kernel.org>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
Antti Palosaari <crope@iki.fi>,
Hans Verkuil <hans.verkuil@cisco.com>
Subject: Re: [PATCH 6/7] [media] cx231xx-i2c: fix i2c_scan modprobe parameter
Date: Sat, 01 Nov 2014 17:46:41 +0100 [thread overview]
Message-ID: <54550E71.9010006@gentoo.org> (raw)
In-Reply-To: <14a334de4f4b5786e55ce62872f7b033e9f0af3f.1414849031.git.mchehab@osg.samsung.com>
On 01.11.2014 14:38, Mauro Carvalho Chehab wrote:
> This device doesn't properly implement read with a zero bytes
> len. So, use 1 byte for I2C scan.
>
Yes, the idea sounds good, but we should fix this in the code in
cx231xx_i2c_check_for_device.
> Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
>
> diff --git a/drivers/media/usb/cx231xx/cx231xx-i2c.c b/drivers/media/usb/cx231xx/cx231xx-i2c.c
> index 1a0d9efeb209..9b7e5a155e34 100644
> --- a/drivers/media/usb/cx231xx/cx231xx-i2c.c
> +++ b/drivers/media/usb/cx231xx/cx231xx-i2c.c
> @@ -502,7 +502,7 @@ void cx231xx_do_i2c_scan(struct cx231xx *dev, int i2c_port)
> i2c_port);
> for (i = 0; i < 128; i++) {
> client.addr = i;
> - rc = i2c_master_recv(&client, &buf, 0);
> + rc = i2c_master_recv(&client, &buf, 1);
> if (rc < 0)
> continue;
> pr_info("i2c scan: found device @ 0x%x [%s]\n",
>
next prev parent reply other threads:[~2014-11-01 16:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1414849139-29609-1-git-send-email-mchehab@osg.samsung.com>
[not found] ` <cover.1414849031.git.mchehab@osg.samsung.com>
2014-11-01 13:38 ` [PATCH 1/7] [media] cx231xx: get rid of driver-defined printk macros Mauro Carvalho Chehab
2014-11-01 13:38 ` [PATCH 2/7] [media] cx231xx: Fix identation Mauro Carvalho Chehab
2014-11-01 13:38 ` [PATCH 3/7] [media] cx231xx: Cleanup printk at the driver Mauro Carvalho Chehab
2014-11-01 14:01 ` Antti Palosaari
2014-11-01 14:08 ` Mauro Carvalho Chehab
2014-11-02 11:46 ` Mauro Carvalho Chehab
2014-11-01 13:38 ` [PATCH 4/7] [media] cx25840: Don't report an error if max size is adjusted Mauro Carvalho Chehab
2014-11-01 13:38 ` [PATCH 5/7] [media] cx25840: convert max_buf_size var to lowercase Mauro Carvalho Chehab
2014-11-01 13:38 ` [PATCH 6/7] [media] cx231xx-i2c: fix i2c_scan modprobe parameter Mauro Carvalho Chehab
2014-11-01 16:46 ` Matthias Schwarzott [this message]
2014-11-01 20:19 ` [PATCH] cx231xx: use 1 byte read for i2c scan Matthias Schwarzott
2014-11-02 1:24 ` [PATCH 6/7] [media] cx231xx-i2c: fix i2c_scan modprobe parameter Mauro Carvalho Chehab
2014-11-01 13:38 ` [PATCH 7/7] [media] cx231xx: disable I2C errors during i2c_scan Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54550E71.9010006@gentoo.org \
--to=zzam@gentoo.org \
--cc=crope@iki.fi \
--cc=hans.verkuil@cisco.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=mchehab@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.