All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Gonglei <arei.gonglei@huawei.com>
Cc: "qemu-trivial@nongnu.org" <qemu-trivial@nongnu.org>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"stefanha@redhat.com" <stefanha@redhat.com>,
	"Huangpeng \(Peter\)" <peter.huangpeng@huawei.com>
Subject: Re: [Qemu-trivial] [PATCH 2/2] tap: fix possible fd leak
Date: Sun, 02 Nov 2014 08:24:22 +0300	[thread overview]
Message-ID: <5455C006.3010706@msgid.tls.msk.ru> (raw)
In-Reply-To: <5455BF5F.3010400@huawei.com>

02.11.2014 08:21, Gonglei wrote:
[]
> Agree. v2 will do. Thanks!

Also, I think it's good idea to add " in net_init_tap" to subject.
(And please don't resend both patches, as I already applied first :)

Thanks,

/mjt


WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: Gonglei <arei.gonglei@huawei.com>
Cc: "qemu-trivial@nongnu.org" <qemu-trivial@nongnu.org>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"stefanha@redhat.com" <stefanha@redhat.com>,
	"Huangpeng (Peter)" <peter.huangpeng@huawei.com>
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH 2/2] tap: fix possible fd leak
Date: Sun, 02 Nov 2014 08:24:22 +0300	[thread overview]
Message-ID: <5455C006.3010706@msgid.tls.msk.ru> (raw)
In-Reply-To: <5455BF5F.3010400@huawei.com>

02.11.2014 08:21, Gonglei wrote:
[]
> Agree. v2 will do. Thanks!

Also, I think it's good idea to add " in net_init_tap" to subject.
(And please don't resend both patches, as I already applied first :)

Thanks,

/mjt

  reply	other threads:[~2014-11-02  5:24 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-31  6:10 [Qemu-trivial] [PATCH 0/2] tap: add cleanup logic avoiding leaking fd arei.gonglei
2014-10-31  6:10 ` [Qemu-devel] " arei.gonglei
2014-10-31  6:11 ` [Qemu-trivial] [PATCH 1/2] tap: remove close(fd) arei.gonglei
2014-10-31  6:11   ` [Qemu-devel] " arei.gonglei
2014-11-02  5:06   ` [Qemu-trivial] " Michael Tokarev
2014-11-02  5:06     ` [Qemu-devel] " Michael Tokarev
2014-11-02  5:09     ` Gonglei
2014-11-02  5:09       ` [Qemu-devel] " Gonglei
2014-10-31  6:11 ` [Qemu-trivial] [PATCH 2/2] tap: fix possible fd leak arei.gonglei
2014-10-31  6:11   ` [Qemu-devel] " arei.gonglei
2014-11-02  5:11   ` [Qemu-trivial] " Michael Tokarev
2014-11-02  5:11     ` [Qemu-devel] " Michael Tokarev
2014-11-02  5:21     ` Gonglei
2014-11-02  5:21       ` [Qemu-devel] " Gonglei
2014-11-02  5:24       ` Michael Tokarev [this message]
2014-11-02  5:24         ` Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5455C006.3010706@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=arei.gonglei@huawei.com \
    --cc=peter.huangpeng@huawei.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.