All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gonglei <arei.gonglei@huawei.com>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: "qemu-trivial@nongnu.org" <qemu-trivial@nongnu.org>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"stefanha@redhat.com" <stefanha@redhat.com>,
	"Huangpeng \(Peter\)" <peter.huangpeng@huawei.com>
Subject: Re: [Qemu-trivial] [PATCH v2] tap: fix possible fd leak in net_init_tap
Date: Sun, 2 Nov 2014 13:51:54 +0800	[thread overview]
Message-ID: <5455C67A.3080007@huawei.com> (raw)
In-Reply-To: <5455C380.7080506@msgid.tls.msk.ru>

On 2014/11/2 13:39, Michael Tokarev wrote:

> 02.11.2014 08:37, arei.gonglei@huawei.com wrote:
>>
>> In hotplugging scenario, taking those true branch, the file
>> handler do not be closed. Let's close them before return.
> 
> This looks much better now, and is shorter too :)
> Applied to -trivial, thank you!
> 

Thanks :)

Best regards,
-Gonglei



WARNING: multiple messages have this Message-ID (diff)
From: Gonglei <arei.gonglei@huawei.com>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: "qemu-trivial@nongnu.org" <qemu-trivial@nongnu.org>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"stefanha@redhat.com" <stefanha@redhat.com>,
	"Huangpeng (Peter)" <peter.huangpeng@huawei.com>
Subject: Re: [Qemu-devel] [PATCH v2] tap: fix possible fd leak in net_init_tap
Date: Sun, 2 Nov 2014 13:51:54 +0800	[thread overview]
Message-ID: <5455C67A.3080007@huawei.com> (raw)
In-Reply-To: <5455C380.7080506@msgid.tls.msk.ru>

On 2014/11/2 13:39, Michael Tokarev wrote:

> 02.11.2014 08:37, arei.gonglei@huawei.com wrote:
>>
>> In hotplugging scenario, taking those true branch, the file
>> handler do not be closed. Let's close them before return.
> 
> This looks much better now, and is shorter too :)
> Applied to -trivial, thank you!
> 

Thanks :)

Best regards,
-Gonglei

  reply	other threads:[~2014-11-02  5:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-02  5:37 [Qemu-trivial] [PATCH v2] tap: fix possible fd leak in net_init_tap arei.gonglei
2014-11-02  5:37 ` [Qemu-devel] " arei.gonglei
2014-11-02  5:39 ` [Qemu-trivial] " Michael Tokarev
2014-11-02  5:39   ` [Qemu-devel] " Michael Tokarev
2014-11-02  5:51   ` Gonglei [this message]
2014-11-02  5:51     ` Gonglei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5455C67A.3080007@huawei.com \
    --to=arei.gonglei@huawei.com \
    --cc=mjt@tls.msk.ru \
    --cc=peter.huangpeng@huawei.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.