All of lore.kernel.org
 help / color / mirror / Atom feed
From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: "Andreas Färber" <afaerber@suse.de>,
	"Georgi Djakov" <gdjakov@mm-sol.com>
Cc: Bjorn Andersson <bjorn@kryo.se>,
	Kumar Gala <galak@codeaurora.org>,
	Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Russell King <linux@arm.linux.org.uk>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	linux-arm-msm <linux-arm-msm@vger.kernel.org>,
	"Ivan T. Ivanov" <iivanov@mm-sol.com>
Subject: Re: [PATCH v2 3/3] ARM: dts: qcom: Add SDHC nodes for APQ8084 platform
Date: Sun, 02 Nov 2014 08:08:34 +0000	[thread overview]
Message-ID: <5455E682.1040306@linaro.org> (raw)
In-Reply-To: <5454FFAC.2040500@suse.de>

Hi Andreas,

On 01/11/14 15:43, Andreas Färber wrote:
> Hi Georgi,
>
> Am 14.10.2014 um 18:17 schrieb Georgi Djakov:
>> On 10/10/2014 08:14 PM, Bjorn Andersson wrote:
>>> On Tue, Sep 2, 2014 at 8:40 AM, Georgi Djakov <gdjakov@mm-sol.com> wrote:
>>>> Enable support for the two SD host controllers on the APQ8084 platform
>>>> by adding the required nodes to the DT files.
>>>> On the IFC6540 board, the first controller is connected to the onboard
>>>> eMMC and the second is connected to a micro-SD card slot.
>>>>
>>>> Signed-off-by: Georgi Djakov <gdjakov@mm-sol.com>
> [...]
>>>> ---
>>>>   arch/arm/boot/dts/qcom-apq8084-ifc6540.dts |   11 +++++++++++
>>>>   arch/arm/boot/dts/qcom-apq8084.dtsi        |   23 +++++++++++++++++++++++
>>>>   2 files changed, 34 insertions(+)
>>>>
>>>> diff --git a/arch/arm/boot/dts/qcom-apq8084-ifc6540.dts b/arch/arm/boot/dts/qcom-apq8084-ifc6540.dts
>>>> index e41cb8a..c9ff108 100644
>>>> --- a/arch/arm/boot/dts/qcom-apq8084-ifc6540.dts
>>>> +++ b/arch/arm/boot/dts/qcom-apq8084-ifc6540.dts
>>> [..]
>>>> +               sdhci@f98a4900 {
>>>> +                       cd-gpios = <&tlmm 122 GPIO_ACTIVE_LOW>;
>>>> +                       bus-width = <4>;
>>>
>>> ...why do you add this node and leave it disabled in the dts?
>>>
>>
>> Hi Bjorn,
>> Currently only the eMMC is functional on this board, so now we
>> have just the board specific configuration under this node.
>> More patches are forthcoming.
>
> Any update on this? This still seems to be the latest IFC6540 commit:
>
> https://git.linaro.org/landing-teams/working/qualcomm/kernel.git/commit/66c04e30f4a6e6ed998a6c154a6c45b3cd5b3fde
>
> Following the instructions in https://wiki.linaro.org/Boards/IFC6540

I did update the wiki with more instructions to flash rootfs on to eMMC.

> I've tried to pass a full rootfs as ramdisk parameter (fastboot boot -c
> "console=ttyMSM0,115200,n8 rw rootwait" -b 0x0 zImage-ifc6540
> initrd.cpio.gz), but I then get:
There is a typo here, I fixed it as well.
#sudo fastboot boot -c "console=ttyMSM0,115200,n8 root=/dev/mmcblk0p25 
rootwait rw" -b 0x80200000 zImage-dtb

Could you give this a try?

>
> [258660] fastboot: download:12738800
> [268150] fastboot: boot
> [268150] kernel/ramdisk addresses overlap with aboot addresses.
>
> Booting without ramdisk specified works, but for lack of SD, USB and
> network support I then have no root.
>
Now you can flash the rootfs into the eMMC partition.
> So, do you have any new insights on why 'status = "okay";' doesn't work
> for the above sdhci node? Or do you have a working config you can share
> for creating a non-overlapping abootimg?

thanks,
sirni
>
> Regards,
> Andreas
>

WARNING: multiple messages have this Message-ID (diff)
From: srinivas.kandagatla@linaro.org (Srinivas Kandagatla)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/3] ARM: dts: qcom: Add SDHC nodes for APQ8084 platform
Date: Sun, 02 Nov 2014 08:08:34 +0000	[thread overview]
Message-ID: <5455E682.1040306@linaro.org> (raw)
In-Reply-To: <5454FFAC.2040500@suse.de>

Hi Andreas,

On 01/11/14 15:43, Andreas F?rber wrote:
> Hi Georgi,
>
> Am 14.10.2014 um 18:17 schrieb Georgi Djakov:
>> On 10/10/2014 08:14 PM, Bjorn Andersson wrote:
>>> On Tue, Sep 2, 2014 at 8:40 AM, Georgi Djakov <gdjakov@mm-sol.com> wrote:
>>>> Enable support for the two SD host controllers on the APQ8084 platform
>>>> by adding the required nodes to the DT files.
>>>> On the IFC6540 board, the first controller is connected to the onboard
>>>> eMMC and the second is connected to a micro-SD card slot.
>>>>
>>>> Signed-off-by: Georgi Djakov <gdjakov@mm-sol.com>
> [...]
>>>> ---
>>>>   arch/arm/boot/dts/qcom-apq8084-ifc6540.dts |   11 +++++++++++
>>>>   arch/arm/boot/dts/qcom-apq8084.dtsi        |   23 +++++++++++++++++++++++
>>>>   2 files changed, 34 insertions(+)
>>>>
>>>> diff --git a/arch/arm/boot/dts/qcom-apq8084-ifc6540.dts b/arch/arm/boot/dts/qcom-apq8084-ifc6540.dts
>>>> index e41cb8a..c9ff108 100644
>>>> --- a/arch/arm/boot/dts/qcom-apq8084-ifc6540.dts
>>>> +++ b/arch/arm/boot/dts/qcom-apq8084-ifc6540.dts
>>> [..]
>>>> +               sdhci at f98a4900 {
>>>> +                       cd-gpios = <&tlmm 122 GPIO_ACTIVE_LOW>;
>>>> +                       bus-width = <4>;
>>>
>>> ...why do you add this node and leave it disabled in the dts?
>>>
>>
>> Hi Bjorn,
>> Currently only the eMMC is functional on this board, so now we
>> have just the board specific configuration under this node.
>> More patches are forthcoming.
>
> Any update on this? This still seems to be the latest IFC6540 commit:
>
> https://git.linaro.org/landing-teams/working/qualcomm/kernel.git/commit/66c04e30f4a6e6ed998a6c154a6c45b3cd5b3fde
>
> Following the instructions in https://wiki.linaro.org/Boards/IFC6540

I did update the wiki with more instructions to flash rootfs on to eMMC.

> I've tried to pass a full rootfs as ramdisk parameter (fastboot boot -c
> "console=ttyMSM0,115200,n8 rw rootwait" -b 0x0 zImage-ifc6540
> initrd.cpio.gz), but I then get:
There is a typo here, I fixed it as well.
#sudo fastboot boot -c "console=ttyMSM0,115200,n8 root=/dev/mmcblk0p25 
rootwait rw" -b 0x80200000 zImage-dtb

Could you give this a try?

>
> [258660] fastboot: download:12738800
> [268150] fastboot: boot
> [268150] kernel/ramdisk addresses overlap with aboot addresses.
>
> Booting without ramdisk specified works, but for lack of SD, USB and
> network support I then have no root.
>
Now you can flash the rootfs into the eMMC partition.
> So, do you have any new insights on why 'status = "okay";' doesn't work
> for the above sdhci node? Or do you have a working config you can share
> for creating a non-overlapping abootimg?

thanks,
sirni
>
> Regards,
> Andreas
>

  reply	other threads:[~2014-11-02  8:08 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-02 15:40 [PATCH v2 0/3] ARM: dts: qcom: Add initial IFC6540 board support Georgi Djakov
2014-09-02 15:40 ` Georgi Djakov
2014-09-02 15:40 ` [PATCH v2 1/3] ARM: dts: qcom: Add initial IFC6540 board device tree Georgi Djakov
2014-09-02 15:40   ` Georgi Djakov
2014-09-02 15:40 ` [PATCH v2 2/3] ARM: dts: qcom: Enable serial port on IFC6540 boards Georgi Djakov
2014-09-02 15:40   ` Georgi Djakov
2014-09-02 15:40 ` [PATCH v2 3/3] ARM: dts: qcom: Add SDHC nodes for APQ8084 platform Georgi Djakov
2014-09-02 15:40   ` Georgi Djakov
2014-10-08 19:18   ` Nicolas Dechesne
2014-10-08 19:18     ` Nicolas Dechesne
2014-10-08 19:45     ` Josh Cartwright
2014-10-08 19:45       ` Josh Cartwright
2014-10-09  6:56       ` Nicolas Dechesne
2014-10-09  6:56         ` Nicolas Dechesne
2014-10-10 17:14   ` Bjorn Andersson
2014-10-10 17:14     ` Bjorn Andersson
2014-10-14 16:17     ` Georgi Djakov
2014-10-14 16:17       ` Georgi Djakov
2014-10-15  7:56       ` Kumar Gala
2014-10-15  7:56         ` Kumar Gala
2014-11-01 15:43       ` Andreas Färber
2014-11-01 15:43         ` Andreas Färber
2014-11-02  8:08         ` Srinivas Kandagatla [this message]
2014-11-02  8:08           ` Srinivas Kandagatla
2014-09-02 15:54 ` [PATCH v2 0/3] ARM: dts: qcom: Add initial IFC6540 board support Kumar Gala
2014-09-02 15:54   ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5455E682.1040306@linaro.org \
    --to=srinivas.kandagatla@linaro.org \
    --cc=afaerber@suse.de \
    --cc=bjorn@kryo.se \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=gdjakov@mm-sol.com \
    --cc=iivanov@mm-sol.com \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.