All of lore.kernel.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 07/12] usb: chipidea: add a usb2 driver for ci13xxx
Date: Thu, 17 Jul 2014 12:21:56 +0200	[thread overview]
Message-ID: <5456516.0fVZeXjF8k@wuerfel> (raw)
In-Reply-To: <93903d5fdf85427bb8a418894540c122@BN1PR0301MB0772.namprd03.prod.outlook.com>

On Thursday 17 July 2014 01:20:54 Peter Chen wrote:
> Thanks, arnd.
> 
> For chipidea generic glue layer case, if there are three devices who use this
> driver, and all devices have 32-bit bus, some devices have less 32 address lines.
> For example:
> 
> - the device_a doesn't need to use dma_mask
> - the device_b needs dma_mask as 0xfffffffff
> - the device_c needs dma_mask as 0xfffffff0, assume it has only 28 address lines

This makes no sense. You always need a dma mask, so the first case doesn't exist,
and the second one is the default.

In the third case, I assume you mean 0x0fffffff, which is a 28-bit mask.

> My questions are:
> - Can we not set dma_mask at driver, and only set dma-ranges at dts for device_b
> and device_c as a solution to cover this different dma mask use case?

try to understand my earlier reply. What is the problem with device_b?
Is that a limitation of the bus it is connected to, or the version of the
chipidea hardware?

> - If we can't use this solution, would you suggest one?

It depends on what the requirement of the hardware is, as I explained
now for three times.

> - If we can use this solution, for device_b and device_c, how can we write dma-ranges?
> I can't find any arm platforms use it, only some powerpc platform use it.
> According to the definition from Power_ePAPR_APPROVED_v1.1.pdf, it is
> dma-ranges = <child-bus-address, parent-bus-address, length>
> but I find the powerpc has different way for using dma-ranges. 

It's now handled by of_dma_configure() in drivers/of/platform.c for all
architectures.

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: "Peter Chen" <Peter.Chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
	"thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org"
	<thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
	"zmxu-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org"
	<zmxu-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
	"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"Antoine Ténart"
	<antoine.tenart-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
	"linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"balbi-l0cyMroinI0@public.gmane.org"
	<balbi-l0cyMroinI0@public.gmane.org>,
	"alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org"
	<alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
	"p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org"
	<p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
	"jszhang-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org"
	<jszhang-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
	"sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org"
	<sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH v3 07/12] usb: chipidea: add a usb2 driver for ci13xxx
Date: Thu, 17 Jul 2014 12:21:56 +0200	[thread overview]
Message-ID: <5456516.0fVZeXjF8k@wuerfel> (raw)
In-Reply-To: <93903d5fdf85427bb8a418894540c122-RQSpjbwlmjS6oBnG8T5U3ZwN6zqB+hSMnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>

On Thursday 17 July 2014 01:20:54 Peter Chen wrote:
> Thanks, arnd.
> 
> For chipidea generic glue layer case, if there are three devices who use this
> driver, and all devices have 32-bit bus, some devices have less 32 address lines.
> For example:
> 
> - the device_a doesn't need to use dma_mask
> - the device_b needs dma_mask as 0xfffffffff
> - the device_c needs dma_mask as 0xfffffff0, assume it has only 28 address lines

This makes no sense. You always need a dma mask, so the first case doesn't exist,
and the second one is the default.

In the third case, I assume you mean 0x0fffffff, which is a 28-bit mask.

> My questions are:
> - Can we not set dma_mask at driver, and only set dma-ranges at dts for device_b
> and device_c as a solution to cover this different dma mask use case?

try to understand my earlier reply. What is the problem with device_b?
Is that a limitation of the bus it is connected to, or the version of the
chipidea hardware?

> - If we can't use this solution, would you suggest one?

It depends on what the requirement of the hardware is, as I explained
now for three times.

> - If we can use this solution, for device_b and device_c, how can we write dma-ranges?
> I can't find any arm platforms use it, only some powerpc platform use it.
> According to the definition from Power_ePAPR_APPROVED_v1.1.pdf, it is
> dma-ranges = <child-bus-address, parent-bus-address, length>
> but I find the powerpc has different way for using dma-ranges. 

It's now handled by of_dma_configure() in drivers/of/platform.c for all
architectures.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: "Peter Chen" <Peter.Chen@freescale.com>,
	"thomas.petazzoni@free-electrons.com"
	<thomas.petazzoni@free-electrons.com>,
	"zmxu@marvell.com" <zmxu@marvell.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"Antoine Ténart" <antoine.tenart@free-electrons.com>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"balbi@ti.com" <balbi@ti.com>,
	"alexandre.belloni@free-electrons.com"
	<alexandre.belloni@free-electrons.com>,
	"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
	"jszhang@marvell.com" <jszhang@marvell.com>,
	"sebastian.hesselbarth@gmail.com"
	<sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH v3 07/12] usb: chipidea: add a usb2 driver for ci13xxx
Date: Thu, 17 Jul 2014 12:21:56 +0200	[thread overview]
Message-ID: <5456516.0fVZeXjF8k@wuerfel> (raw)
In-Reply-To: <93903d5fdf85427bb8a418894540c122@BN1PR0301MB0772.namprd03.prod.outlook.com>

On Thursday 17 July 2014 01:20:54 Peter Chen wrote:
> Thanks, arnd.
> 
> For chipidea generic glue layer case, if there are three devices who use this
> driver, and all devices have 32-bit bus, some devices have less 32 address lines.
> For example:
> 
> - the device_a doesn't need to use dma_mask
> - the device_b needs dma_mask as 0xfffffffff
> - the device_c needs dma_mask as 0xfffffff0, assume it has only 28 address lines

This makes no sense. You always need a dma mask, so the first case doesn't exist,
and the second one is the default.

In the third case, I assume you mean 0x0fffffff, which is a 28-bit mask.

> My questions are:
> - Can we not set dma_mask at driver, and only set dma-ranges at dts for device_b
> and device_c as a solution to cover this different dma mask use case?

try to understand my earlier reply. What is the problem with device_b?
Is that a limitation of the bus it is connected to, or the version of the
chipidea hardware?

> - If we can't use this solution, would you suggest one?

It depends on what the requirement of the hardware is, as I explained
now for three times.

> - If we can use this solution, for device_b and device_c, how can we write dma-ranges?
> I can't find any arm platforms use it, only some powerpc platform use it.
> According to the definition from Power_ePAPR_APPROVED_v1.1.pdf, it is
> dma-ranges = <child-bus-address, parent-bus-address, length>
> but I find the powerpc has different way for using dma-ranges. 

It's now handled by of_dma_configure() in drivers/of/platform.c for all
architectures.

	Arnd

  reply	other threads:[~2014-07-17 10:21 UTC|newest]

Thread overview: 93+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-16  8:25 [PATCH v3 00/12] ARM: berlin: USB support Antoine Ténart
2014-07-16  8:25 ` Antoine Ténart
2014-07-16  8:25 ` Antoine Ténart
2014-07-16  8:25 ` [PATCH v3 01/12] reset: add the Berlin reset controller driver Antoine Ténart
2014-07-16  8:25   ` Antoine Ténart
2014-07-16 16:39   ` Andrew Lunn
2014-07-16 16:39     ` Andrew Lunn
2014-07-16 16:39     ` Andrew Lunn
2014-07-16  8:25 ` [PATCH v3 02/12] Documentation: bindings: add reset bindings docs for Marvell Berlin SoCs Antoine Ténart
2014-07-16  8:25   ` Antoine Ténart
2014-07-16  8:25   ` Antoine Ténart
2014-07-16  8:25 ` [PATCH v3 03/12] ARM: Berlin: select the reset controller Antoine Ténart
2014-07-16  8:25   ` Antoine Ténart
2014-07-16  8:25   ` Antoine Ténart
2014-07-16  8:25 ` [PATCH v3 04/12] ARM: dts: berlin: add a required reset property in the chip controller node Antoine Ténart
2014-07-16  8:25   ` Antoine Ténart
2014-07-16  8:25   ` Antoine Ténart
2014-07-16  8:25 ` [PATCH v3 05/12] phy: add the Berlin USB PHY driver Antoine Ténart
2014-07-16  8:25   ` Antoine Ténart
2014-07-16  8:25   ` Antoine Ténart
2014-07-16  9:19   ` Varka Bhadram
2014-07-16  9:19     ` Varka Bhadram
2014-07-16  9:19     ` Varka Bhadram
2014-07-16  9:25     ` Antoine Ténart
2014-07-16  9:25       ` Antoine Ténart
2014-07-16  9:25       ` Antoine Ténart
2014-07-16  9:33       ` Varka Bhadram
2014-07-16  9:33         ` Varka Bhadram
2014-07-16  9:33         ` Varka Bhadram
2014-07-16  9:47         ` Antoine Ténart
2014-07-16  9:47           ` Antoine Ténart
2014-07-16  9:50           ` Varka Bhadram
2014-07-16  9:50             ` Varka Bhadram
2014-07-16  8:26 ` [PATCH v3 06/12] Documentation: bindings: add doc for the Berlin USB PHY Antoine Ténart
2014-07-16  8:26   ` Antoine Ténart
2014-07-16  8:26   ` Antoine Ténart
2014-07-16  8:26 ` [PATCH v3 07/12] usb: chipidea: add a usb2 driver for ci13xxx Antoine Ténart
2014-07-16  8:26   ` Antoine Ténart
2014-07-16  8:26   ` Antoine Ténart
2014-07-16  8:41   ` Arnd Bergmann
2014-07-16  8:41     ` Arnd Bergmann
2014-07-16  8:41     ` Arnd Bergmann
2014-07-16  9:15     ` Antoine Ténart
2014-07-16  9:15       ` Antoine Ténart
2014-07-16  9:15       ` Antoine Ténart
2014-07-16 10:14       ` Arnd Bergmann
2014-07-16 10:14         ` Arnd Bergmann
2014-07-16 10:14         ` Arnd Bergmann
2014-07-16 11:58         ` Peter Chen
2014-07-16 11:58           ` Peter Chen
2014-07-16 12:12           ` Arnd Bergmann
2014-07-16 12:12             ` Arnd Bergmann
2014-07-16 12:12             ` Arnd Bergmann
2014-07-17  1:20             ` Peter Chen
2014-07-17  1:20               ` Peter Chen
2014-07-17  1:20               ` Peter Chen
2014-07-17 10:21               ` Arnd Bergmann [this message]
2014-07-17 10:21                 ` Arnd Bergmann
2014-07-17 10:21                 ` Arnd Bergmann
2014-07-17 11:19                 ` Peter Chen
2014-07-17 11:19                   ` Peter Chen
2014-07-17 11:19                   ` Peter Chen
2014-07-17 11:34                   ` Arnd Bergmann
2014-07-17 11:34                     ` Arnd Bergmann
2014-07-17 12:20                   ` Russell King - ARM Linux
2014-07-17 12:20                     ` Russell King - ARM Linux
2014-07-25  2:18   ` Peter Chen
2014-07-25  2:18     ` Peter Chen
2014-07-25  2:18     ` Peter Chen
2014-07-25  8:07     ` Antoine Ténart
2014-07-25  8:07       ` Antoine Ténart
2014-07-25  8:07       ` Antoine Ténart
2014-07-25  8:22       ` Peter Chen
2014-07-25  8:22         ` Peter Chen
2014-07-16  8:26 ` [PATCH v3 08/12] Documentation: bindings: add doc for the USB2 ChipIdea USB driver Antoine Ténart
2014-07-16  8:26   ` Antoine Ténart
2014-07-16  8:26   ` Antoine Ténart
2014-07-16  8:39   ` Arnd Bergmann
2014-07-16  8:39     ` Arnd Bergmann
2014-07-16  8:39     ` Arnd Bergmann
2014-07-16  8:59     ` Antoine Ténart
2014-07-16  8:59       ` Antoine Ténart
2014-07-16  8:26 ` [PATCH v3 09/12] ARM: dts: berlin: add BG2Q nodes for USB support Antoine Ténart
2014-07-16  8:26   ` Antoine Ténart
2014-07-16  8:26   ` Antoine Ténart
2014-07-16  8:26 ` [PATCH v3 10/12] ARM: dts: Berlin: enable USB on the BG2Q DMP Antoine Ténart
2014-07-16  8:26   ` Antoine Ténart
2014-07-16  8:26   ` Antoine Ténart
2014-07-16  8:26 ` [PATCH v3 11/12] ARM: dts: berlin: add BG2CD nodes for USB support Antoine Ténart
2014-07-16  8:26   ` Antoine Ténart
2014-07-16  8:26   ` Antoine Ténart
2014-07-16  8:26 ` [PATCH v3 12/12] ARM: dts: berlin: enable USB on the Google Chromecast Antoine Ténart
2014-07-16  8:26   ` Antoine Ténart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5456516.0fVZeXjF8k@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.