From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: Richard Weinberger <richard@nod.at>,
hch@infradead.org, axboe@fb.com, dedekind1@gmail.com
Cc: linux-mtd@lists.infradead.org, computersforpeace@gmail.com,
dwmw2@infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] UBI: Block: Add blk-mq support
Date: Sun, 02 Nov 2014 18:52:07 -0300 [thread overview]
Message-ID: <5456A787.5060104@free-electrons.com> (raw)
In-Reply-To: <1414933255-3795-1-git-send-email-richard@nod.at>
[-- Attachment #1: Type: text/plain, Size: 783 bytes --]
Hi Richard,
On 11/02/2014 10:00 AM, Richard Weinberger wrote:
> Convert the driver to blk-mq.
>
Maybe you can explain a bit better what's this all about?
Both the commit that introduces blk-mq and the paper on it talk about
high IOPS devices, multi-core, NUMA systems. I'm not sure this is the
case for UBI-based devices.
Probably some numbers would help us decide. Does the patch increases the
dynamic memory footprint? Is there any performance benefit?
I kind of like the negative diffstat, but the code doesn't look cleaner
or simpler.
In other words, we need a good reason before we agree on making this
"zen style" driver more complex.
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: Richard Weinberger <richard@nod.at>,
hch@infradead.org, axboe@fb.com, dedekind1@gmail.com
Cc: dwmw2@infradead.org, computersforpeace@gmail.com,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] UBI: Block: Add blk-mq support
Date: Sun, 02 Nov 2014 18:52:07 -0300 [thread overview]
Message-ID: <5456A787.5060104@free-electrons.com> (raw)
In-Reply-To: <1414933255-3795-1-git-send-email-richard@nod.at>
[-- Attachment #1: Type: text/plain, Size: 783 bytes --]
Hi Richard,
On 11/02/2014 10:00 AM, Richard Weinberger wrote:
> Convert the driver to blk-mq.
>
Maybe you can explain a bit better what's this all about?
Both the commit that introduces blk-mq and the paper on it talk about
high IOPS devices, multi-core, NUMA systems. I'm not sure this is the
case for UBI-based devices.
Probably some numbers would help us decide. Does the patch increases the
dynamic memory footprint? Is there any performance benefit?
I kind of like the negative diffstat, but the code doesn't look cleaner
or simpler.
In other words, we need a good reason before we agree on making this
"zen style" driver more complex.
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-11-02 21:54 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-02 13:00 [PATCH] UBI: Block: Add blk-mq support Richard Weinberger
2014-11-02 13:00 ` Richard Weinberger
2014-11-02 21:52 ` Ezequiel Garcia [this message]
2014-11-02 21:52 ` Ezequiel Garcia
2014-11-02 22:21 ` Richard Weinberger
2014-11-02 22:21 ` Richard Weinberger
2014-11-02 22:27 ` Ezequiel Garcia
2014-11-02 22:27 ` Ezequiel Garcia
2014-11-02 22:49 ` Richard Weinberger
2014-11-02 22:49 ` Richard Weinberger
2014-11-03 1:20 ` Jens Axboe
2014-11-03 1:20 ` Jens Axboe
2014-11-03 1:18 ` Jens Axboe
2014-11-03 1:18 ` Jens Axboe
2014-11-03 5:03 ` Ming Lei
2014-11-03 5:03 ` Ming Lei
2014-11-03 13:58 ` Ezequiel Garcia
2014-11-03 13:58 ` Ezequiel Garcia
2014-11-03 18:22 ` Richard Weinberger
2014-11-03 18:22 ` Richard Weinberger
2014-11-03 8:18 ` Christoph Hellwig
2014-11-03 8:18 ` Christoph Hellwig
2014-11-03 8:23 ` Richard Weinberger
2014-11-03 8:23 ` Richard Weinberger
2014-11-07 9:46 ` Artem Bityutskiy
2014-11-07 9:46 ` Artem Bityutskiy
2014-11-07 9:53 ` Richard Weinberger
2014-11-07 9:53 ` Richard Weinberger
2014-11-07 9:56 ` Artem Bityutskiy
2014-11-07 9:56 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5456A787.5060104@free-electrons.com \
--to=ezequiel.garcia@free-electrons.com \
--cc=axboe@fb.com \
--cc=computersforpeace@gmail.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.