All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bo Shen <voice.shen@atmel.com>
To: Mark Brown <broonie@kernel.org>, Peter Rosin <peda@axentia.se>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: atmel_ssc_dai: Match the CMR divider only in full duplex.
Date: Mon, 3 Nov 2014 09:25:29 +0800	[thread overview]
Message-ID: <5456D989.8000108@atmel.com> (raw)
In-Reply-To: <20141031181210.GQ18557@sirena.org.uk>

Hi Mark,

On 11/01/2014 02:12 AM, Mark Brown wrote:
> On Fri, Oct 24, 2014 at 09:25:59PM +0200, Peter Rosin wrote:
>> The CMR divider register is shared by playback and capture. The SSC driver
>> therefore tries to enforce rules so that the needed register content do
>> not conflict during simultaneous playback/capture. However, the
>> implementation also prevents changing the register content in
>> half-duplex scenarios, which is needed when using the OSS API.
>
> Bo, is this OK?

I have acked this patch. However Peter resend with "git send-email" 
command while not add Acked-by tag. Anyway:

Acked-by: Bo Shen <voice.shen@atmel.com>

Best Regards,
Bo Shen

WARNING: multiple messages have this Message-ID (diff)
From: Bo Shen <voice.shen@atmel.com>
To: Mark Brown <broonie@kernel.org>, Peter Rosin <peda@axentia.se>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
	<alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: atmel_ssc_dai: Match the CMR divider only in full duplex.
Date: Mon, 3 Nov 2014 09:25:29 +0800	[thread overview]
Message-ID: <5456D989.8000108@atmel.com> (raw)
In-Reply-To: <20141031181210.GQ18557@sirena.org.uk>

Hi Mark,

On 11/01/2014 02:12 AM, Mark Brown wrote:
> On Fri, Oct 24, 2014 at 09:25:59PM +0200, Peter Rosin wrote:
>> The CMR divider register is shared by playback and capture. The SSC driver
>> therefore tries to enforce rules so that the needed register content do
>> not conflict during simultaneous playback/capture. However, the
>> implementation also prevents changing the register content in
>> half-duplex scenarios, which is needed when using the OSS API.
>
> Bo, is this OK?

I have acked this patch. However Peter resend with "git send-email" 
command while not add Acked-by tag. Anyway:

Acked-by: Bo Shen <voice.shen@atmel.com>

Best Regards,
Bo Shen


  reply	other threads:[~2014-11-03  1:25 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-22 15:13 [PATCH v2] ASoC: atmel_ssc_dai: Match the CMR divider only in full duplex Peter Rosin
2014-10-24  3:15 ` Bo Shen
2014-10-24  3:15   ` Bo Shen
2014-10-24  7:13   ` Peter Rosin
2014-10-24  7:13     ` Peter Rosin
2014-10-24  8:43     ` Bo Shen
2014-10-24 19:25       ` Peter Rosin
2014-10-24 19:25         ` Peter Rosin
2014-10-24 19:25         ` [PATCH] " Peter Rosin
2014-10-24 19:25           ` Peter Rosin
2014-10-31 18:12           ` Mark Brown
2014-11-03  1:25             ` Bo Shen [this message]
2014-11-03  1:25               ` Bo Shen
2014-11-03 12:45           ` Mark Brown
2014-10-24  8:46     ` [PATCH v2] " Bo Shen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5456D989.8000108@atmel.com \
    --to=voice.shen@atmel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peda@axentia.se \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.