All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: zhanghailiang <zhang.zhanghailiang@huawei.com>,  qemu-trivial@nongnu.org
Cc: pbonzini@redhat.com, eblake@redhat.com, qemu-devel@nongnu.org,
	peter.huangpeng@huawei.com
Subject: Re: [Qemu-trivial] [PATCH v2 5/5] spice-qemu-char: convert qemu_chr_open_spice_vmc to use Error API
Date: Mon, 03 Nov 2014 13:04:52 +0300	[thread overview]
Message-ID: <54575344.1080609@msgid.tls.msk.ru> (raw)
In-Reply-To: <1415007872-8228-6-git-send-email-zhang.zhanghailiang@huawei.com>

03.11.2014 12:44, zhanghailiang wrote:
[]
> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -4252,7 +4252,7 @@ ChardevReturn *qmp_chardev_add(const char *id, ChardevBackend *backend,
>  #endif
>  #ifdef CONFIG_SPICE
>      case CHARDEV_BACKEND_KIND_SPICEVMC:
> -        chr = qemu_chr_open_spice_vmc(backend->spicevmc->type);
> +        chr = qemu_chr_open_spice_vmc(backend->spicevmc->type, errp);
>          break;
>      case CHARDEV_BACKEND_KIND_SPICEPORT:
>          chr = qemu_chr_open_spice_port(backend->spiceport->fqdn);

Now this is funny.  Why we have two functions nearby using different
error reporting APIs?  Maybe qemu_chr_open_spice_port() should be
converted to Error API too, at the same time (maybe in the same
patch or in a subsequent patch in the same series)?

Thanks,

/mjt


WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: zhanghailiang <zhang.zhanghailiang@huawei.com>, qemu-trivial@nongnu.org
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, peter.huangpeng@huawei.com
Subject: Re: [Qemu-devel] [PATCH v2 5/5] spice-qemu-char: convert qemu_chr_open_spice_vmc to use Error API
Date: Mon, 03 Nov 2014 13:04:52 +0300	[thread overview]
Message-ID: <54575344.1080609@msgid.tls.msk.ru> (raw)
In-Reply-To: <1415007872-8228-6-git-send-email-zhang.zhanghailiang@huawei.com>

03.11.2014 12:44, zhanghailiang wrote:
[]
> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -4252,7 +4252,7 @@ ChardevReturn *qmp_chardev_add(const char *id, ChardevBackend *backend,
>  #endif
>  #ifdef CONFIG_SPICE
>      case CHARDEV_BACKEND_KIND_SPICEVMC:
> -        chr = qemu_chr_open_spice_vmc(backend->spicevmc->type);
> +        chr = qemu_chr_open_spice_vmc(backend->spicevmc->type, errp);
>          break;
>      case CHARDEV_BACKEND_KIND_SPICEPORT:
>          chr = qemu_chr_open_spice_port(backend->spiceport->fqdn);

Now this is funny.  Why we have two functions nearby using different
error reporting APIs?  Maybe qemu_chr_open_spice_port() should be
converted to Error API too, at the same time (maybe in the same
patch or in a subsequent patch in the same series)?

Thanks,

/mjt

  reply	other threads:[~2014-11-03 10:05 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-03  9:44 [Qemu-trivial] [PATCH v2 0/5] Trivial patch about qemu-char zhanghailiang
2014-11-03  9:44 ` [Qemu-devel] " zhanghailiang
2014-11-03  9:44 ` [Qemu-trivial] [PATCH v2 1/5] qemu-char: fix parameter check for some qemu_chr_parse_* functions zhanghailiang
2014-11-03  9:44   ` [Qemu-devel] " zhanghailiang
2014-11-03  9:44 ` [Qemu-trivial] [PATCH v2 2/5] qemu-char: remove unnecessary in-parameter check for qemu_chr_parse_pipe zhanghailiang
2014-11-03  9:44   ` [Qemu-devel] " zhanghailiang
2014-11-03  9:44 ` [Qemu-trivial] [PATCH v2 3/5] spice-qemu-char: fix parameter checks for qemu_chr_parse_* functions zhanghailiang
2014-11-03  9:44   ` [Qemu-devel] " zhanghailiang
2014-11-03  9:44 ` [Qemu-trivial] [PATCH v2 4/5] qemu-char: convert some open functions to use Error API zhanghailiang
2014-11-03  9:44   ` [Qemu-devel] " zhanghailiang
2014-11-03  9:44 ` [Qemu-trivial] [PATCH v2 5/5] spice-qemu-char: convert qemu_chr_open_spice_vmc " zhanghailiang
2014-11-03  9:44   ` [Qemu-devel] " zhanghailiang
2014-11-03 10:04   ` Michael Tokarev [this message]
2014-11-03 10:04     ` Michael Tokarev
2014-11-03 11:17     ` [Qemu-trivial] " zhanghailiang
2014-11-03 11:17       ` [Qemu-devel] " zhanghailiang
2014-11-03 10:03 ` [Qemu-trivial] [PATCH v2 0/5] Trivial patch about qemu-char Michael Tokarev
2014-11-03 10:03   ` [Qemu-devel] " Michael Tokarev
2014-11-03 11:39   ` [Qemu-trivial] " zhanghailiang
2014-11-03 11:39     ` [Qemu-devel] " zhanghailiang
2014-11-03 14:10     ` [Qemu-trivial] " Michael Tokarev
2014-11-03 14:10       ` [Qemu-devel] " Michael Tokarev
2014-11-04  2:17       ` [Qemu-trivial] " zhanghailiang
2014-11-04  2:17         ` [Qemu-devel] " zhanghailiang
2014-11-03 15:33     ` [Qemu-trivial] " Markus Armbruster
2014-11-03 15:33       ` Markus Armbruster
2014-11-04  2:20       ` [Qemu-trivial] " zhanghailiang
2014-11-04  2:20         ` zhanghailiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54575344.1080609@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=eblake@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.huangpeng@huawei.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=zhang.zhanghailiang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.