From: "Janusz Użycki" <j.uzycki-9tnw74Q4ehaHKKo6LODCOg@public.gmane.org>
To: Mike Turquette
<mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Thierry Reding
<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Philipp Zabel <p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-pwm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] clk: Add PWM clock driver
Date: Mon, 03 Nov 2014 18:45:59 +0100 [thread overview]
Message-ID: <5457BF57.3020906@elproma.com.pl> (raw)
In-Reply-To: <20140927200122.19023.40310@quantum>
W dniu 2014-09-27 o 22:01, Mike Turquette pisze:
> Quoting Thierry Reding (2014-09-23 01:51:31)
>> On Wed, Sep 10, 2014 at 10:05:17PM +0200, Janusz Użycki wrote:
>>> Hi,
>>>
>>> http://patchwork.ozlabs.org/patch/359069/
>>> https://lkml.org/lkml/2014/6/12/186
>>>
>>> Will the patch ever included to linux-next?
>> I've never seen this patch before. From a quick look it doesn't seem
>> like it would work as is, but the idea is certainly interesting. If
>> somebody decides to continue work on it, please Cc me and the linux-pwm
>> mailing list.
> I just merged a gpio-controlled clock gate and I'm fine with a PWM clock
> output.
>
> Janusz, how are you testing the clock driver?
Sorry, I didn't noticed the email.
I didn't test the patch yet. However I plan to check it this year.
best regards
Janusz
>
> Regards,
> Mike
>
>>> pwm_config() API could be extended to support
>>> not only period [ns] and duty [ns] time
>>> but also frequency [Hz] and duty cycle fraction [1/1000?]
>>> (instead of time in ns) as parameters.
>>> Then ns (rounded by pwm) to freq. conversion problem
>>> inclk_pwm_recalc_rate() usingpwm_get_period()
>>> could be avoided.
>>> To extend the API pwm_config() can support
>>> new flags forduty_ns and period_ns,
>>> eg. PWM_DUTY_PERCENT and PWM_PERIOD_HZ.
>> Is that rounding really a problem? Also the PWM chips will most likely
>> use the concept of period and duty-cycle internally anyway, so it will
>> convert back from Hz/percentage to nanoseconds and fall victim to
>> similar rounding effects.
>>
>> Thierry
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: "Janusz Użycki" <j.uzycki@elproma.com.pl>
To: Mike Turquette <mturquette@linaro.org>,
Thierry Reding <thierry.reding@gmail.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-pwm@vger.kernel.org
Subject: Re: [PATCH] clk: Add PWM clock driver
Date: Mon, 03 Nov 2014 18:45:59 +0100 [thread overview]
Message-ID: <5457BF57.3020906@elproma.com.pl> (raw)
In-Reply-To: <20140927200122.19023.40310@quantum>
W dniu 2014-09-27 o 22:01, Mike Turquette pisze:
> Quoting Thierry Reding (2014-09-23 01:51:31)
>> On Wed, Sep 10, 2014 at 10:05:17PM +0200, Janusz Użycki wrote:
>>> Hi,
>>>
>>> http://patchwork.ozlabs.org/patch/359069/
>>> https://lkml.org/lkml/2014/6/12/186
>>>
>>> Will the patch ever included to linux-next?
>> I've never seen this patch before. From a quick look it doesn't seem
>> like it would work as is, but the idea is certainly interesting. If
>> somebody decides to continue work on it, please Cc me and the linux-pwm
>> mailing list.
> I just merged a gpio-controlled clock gate and I'm fine with a PWM clock
> output.
>
> Janusz, how are you testing the clock driver?
Sorry, I didn't noticed the email.
I didn't test the patch yet. However I plan to check it this year.
best regards
Janusz
>
> Regards,
> Mike
>
>>> pwm_config() API could be extended to support
>>> not only period [ns] and duty [ns] time
>>> but also frequency [Hz] and duty cycle fraction [1/1000?]
>>> (instead of time in ns) as parameters.
>>> Then ns (rounded by pwm) to freq. conversion problem
>>> inclk_pwm_recalc_rate() usingpwm_get_period()
>>> could be avoided.
>>> To extend the API pwm_config() can support
>>> new flags forduty_ns and period_ns,
>>> eg. PWM_DUTY_PERCENT and PWM_PERIOD_HZ.
>> Is that rounding really a problem? Also the PWM chips will most likely
>> use the concept of period and duty-cycle internally anyway, so it will
>> convert back from Hz/percentage to nanoseconds and fall victim to
>> similar rounding effects.
>>
>> Thierry
>
next prev parent reply other threads:[~2014-11-03 17:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-10 20:05 [PATCH] clk: Add PWM clock driver Janusz Użycki
[not found] ` <5410AEFD.5030302-9tnw74Q4ehaHKKo6LODCOg@public.gmane.org>
2014-09-23 8:51 ` Thierry Reding
2014-09-23 8:51 ` Thierry Reding
2014-09-27 20:01 ` Mike Turquette
2014-11-03 17:45 ` Janusz Użycki [this message]
2014-11-03 17:45 ` Janusz Użycki
2014-11-04 11:55 ` Philipp Zabel
-- strict thread matches above, loose matches on Subject: below --
2014-06-12 10:08 Philipp Zabel
2014-06-12 10:08 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5457BF57.3020906@elproma.com.pl \
--to=j.uzycki-9tnw74q4ehahkko6lodcog@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-pwm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.