All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Keir Fraser <keir@xen.org>,
	Ian Campbell <Ian.Campbell@citrix.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
	Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH v2 for-4.5] xen: Bump Xen interface for Xen-4.5
Date: Tue, 04 Nov 2014 12:00:39 +0000	[thread overview]
Message-ID: <5458CDF70200007800044C30@mail.emea.novell.com> (raw)
In-Reply-To: <1415101802-24096-1-git-send-email-andrew.cooper3@citrix.com>

>>> On 04.11.14 at 12:50, <andrew.cooper3@citrix.com> wrote:
> c/s fce5281c "x86/mem_access: Deprecate the HVM mem_access ops" removes the
> structures associated with xen_hvm_{get,set}_mem_access from the Xen public
> API.
> 
> While these were toolstack hypercalls and documented as liable to change in
> the future, it causes build issues for certain tools (valgrind, strace).
> 
> As HVM ops have no specific interface version, the main Xen interface 
> version
> needs to be bumped to compensate.

Content-wise I don't really object to this patch, but I view it as
merely cosmetic rather than fixing anything: Tool stack interfaces
are declared to be volatile just because we want to avoid exactly
this need for bumping versions or anything when altering or
dropping them. If there are out of tree consumers of them, it is
their responsibility to keep up with our changes (or have their
own clones of the canonical headers).

Also we didn't bother incrementing the version just because of a
release on earlier occasions: 3.3 and 3.4 as well as 4.0 and 4.1
shared interface versions, yet especially in the case of 4.1 I'm
pretty certain even without explicitly checking that there were
tool stack interface changes.

Jan

  reply	other threads:[~2014-11-04 12:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-04 11:44 [PATCH for-4.5] xen: Bump several interface versions in preparation for Xen-4.5 Andrew Cooper
2014-11-04 11:46 ` Andrew Cooper
2014-11-04 11:50   ` [PATCH v2 for-4.5] xen: Bump Xen interface " Andrew Cooper
2014-11-04 12:00     ` Jan Beulich [this message]
2014-11-04 12:08       ` Ian Campbell
2014-11-04 12:24         ` Jan Beulich
2014-11-04 12:07     ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5458CDF70200007800044C30@mail.emea.novell.com \
    --to=jbeulich@suse.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=keir@xen.org \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.