All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oliver Hartkopp <socketcan@hartkopp.net>
To: "Thomas Körper" <thomas.koerper@esd.eu>,
	"Marc Kleine-Budde" <mkl@pengutronix.de>
Cc: linux-can@vger.kernel.org
Subject: Re: [PATCH v3 1/1] can: Add support for esd CAN PCIe/402 card
Date: Tue, 04 Nov 2014 14:24:02 +0100	[thread overview]
Message-ID: <5458D372.3020604@hartkopp.net> (raw)
In-Reply-To: <1415080039-38327-1-git-send-email-thomas.koerper@esd.eu>

Hello Thomas,

looks far better to me now. Thanks.

@Marc: The only two questions I would have is this pretty short commit message 
and the module parameter.
What do you think about it (and the rest)?

Regards,
Oliver

On 04.11.2014 06:47, Thomas Körper wrote:
> See http://esd.eu/en/products/can-pcie402 for hardware details.
>
> Signed-off-by: Thomas Körper <thomas.koerper@esd.eu>


> +
> +static int dump_infos;
> +module_param(dump_infos, int, S_IRUGO);
> +MODULE_PARM_DESC(dump_infos, "Dump card infos while probing. Default: 0 (Off)");


  reply	other threads:[~2014-11-04 13:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-04  5:47 [PATCH v3 1/1] can: Add support for esd CAN PCIe/402 card Thomas Körper
2014-11-04 13:24 ` Oliver Hartkopp [this message]
2014-11-04 13:26   ` Marc Kleine-Budde
2014-11-05  4:21     ` AW: " Thomas Körper
2014-11-05  9:12       ` Oliver Hartkopp
2014-11-05 10:11         ` Marc Kleine-Budde
2015-03-16 11:45       ` Thomas Körper
2015-03-16 11:53         ` Marc Kleine-Budde
2015-03-16 12:00           ` Oliver Hartkopp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5458D372.3020604@hartkopp.net \
    --to=socketcan@hartkopp.net \
    --cc=linux-can@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=thomas.koerper@esd.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.