From: Marc Kleine-Budde <mkl@pengutronix.de>
To: "Oliver Hartkopp" <socketcan@hartkopp.net>,
"Thomas Körper" <thomas.koerper@esd.eu>
Cc: linux-can@vger.kernel.org
Subject: Re: [PATCH v3 1/1] can: Add support for esd CAN PCIe/402 card
Date: Tue, 04 Nov 2014 14:26:27 +0100 [thread overview]
Message-ID: <5458D403.9040803@pengutronix.de> (raw)
In-Reply-To: <5458D372.3020604@hartkopp.net>
[-- Attachment #1: Type: text/plain, Size: 769 bytes --]
On 11/04/2014 02:24 PM, Oliver Hartkopp wrote:
> Hello Thomas,
>
> looks far better to me now. Thanks.
>
> @Marc: The only two questions I would have is this pretty short commit
> message and the module parameter.
> What do you think about it (and the rest)?
Yes, the commit message should be a bit more verbose. And the module
parameter should probably be removed.
I'm currently reviewing Stefano Babic's SPI driver, which has been
waiting for review a bit longer.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-11-04 13:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 5:47 [PATCH v3 1/1] can: Add support for esd CAN PCIe/402 card Thomas Körper
2014-11-04 13:24 ` Oliver Hartkopp
2014-11-04 13:26 ` Marc Kleine-Budde [this message]
2014-11-05 4:21 ` AW: " Thomas Körper
2014-11-05 9:12 ` Oliver Hartkopp
2014-11-05 10:11 ` Marc Kleine-Budde
2015-03-16 11:45 ` Thomas Körper
2015-03-16 11:53 ` Marc Kleine-Budde
2015-03-16 12:00 ` Oliver Hartkopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5458D403.9040803@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=socketcan@hartkopp.net \
--cc=thomas.koerper@esd.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.